Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config)_: integrate new rpc providers configs #6178

Open
wants to merge 1 commit into
base: ab/issue-5997-rpc-providers-configuration
Choose a base branch
from

Conversation

friofry
Copy link
Contributor

@friofry friofry commented Dec 6, 2024

This is the follow-up PR for the improved RPC configuration. See description: #6151

@status-im-auto
Copy link
Member

status-im-auto commented Dec 6, 2024

Jenkins Builds

Click to see older builds (24)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ dc9415f #1 2024-12-06 13:16:17 ~4 min macos 📦zip
✔️ dc9415f #1 2024-12-06 13:16:28 ~4 min linux 📦zip
✔️ dc9415f #1 2024-12-06 13:16:30 ~4 min ios 📦zip
✖️ dc9415f #1 2024-12-06 13:16:35 ~4 min tests 📄log
✔️ dc9415f #1 2024-12-06 13:16:36 ~4 min windows 📦zip
✔️ dc9415f #1 2024-12-06 13:17:45 ~6 min android 📦aar
✖️ dc9415f #1 2024-12-06 13:18:36 ~6 min tests-rpc 📄log
✔️ dc9415f #1 2024-12-06 13:22:02 ~10 min macos 📦zip
✖️ e0e484f #2 2024-12-06 13:20:51 ~1 min tests 📄log
✔️ e0e484f #2 2024-12-06 13:22:37 ~3 min windows 📦zip
✔️ e0e484f #2 2024-12-06 13:23:45 ~4 min ios 📦zip
✔️ e0e484f #2 2024-12-06 13:25:25 ~5 min android 📦aar
✖️ e0e484f #2 2024-12-06 13:25:38 ~6 min tests-rpc 📄log
✔️ e0e484f #2 2024-12-06 13:25:45 ~6 min linux 📦zip
✔️ e0e484f #2 2024-12-06 13:25:54 ~6 min macos 📦zip
✔️ e0e484f #2 2024-12-06 13:30:46 ~8 min macos 📦zip
✖️ d2795bc #3 2024-12-06 13:25:08 ~1 min tests 📄log
✔️ d2795bc #3 2024-12-06 13:26:35 ~3 min windows 📦zip
✔️ d2795bc #3 2024-12-06 13:27:46 ~3 min ios 📦zip
✔️ d2795bc #3 2024-12-06 13:30:06 ~4 min macos 📦zip
✔️ d2795bc #3 2024-12-06 13:31:13 ~5 min android 📦aar
✔️ d2795bc #3 2024-12-06 13:31:24 ~5 min linux 📦zip
✖️ d2795bc #3 2024-12-06 13:31:35 ~5 min tests-rpc 📄log
✔️ d2795bc #3 2024-12-06 13:39:04 ~8 min macos 📦zip
Commit #️⃣ Finished (UTC) Duration Platform Result
526f19c #4 2025-01-07 14:37:19 ~25 sec windows 📄log
✖️ 526f19c #4 2025-01-07 14:38:26 ~1 min tests 📄log
✔️ 526f19c #4 2025-01-07 14:41:38 ~4 min macos 📦zip
✔️ 526f19c #4 2025-01-07 14:41:39 ~4 min linux 📦zip
✔️ 526f19c #4 2025-01-07 14:42:00 ~5 min android 📦aar
✔️ 526f19c #4 2025-01-07 14:42:02 ~5 min ios 📦zip
✖️ 526f19c #4 2025-01-07 14:42:50 ~5 min tests-rpc 📄log
✔️ 526f19c #4 2025-01-07 14:45:53 ~9 min macos 📦zip
54f6a89 #5 2025-01-09 13:35:45 ~25 sec windows 📄log
✖️ 54f6a89 #5 2025-01-09 13:36:48 ~1 min tests 📄log
✔️ 54f6a89 #5 2025-01-09 13:40:23 ~5 min macos 📦zip
✔️ 54f6a89 #5 2025-01-09 13:40:38 ~5 min linux 📦zip
✔️ 54f6a89 #5 2025-01-09 13:40:39 ~5 min ios 📦zip
✔️ 54f6a89 #5 2025-01-09 13:40:45 ~5 min android 📦aar
✖️ 54f6a89 #5 2025-01-09 13:41:21 ~6 min tests-rpc 📄log
✔️ 54f6a89 #5 2025-01-09 13:44:36 ~9 min macos 📦zip

@friofry friofry force-pushed the ab/issue-5997-rpc-providers-integration branch 2 times, most recently from e0e484f to d2795bc Compare December 6, 2024 13:23
@friofry
Copy link
Contributor Author

friofry commented Jan 6, 2025

todo:

  • > As discussed and agreed, we should ensure now that default status-provided networks are not stored in the database anymore, because it makes no sense and only adds confusion. We should only persist user-provided secrets here, but the status-provided secrets must remain built-in in the binary.

#6151 (comment)

@friofry
Copy link
Contributor Author

friofry commented Jan 6, 2025

@friofry friofry force-pushed the ab/issue-5997-rpc-providers-configuration branch 2 times, most recently from 1ecae6e to afb9730 Compare January 6, 2025 18:16
@friofry friofry force-pushed the ab/issue-5997-rpc-providers-integration branch from d2795bc to 526f19c Compare January 7, 2025 14:36
@friofry friofry requested a review from igor-sirotin January 7, 2025 14:49
* default_networks.go
  * explicit provider initialization with more granular config (rps limiter, order)
  * token overrides made more flexible, support not only infura and grove
* get_status_node.go
  * override status-proxy auth instead of passing override config to rpc/client.go
* config.go
  * ProviderConfig removed
* client.go
  * Now any provider can be enabled/disabled (if user wants to use only his custom RPC urls)
  * Use bearer auth instead of URL auth
  * Provider order is defined by default_networks.go
@friofry friofry force-pushed the ab/issue-5997-rpc-providers-integration branch from 526f19c to 54f6a89 Compare January 9, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants