chore_: remove waku api wrappers #6245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osmaczko
requested review from
a team,
richard-ramos,
chaitanyaprem and
igor-sirotin
Jenkins BuildsClick to see older builds (39)
|
igor-sirotin
approved these changes
Jan 10, 2025
osmaczko
force-pushed
the
chore/remove-waku-api-wrappers
branch
3 times, most recently
from
32ad247 to
fc6813b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6245 +/- ##
===========================================
+ Coverage 61.74% 61.77% +0.03%
===========================================
Files 845 843 -2
Lines 111323 111285 -38
===========================================
+ Hits 68739 68750 +11
+ Misses 34612 34575 -37
+ Partials 7972 7960 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
cc: @chaitanyaprem |
wakuv2/api.go
Outdated
| Timestamp: message.Sent, | ||
| Hash: message.Hash().Bytes(), | ||
| PubsubTopic: message.PubsubTopic, | ||
| Topic: types.TopicType(message.ContentTopic), |
There was a problem hiding this comment.
Why Topic instead of ContentTopic?
There was a problem hiding this comment.
nvm, I just saw that we're reusing the ReceivedMessage, and renamed it to Message. Probably a good moment to rename that property to ContentTopic, as it is easier to know what kind of topic are we dealing with!
richard-ramos
approved these changes
Jan 10, 2025
kaichaosun
approved these changes
Jan 13, 2025
osmaczko
force-pushed
the
chore/whisper-cleanup
branch
from
6dc3ce7 to
572bc4f
Compare
osmaczko
force-pushed
the
chore/remove-waku-api-wrappers
branch
from
fc6813b to
432039a
Compare
osmaczko
changed the base branch from
develop
to
chore/remove-waku-duplicates
osmaczko
force-pushed
the
chore/remove-waku-api-wrappers
branch
from
432039a to
f56eb37
Compare
|
You will need to rebase your branch on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed waku api wrappers and duplicated types, also cleaned up unused code.
closes #6302