Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENS resolving for IPNS names. #10974

Closed
decanus opened this issue Jul 20, 2020 · 2 comments · Fixed by #11128
Closed

ENS resolving for IPNS names. #10974

decanus opened this issue Jul 20, 2020 · 2 comments · Fixed by #11128

Comments

@decanus
Copy link
Contributor

decanus commented Jul 20, 2020

Bug Report

Recently I asked @hesterbruikman why ENS resolving does not work in browser. I was actually wrong on whether or not it works. If you use for example pactxt.eth in the browser it resolves. However uniswap.eth does not.

Problem

This is because there was an issue in the contenthash library that did not resolve names correctly when they were IPNS hashes. You can see a more detailed discussion here: ensdomains/ens-app#849. This was recently fixed in ENS which can be viewed here: ensdomains/ui#77.

Expected behavior

Names using IPNS names resolve properly in the browser.

Actual behavior

They currently do not.

Reproduction

  • Open Status
  • Open browser
  • Type uniswap.eth and hit enter
  • Name does not resolve.
@decanus decanus added the bug label Jul 20, 2020
@hesterbruikman
Copy link
Contributor

Thanks for adding this @decanus

Checking with @churik and @Serhy also noticed that some urls redirect to infura.status.im. Need to invest more time to understand how this works as I'm not sure why e.g. ethereum.eth directs to https://ciqg44hq64xcxtik22n3fmk65hqpj6egsp3lf5ef4sdjtz6w7dn5mkq.infura.status.im

Are we using a content hash library by Infura?

@decanus
Copy link
Contributor Author

decanus commented Jul 20, 2020

@hesterbruikman all names redirect, thats a correct resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants