Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable keeping database when migrating account to keycard #11777

Closed
guylouis opened this issue Feb 19, 2021 · 1 comment · Fixed by #12306
Closed

Enable keeping database when migrating account to keycard #11777

guylouis opened this issue Feb 19, 2021 · 1 comment · Fixed by #12306
Assignees
@bitgamma
Labels
feature feature requests
Milestone
Release 1.16

Comments

@guylouis
Copy link
Contributor

guylouis commented Feb 19, 2021 •
edited by StatusWrike
Loading

relates to #11431 "Migrate account to a regular keycard from logged out "Manage keys and storage"

When solving #11431 we intentionally left out the case where the user wants to keep its data base when migrating. So the user is forced to reset its database and the check box is checked and greyed out in flow like this https://www.figma.com/file/dEIljL7UPbXgsZUA0Q4qlE5E/Onboarding?node-id=8218%3A7450

This issue is about enabling the user to keep its database

  • having "reset database" unchecked by default
  • letting the user checks it or not

Figma design
https://www.figma.com/file/dEIljL7UPbXgsZUA0Q4qlE5E/Onboarding?node-id=8218%3A8089
@guylouis guylouis added feature feature requests keycard labels Feb 19, 2021
@cammellos cammellos added this to the Release 1.13 milestone Mar 10, 2021
@shivekkhurana
Copy link
Contributor

shivekkhurana commented Mar 17, 2021 •
edited
Loading

This feature requires a "password reset" feature as a foundation. I wasn't able to find an issue for that Issue link: status-im/status#48

@flexsurfer flexsurfer modified the milestones: Release 1.13, Release 1.14 Apr 20, 2021
@guylouis guylouis mentioned this issue May 27, 2021
Closed
@cammellos cammellos removed this from the Release 1.14 milestone Jun 22, 2021
@shivekkhurana shivekkhurana mentioned this issue Jun 30, 2021
Merged
@bitgamma bitgamma self-assigned this Jul 6, 2021
This was referenced Jul 13, 2021
Merged
Merged
@bitgamma bitgamma added this to the Release 1.16 milestone Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bitgamma bitgamma

Labels
feature feature requests
Projects
None yet
Milestone
Release 1.16
Development

Successfully merging a pull request may close this issue.

allow migration to Keycard keeping the db status-im/status-mobile
5 participants
@cammellos @shivekkhurana @guylouis @flexsurfer @bitgamma