-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate a regular multiaccount to a keycard #11237
Comments
@errorists @hesterbruikman could you please have a look at this from the UI/UX perspective so we can get it ready for development? |
@guylouis thanks for the clear description! To make it explicit. The scope of this issue is to only move a multiaccount, correct? A variation could be a use case where the user does not want to move all accounts, but only a high value account they already have in their multiaccount, e.g. m/44'/60'/0'/0'/1 only) to Keycard. I suspect we'd have no root to derive the chat key in this case. |
sure |
@hesterbruikman the designs looks good to me, the only thing is that if you want to keep the user data, you will need to ask them for their current password, otherwise we won't be able to migrate the data. @rasom correct me if I am wrong |
@cammellos sure, we would need to have an old password in order to decrypt an existing database |
In theory there are 4 cases where the seed entered by the user is already in use on the phone
'1.' and '2.' are tackled above. For 3. and 4. we should define what we do. I think 3. and 4. corresponds to cases where the user
@hesterbruikman wdyt ? |
A case I think should be included is:
I'll make some more edits and set up a call to discuss |
I won't attend today's meeting as I am off,
Of course this might be worked together/released together as it might not be very palatable to the user to having to reset their data, but they are two distinct features imo. The rest of the cases we can handle in separate issues/tasks. |
@hesterbruikman are the designs still WIP for this or they have been finalized? As discussed previously, we can start by implementing the flow that just migrates the keys from phone to keycard (no other case), but not the data (so no user password is required), and implement then the flow which also migrates the data in a separate issue. Let me know if that's ready so I can polish this up and put it in the next column. |
Going through the designs a bit more to detail and separate the Reset flow and make it inaccessible. In the current design you can end up in that flow, while I'm not sure about the behavior yet. I'm looking at how to keep it out of scope. As a user
|
I checked the flows and I find it super complete, great work @hesterbruikman As per keycard, I think this means in terms of mapping keycard feature vs the designs (I am listing this with what I consider their priority regarding keycard roadmap)
|
Latest designs on Figma TODO's
|
Design for first iteration is ready cc @guylouis @cammellos : Changes
|
Closing this one since the bulk of it have been closed
We leave open the following issues
|
Goal
We want a normal status user (on mobile) that has a multiaccount setup on his phone, and that purchases a brand new keycard, to be able to migrate this multiaccount to the keycard
Problem
This feature is not offered now. So the only thing the user can currently do his
... and he gets a error message because this seed is already used by the current multiaccount
Solution
What is for sure:
The following need to be decided.
- logged into the multiaccount in the profile section
- or in the list of multiaccounts
- user chose a multiaccount
- he's been prompted about what he's going to do (move his keys to the keycard) and what he needs (a keycard with no secret stored)
- (enter his password again ?)
- asked to enter his seed again
- taken through keycard onboarding (he will get a PIN, PUK, Pairing code if the card is new)
The text was updated successfully, but these errors were encountered: