Can't swap some tokens on Uniswap due to json: cannot unmarshal number into Go struct field ... when confirming amount of tokens on your account

[churik]

Bug Report

Problem

To swap tokens on Uniswap you need to confirm amount by signing a message.
When signing got an error
json: cannot unmarshal number into Go struct field TypedDataDomain.domain.chainId of type *math.HexOrDecimal256
It happens only to tokens, which require signing of json (i.e. UNI, DAI)

Maybe related to #11742 (not sure)

Expected behavior

can swap tokens

Actual behavior

Reproduction

1. Open Status (restore multiaccounts with some assets, in my case it was UNI)
2. Connect wallet
3. Try to swap UNI to ETH

Additional Information

• Status version: nightly 03/08/2020
• Operating System: Android, iOS
• Logs: status_logs.zip

[bitgamma]

seems to be a regression in our fork of go-ethereum, probably because when upgrading our fork of go-ethereum this commit status-im/go-ethereum@1d0a734 hasn't been applied

@cammellos is it OK to re-apply it by branching off v1.10.4-status.1 or was there a specific reason why this wasn't merged?

[cammellos]

sorry, my bad, I must have missed it, please re apply it (or I can do that tomorrow). Thank you

…

On Tue, 3 Aug 2021, 15:15 Michele Balistreri, ***@***.***> wrote: seems to be a regression in our fork of status-go, probably because when upgrading our fork of go-ethereum this commit status-im/go-ethereum@ 1d0a734 <status-im/go-ethereum@1d0a734> hasn't been applied @cammellos <https://github.com/cammellos> is it OK to re-apply it by branching off v1.10.4-status.1 or was there a specific reason why this wasn't merged? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12413 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHYJMCT2VY7QIUO54K32MLT272WPANCNFSM5BO4NIMQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[bitgamma]

Ok will do