Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronise currency setting #13190

Closed
Samyoul opened this issue Mar 22, 2022 · 0 comments · Fixed by #13243 or status-im/status-go#2614
Closed

Synchronise currency setting #13190

Samyoul opened this issue Mar 22, 2022 · 0 comments · Fixed by #13243 or status-im/status-go#2614
Assignees
Labels
feature feature requests syncing Syncing or pairing

Comments

@Samyoul
Copy link
Member

Samyoul commented Mar 22, 2022

Implement functionality that handles the syncing of the currency setting.

Background

In status-go syncing of settings has been implemented, and additional setting sync should be a relatively straightforward process. The syncing of the currency setting has been implemented from the status-go side.

See status-im/status-go#2478 and #13053

However there is additional functionality that needs to be implemented on the status-react side to make currency work correctly.

See the QA report here ISSUE 6: Error on the synced device when changing currency

status-go Implementation

Currently the currency setting has its sync functionality disabled:

Currency = SettingField{
	reactFieldName: "currency",
	dBColumnName:   "currency",
	// TODO resolve issue 6 https://github.com/status-im/status-react/pull/13053#issuecomment-1065179963
	syncProtobufFactory: &SyncProtobufFactory{
		inactive:          true, // Remove after issue is resolved
		fromInterface:     currencyProtobufFactory,
		fromStruct:        currencyProtobufFactoryStruct,
		valueFromProtobuf: StringFromSyncProtobuf,
		protobufType:      protobuf.SyncSetting_CURRENCY,
	},
}

To reactivate the currency functionality in status-go simply remove the inactive field from the SyncProtobufFactory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests syncing Syncing or pairing
Projects
None yet
3 participants