Enable currency settings and installed sticker synchronisation #2614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @audriu, and thank you so much for making your first pull request in status-go! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2 |
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (128)
|
audriu
force-pushed
the
enable-currency-settings
branch
from
41d41c4 to
32dd3f4
Compare
audriu
changed the title
Samyoul
approved these changes
Apr 14, 2022
audriu
force-pushed
the
enable-currency-settings
branch
2 times, most recently
from
633603b to
8f8ada6
Compare
audriu
force-pushed
the
enable-currency-settings
branch
14 times, most recently
from
cb56737 to
db13e11
Compare
audriu
force-pushed
the
enable-currency-settings
branch
5 times, most recently
from
159d981 to
43382dd
Compare
audriu
force-pushed
the
enable-currency-settings
branch
11 times, most recently
from
b4e9960 to
bc4405a
Compare
audriu
changed the title
audriu
force-pushed
the
enable-currency-settings
branch
2 times, most recently
from
0f4f0f0 to
c8d59c0
Compare
|
I can reproduce the linting issue locally on your branch, but not on |
|
Looks like a normal linting issue to me, that can be fixed with diff --git a/protocol/messenger_sync_settings.go b/protocol/messenger_sync_settings.go
index 224a826c9..472e8be05 100644
--- a/protocol/messenger_sync_settings.go
+++ b/protocol/messenger_sync_settings.go
@@ -3,8 +3,8 @@ package protocol
import (
"context"
- "go.uber.org/zap"
"encoding/json"
+ "go.uber.org/zap"
"github.com/status-im/status-go/multiaccounts/errors"
"github.com/status-im/status-go/multiaccounts/settings" |
audriu
force-pushed
the
enable-currency-settings
branch
8 times, most recently
from
6b57870 to
6e9aaa5
Compare
audriu
force-pushed
the
enable-currency-settings
branch
from
6e9aaa5 to
8a9708d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes status-im/status-mobile#12889
Closes status-im/status-mobile#13190
Uncomment currency synchronization and sticker pack synchronization.
it is part of the work for this PR: status-im/status-mobile#13190