-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(0.69.10) Android 10 Devices crash with java.lang.RuntimeException: Could not invoke WebSocketModule.connect
#16182
Comments
part of our error is similar to this age old issue : #10770
|
This error seems to not be reproducible for me locally. just a thought : Maybe if this still persists on E2E we can consider upgrading either Android API Level from 29 to 31 or try with different CPU architecture like arm64 (which are a lot faster at everything). cc: @cammellos @jakubgs |
Hi @siddarthkay, |
Hey @siddarthkay, still can reproduce on the real Android 10 device - Huawei P40 lite video_2023-06-08_11-15-15.mp4 |
@siddarthkay it turned out that it is reproducible not only on Android 10. I have just cought the crash on my physical Android 12, Samsung Galaxy A52. |
Thanks @pavloburykh @yevh-berdnyk @KassUA @qoqobolo ! Okay then it seems like its easily reproducible on a lot of your real devices and its not consistent, some say 1 in 5 times and 1 in 3 times. |
Once again looking at the stack trace above it seems like the error is thrown by the And most likely the root cause is this guy right here : https://square.github.io/okhttp/changelogs/changelog_4x/#version-4100 -> this link does mention a fix for Android 10 which makes it a bit suspicious :) |
Finally managed to get my hands on an android 10 device and i can reproduce this error on first try. |
The crash originates here : The crash happens mostly the 1st time the app is installed and then it never happens. The error is most likely thrown here : |
I think I fixed this issue by making sure our OkHttp Version matches React Native's OkHttp Version. Running E2E will tell if it worked or not 🤞🏻 |
E2E still brutally fails : 0% tests passed :
I'll try recreating it on my Android 10 device again 🥲 |
@siddarthkay hello! I was not able to reproduce "Could not invoke WebSocketModule.connect" crash on my Android 12, Samsung Galaxy A52. But currently I am facing another crash which appears during generating keys. After app reopening it is possible to login newly created account. See details below. telegram-cloud-document-2-5202210366263670185.mp4The same issue happens to e2e tests which causes failing. Here is logcat from recent e2e session |
Although I also see that some e2e are still failing with "Could not invoke WebSocketModule.connect" crash. See example below: |
yes, I saw that too, and this is my primary worry for now :) |
@pavloburykh : the error after the keys seem to be a new one and I will try to tackle that one in a separate github issue |
Hi @siddarthkay, just checked on my Huawei P40 Lite, Android 10, and for me it's the same as for @pavloburykh in the comment On the first try I got this error ![]() |
Hi @qoqobolo and @pavloburykh : Thanks for testing, I'll focus on fixing that bug then, meanwhile what are your thoughts on this bug :) |
"Could not invoke WebSocketModule.connect" is still blocker for our e2e tests. Let's ask @yevh-berdnyk what she thinks about that and if there any workaround to prevent e2e from failure in case of this crash. |
@pavloburykh : I fixed the issue E2E result : #16016 (comment) Can you check once? |
Thanx @siddarthkay I will look at it tomorrow |
@siddarthkay I am re-running e2e. Will see the results. |
@siddarthkay so far, most of the failed e2e are known ones and not related to the PR. Crashes have not been caught neither by e2e nor by my physical device. @VladimrLitvinenko will proceed with testing the PR as he has been kinda blocked from proper testing because of crashes. He will provide an update in PR comments as soon as he finishes. Thank you! |
Fixed with bumping okhttp-tls in - implementation "com.squareup.okhttp3:okhttp-tls:4.9.1"
+ implementation "com.squareup.okhttp3:okhttp-tls:4.9.2" Reason : to match our okhttp lib with what react native uses, since we override the httpclient |
Bug Report
Android devices API Level 29 with x86_64 CPU Architecture (Android 10) in E2E pipeline have been failing with
java.lang.RuntimeException: Could not invoke WebSocketModule.connect
Stack Trace here : https://github.com/status-im/status-mobile/files/11651191/reactupgrade.log
Problem
Relevant part of stack trace is below :
Expected behaviour
Don't crash :)
Actual behaviour
crash :(
Additional Information
reported here : #16016 (comment)
The text was updated successfully, but these errors were encountered: