Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply design for new menu and screens for desktop "+" button #4434

Closed
churik opened this issue May 24, 2018 · 15 comments
Closed

Apply design for new menu and screens for desktop "+" button #4434

churik opened this issue May 24, 2018 · 15 comments
Assignees
Labels
feature feature requests

Comments

@churik
Copy link
Member

churik commented May 24, 2018

User Story

As a user, I want to see a list of selected topics and be able to add the new topic in one screen.

Description

Type: Feature

Summary: public chat in mobile app allows users to see selected channels for quick joining and possibility to create the new channel if there is no useful in list. Users will expect something similar in Desktop as well.
Separate windows should be added for "New Chat" screen and for "Join a public chat" screen

Expected behavior

separate screens for "Start new Chat" (described in #4281) and "Join to public chat."
In mobile:
pub_l

Actual behavior

new

Reproduction

  • Open Status
  • Log in
  • Click on +

Solution

  • Menu with new chat options >> zpl.io/bLwR9WJ

captura de pantalla 2018-09-14 a la s 1 52 20 p m

  • New 1:1 chat screen >> Starts here zpl.io/a7ynPBE (navigate left & right on Zeplin to see diff cases)

captura de pantalla 2018-09-14 a la s 1 52 37 p m

  • New public chat screen >> Starts here zpl.io/aBE71Xe (navigate left & right on Zeplin to see diff cases)

captura de pantalla 2018-09-14 a la s 1 53 13 p m

@churik churik added the feature feature requests label May 24, 2018
@EugeOrtiz
Copy link

EugeOrtiz commented Jun 7, 2018

Designs for this can be found here (Zeplin):

  • zpl.io/aBE71Xe
  • zpl.io/aBElz8L

@churik
Copy link
Member Author

churik commented Jun 11, 2018

@EugeOrtiz all public chats in the list should be clickable and change color on hover;
Can you please display it on screen as well?

@EugeOrtiz
Copy link

Yes, here: zpl.io/a3vp03x

@churik churik changed the title Implement separate screen for New public chat (creating or joining) Implement separate screen for New public and 1-1 chat (creating or joining) Jul 2, 2018
@churik
Copy link
Member Author

churik commented Jul 2, 2018

Blocked by status-im/react-native-desktop-qt#256

@churik churik removed the blocked label Jul 10, 2018
@churik churik closed this as completed Jul 10, 2018
@churik churik reopened this Jul 10, 2018
@churik churik added the blocked label Jul 10, 2018
@vkjr
Copy link
Contributor

vkjr commented Jul 26, 2018

status-im/react-native-desktop-qt#256 fixed now, so this probably can be unblocked.

@churik churik removed the blocked label Jul 26, 2018
@EugeOrtiz
Copy link

EugeOrtiz commented Jul 26, 2018

@churik I can still see this issue in the latest build. Is it really done?

@churik
Copy link
Member Author

churik commented Jul 27, 2018

@EugeOrtiz It is not done, it is unblocked for future development by fixing RN-related error.

@EugeOrtiz
Copy link

EugeOrtiz commented Sep 13, 2018

This is creating a bigger UX issue. The more I use the app, the more contacts on the list I have and the public chat area gets pushed down and disappears at the bottom:

captura de pantalla 2018-09-13 a la s 10 15 26 a m

@chadyj @churik I think we should move this to the TO-DO list soon.

@chadyj
Copy link
Contributor

chadyj commented Sep 14, 2018

@EugeOrtiz I lost track of the different Zeplin versions. What is the fix for this issue?

@EugeOrtiz
Copy link

EugeOrtiz commented Sep 14, 2018

There is only one Zepplin project for desktop >> zpl.io/aXGDvmE

Specifics about this issue:

  • Menu with new chat options >> zpl.io/bLwR9WJ

captura de pantalla 2018-09-14 a la s 1 52 20 p m

  • New 1:1 chat screen >> Starts here zpl.io/a7ynPBE (navigate left & right on Zeplin to see diff cases)

captura de pantalla 2018-09-14 a la s 1 52 37 p m

  • New public chat screen >> Starts here zpl.io/aBE71Xe (navigate left & right on Zeplin to see diff cases)

captura de pantalla 2018-09-14 a la s 1 53 13 p m

@chadyj chadyj changed the title Implement separate screen for New public and 1-1 chat (creating or joining) New menu and screens for desktop "+" button Nov 30, 2018
@churik churik changed the title New menu and screens for desktop "+" button Apply design for new menu and screens for desktop "+" button Dec 3, 2018
@chadyj
Copy link
Contributor

chadyj commented Dec 3, 2018

Done in #6974

@chadyj chadyj closed this as completed Dec 3, 2018
@churik
Copy link
Member Author

churik commented Dec 3, 2018

It is not done actually - I changed title to Apply design, because the feature is currently implemented without design.
All designs are attached to this issue.
So I'll reopen it if you don't mind

@churik churik reopened this Dec 3, 2018
@EugeOrtiz
Copy link

Moved designs to Figma:

@ghost
Copy link

ghost commented Mar 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@ghost ghost added the stale label Mar 4, 2019
@ghost
Copy link

ghost commented Mar 11, 2019

This issue has been automatically closed. Please re-open if this issue is important to you.

@ghost ghost closed this as completed Mar 11, 2019
@churik churik removed the stale label Mar 12, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests
Projects
None yet
Development

No branches or pull requests

5 participants