Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop popup #6974

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Desktop popup #6974

merged 1 commit into from
Dec 3, 2018

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer commented Dec 1, 2018 •
edited by churik
Loading

Contribute to #4434 (only functionality without design)

Introduced popup for "+" menu and 3 new screens (1-1, public, group chat)

image

This PR doesn't introduce new design or new functionality for group chats

@flexsurfer flexsurfer self-assigned this Dec 1, 2018
@ghost
Copy link

ghost commented Dec 1, 2018 •
edited by flexsurfer
Loading

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-comment-bot
Copy link

✅ #1 CI BUILD SUCCESSFUL in 23 min and counting (cb8d5a1)
Android(e2e) iOS MacOS AppImage Windows

@chadyj
Copy link
Contributor

chadyj commented Dec 1, 2018

Holy moly that is fantastic! Makes desktop feel 500% less janky!
I tested on Mac and it worked like a treat :)

vitvly
vitvly approved these changes Dec 2, 2018
View reviewed changes
Copy link
Contributor

@vitvly vitvly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! :)

@churik
Copy link
Member

churik commented Dec 3, 2018

Tested on Windows 10 Home, Linux Ubuntu 18.04, Mac Os Mojave

rcullito
rcullito approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@rcullito rcullito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@flexsurfer
desktop popup
22167db 
Signed-off-by: Andrey Shovkoplyas <[email protected]>
@flexsurfer flexsurfer force-pushed the feature/desktop-popup branch from cb8d5a1 to 22167db Compare December 3, 2018 13:54
@flexsurfer flexsurfer merged commit 22167db into develop Dec 3, 2018
@chadyj
Copy link
Contributor

chadyj commented Dec 3, 2018

🍻

@chadyj chadyj mentioned this pull request Dec 3, 2018
Closed
@status-comment-bot
Copy link

✅ #2 CI BUILD SUCCESSFUL in 22 min and counting (22167db)
Android(e2e) iOS MacOS AppImage Windows

@rasom rasom deleted the feature/desktop-popup branch January 11, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcullito rcullito rcullito approved these changes

@vitvly vitvly vitvly approved these changes

@yenda yenda yenda approved these changes

@vkjr vkjr vkjr approved these changes

@chadyj chadyj Awaiting requested review from chadyj

Assignees

@flexsurfer flexsurfer

Labels
Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@flexsurfer @status-comment-bot @chadyj @churik @rcullito @vitvly @yenda @vkjr