Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temporary fix for app crash if chat has long ens names #10022

Merged
merged 1 commit into from
Feb 11, 2020
Merged

temporary fix for app crash if chat has long ens names #10022

merged 1 commit into from
Feb 11, 2020

Conversation

flexsurfer
Copy link
Member

temporary fix for app crash if chat has long ens names

@flexsurfer flexsurfer requested review from vitvly and yenda February 11, 2020 07:16
@flexsurfer flexsurfer requested a review from a team as a code owner February 11, 2020 07:16
@flexsurfer flexsurfer self-assigned this Feb 11, 2020
@auto-assign auto-assign bot removed the request for review from a team February 11, 2020 07:16
@ghost
Copy link

ghost commented Feb 11, 2020

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@flexsurfer flexsurfer changed the title temporary fix for slow chats with long ens names temporary fix for app crash if chat has long ens names Feb 11, 2020
@cammellos
Copy link
Contributor

What works slow here? have you checked the performance of stateofus/username?

(defn username [name]
  (when (and name (string/ends-with? name domain))
    (first (string/split name "."))))

If not I would first remove that, and try the ellipsis (as I understand that's preferrable if performance are ok) #10021 . If performance are acceptable then the issue is in username function, which looks fairly inefficient.

Split is not lazy, so it will go through the whole string regardless, if we really wants to keep exactly the same behavior we can use either loop/recur or reduce/reduced, which both short circuit at the first .. Otherwise if we are not concerned about names such as foo.bar.stateofus.eth we an just take a substring (subs name 0 (- (count name) state-of-us-length)) which should also be more performant.
ends-with? is likely performant enough, but worth checking.

@status-im-auto
Copy link
Member

status-im-auto commented Feb 11, 2020 •
edited
Loading

Jenkins Builds

Click to see older builds (3)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6d66967 #1 2020-02-11 07:26:56 ~10 min ios 📦ipa
✔️ 6d66967 #1 2020-02-11 07:30:20 ~13 min android-e2e 📦apk 📲
✔️ 6d66967 #1 2020-02-11 07:30:20 ~13 min android 📦apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 22c838e #2 2020-02-11 09:40:21 ~9 min ios 📦ipa 📲
✔️ 22c838e #2 2020-02-11 09:42:34 ~11 min android-e2e 📦apk 📲
✔️ 22c838e #2 2020-02-11 09:45:18 ~14 min android 📦apk 📲
✔️ 2b47f20 #3 2020-02-11 10:02:09 ~9 min ios 📦ipa 📲
✔️ 2b47f20 #3 2020-02-11 10:04:59 ~12 min android 📦apk 📲
✔️ 2b47f20 #3 2020-02-11 10:04:59 ~12 min android-e2e 📦apk 📲

@flexsurfer
Copy link
Member Author

@cammellos because it works slow only on android, i believe problem in text component on Android, probably it ellipsize every component and its slow, and still its just a simple and quick fix for v1, we must prepare proper fix in v1.1.

@statustestbot
Copy link

99% of end-end tests have passed

Total executed tests: 97
Failed tests: 1
Passed tests: 96

Failed tests (1)

Click to expand
1. test_open_public_chat_using_deep_link

Device 1: Enter 'https://get.status.im/chat/public/fvjidko' using native keyboard
Device 1: Tap 'Confirm' on native keyboard

Device 1: 'OpenInStatusButton' is not found on the screen

Device sessions

Passed tests (96)

Click to expand
1. test_can_see_all_transactions_in_history
Device sessions

2. test_install_pack_and_send_sticker
Device sessions

3. test_send_message_in_group_chat
Device sessions

4. test_login_with_new_account
Device sessions

5. test_clear_history_of_group_chat_via_group_view
Device sessions

6. test_timestamp_in_chats
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_logcat_recovering_account
Device sessions

9. test_modify_transaction_fee_values
Device sessions

10. test_public_chat_clear_history
Device sessions

11. test_need_help_section
Device sessions

12. test_send_and_open_links
Device sessions

13. test_mobile_data_usage_popup_stop_syncing
Device sessions

14. test_mobile_data_usage_settings
Device sessions

15. test_create_new_group_chat
Device sessions

16. test_sign_typed_message
Device sessions

17. test_user_can_switch_network
Device sessions

18. test_mobile_data_usage_popup_continue_syncing
Device sessions

19. test_home_view
Device sessions

20. test_open_google_com_via_open_dapp
Device sessions

21. test_send_message_to_newly_added_contact
Device sessions

22. test_share_contact_code_and_wallet_address
Device sessions

23. test_make_admin_member_of_group_chat
Device sessions

24. test_connection_is_secure
Device sessions

25. test_add_to_contacts
Device sessions

26. test_add_account_to_multiaccount_instance
Device sessions

27. test_can_open_dapp_from_dapp_store
Device sessions

28. test_refresh_button_browsing_app_webview
Device sessions

29. test_long_press_to_delete_1_1_chat
Device sessions

30. test_can_add_existing_ens
Device sessions

31. test_transaction_wrong_password_wallet
Device sessions

32. test_public_chat_messaging
Device sessions

33. test_unread_messages_counter_public_chat
Device sessions

34. test_delete_one_to_one_chat_via_delete_button
Device sessions

35. test_long_press_to_delete_public_chat
Device sessions

36. test_text_message_1_1_chat
Device sessions

37. test_delete_public_chat_via_delete_button
Device sessions

38. test_can_use_purchased_stickers_on_recovered_account
Device sessions

39. test_open_transaction_on_etherscan
Device sessions

40. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

41. test_contact_profile_view
Device sessions

42. test_logcat_backup_recovery_phrase
Device sessions

43. test_delete_group_chat_via_delete_button
Device sessions

44. test_start_chat_with_ens
Device sessions

45. test_add_and_remove_contact_from_public_chat
Device sessions

46. test_open_blocked_site
Device sessions

47. test_open_chat_by_pasting_public_key
Device sessions

48. test_ens_username_recipient
Device sessions

49. test_token_with_more_than_allowed_decimals
Device sessions

50. test_fetch_more_history_in_empty_chat
Device sessions

51. test_switch_users_and_add_new_account
Device sessions

52. test_copy_contact_code_and_wallet_address
Device sessions

53. test_send_transaction_from_daap
Device sessions

54. test_send_two_transactions_one_after_another_in_dapp
Device sessions

55. test_message_marked_as_sent_in_1_1_chat
Device sessions

56. test_long_press_delete_clear_all_dapps
Device sessions

57. test_copy_and_paste_messages
Device sessions

58. test_deploy_contract_from_daap
Device sessions

59. test_back_forward_buttons_browsing_website
Device sessions

60. test_password_in_logcat_creating_account
Device sessions

61. test_add_custom_token
Device sessions

62. test_sign_message_from_daap
Device sessions

63. test_group_chat_system_messages
Device sessions

64. test_dapps_permissions
Device sessions

65. test_request_public_key_status_test_daap
Device sessions

66. test_logcat_send_transaction_from_wallet
Device sessions

67. test_log_level_and_fleet
Device sessions

68. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

69. test_recover_account_from_new_user_seedphrase
Device sessions

70. test_user_can_complete_tx_to_dapp_when_onboarding_via_dapp_completed
Device sessions

71. test_send_two_transactions_in_batch_in_dapp
Device sessions

72. test_ens_in_public_and_1_1_chats
Device sessions

73. test_block_user_from_public_chat
Device sessions

74. test_fetching_balance_after_offline
Device sessions

75. test_logcat_sign_message_from_daap
Device sessions

76. test_offline_status
Device sessions

77. test_wallet_set_up
Device sessions

78. test_manage_assets
Device sessions

79. test_add_new_group_chat_member
Device sessions

80. test_offline_messaging_1_1_chat
Device sessions

81. test_decline_invitation_to_group_chat
Device sessions

82. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

83. test_send_token_with_7_decimals
Device sessions

84. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

85. test_pass_phrase_validation
Device sessions

86. test_send_emoji
Device sessions

87. test_filters_from_daap
Device sessions

88. test_redirect_to_public_chat_tapping_tag_message
Device sessions

89. test_pair_devices_sync_one_to_one_contacts
Device sessions

90. test_logcat_send_transaction_from_daap
Device sessions

91. test_remove_member_from_group_chat
Device sessions

92. test_send_eth_from_wallet_to_address
Device sessions

93. test_send_stt_from_wallet
Device sessions

94. test_messaging_in_different_networks
Device sessions

95. test_collectible_from_wallet_opens_in_browser_view
Device sessions

96. test_insufficient_funds_wallet_positive_balance
Device sessions

@Serhy
Copy link
Contributor

Serhy commented Feb 11, 2020

App doesn't crash for me on Samsung J7 (Android 8.1) and Galaxy Note 4 (Android 6.0.1) in status chat with loong ENS (fetched messages and scrolled up to 7th of February morning time history).
iOS is OK too (but I had no problems with release build there as well)

@flexsurfer
Copy link
Member Author

@Serhy try to join #status-chinese and fetch history for 3-4days

@flexsurfer
Copy link
Member Author

increased length up to 80

@Serhy
Copy link
Contributor

Serhy commented Feb 11, 2020

@flexsurfer with 40 char-long-ens build #status-chunese works even better for me for the last 5 days than #status (messages loads quicker, less chat-message-dancing behavior)

@flexsurfer
Copy link
Member Author

@Serhy and what about #status-chunese in latest nightly or RC ?

@flexsurfer
Copy link
Member Author

chat still pretty fast with 80 so lets keep 80

@flexsurfer flexsurfer force-pushed the bug/fix-app-crash-with-long-ens-name branch from 22c838e to 2b47f20 Compare February 11, 2020 09:52
@Serhy
Copy link
Contributor

Serhy commented Feb 11, 2020

In RC, can't fetch and scroll to the top of 4 days history in #status-chinese. I gave up after 5 appearing Status isn't responding pop-ups -> tap Wait

@flexsurfer flexsurfer force-pushed the bug/fix-app-crash-with-long-ens-name branch from 2b47f20 to c1eb986 Compare February 11, 2020 10:00
@flexsurfer flexsurfer merged commit c1eb986 into develop Feb 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the bug/fix-app-crash-with-long-ens-name branch February 11, 2020 10:00
@weekly-digest weekly-digest bot mentioned this pull request Feb 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammellos cammellos cammellos approved these changes

@vitvly vitvly Awaiting requested review from vitvly

@yenda yenda Awaiting requested review from yenda

Assignees
No one assigned
Labels
Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flexsurfer @cammellos @status-im-auto @statustestbot @Serhy