Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #10052 make finding the public key easier in profile #10207

Merged
merged 1 commit into from
Apr 16, 2020
Merged

fix #10052 make finding the public key easier in profile #10207

merged 1 commit into from
Apr 16, 2020

Conversation

yenda
Copy link
Contributor

@yenda yenda commented Mar 25, 2020 •
edited by StatusWrike
Loading

Ready:

  • confirmation that having the same effect in other users profile is desirablec: confirmed and done
  • figuring out what to do about the random names being gone: random name shown for user with ens name, public key for others
  • waiting for android icons: thanks @flexsurfer

After @jakubgs review:

@ghost
Copy link

ghost commented Mar 25, 2020

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@yenda yenda self-assigned this Mar 25, 2020
@status-im-auto
Copy link
Member

status-im-auto commented Mar 25, 2020 •
edited
Loading

Jenkins Builds

Click to see older builds (16)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 8c8286f #1 2020-03-25 00:40:20 ~31 sec ios 📄log
✔️ 8c8286f #1 2020-03-25 00:55:34 ~15 min android-e2e 📦apk 📲
✔️ 8c8286f #1 2020-03-25 00:55:37 ~15 min android 📦apk 📲
❌ c152362 #2 2020-03-25 10:18:45 ~2 min ios 📄log
❌ c152362 #2 2020-03-25 10:19:47 ~3 min android 📄log
❌ c152362 #2 2020-03-25 10:20:51 ~4 min android-e2e 📄log
✔️ c8c7684 #3 2020-03-25 10:29:53 ~8 min ios 📦ipa 📲
✔️ c8c7684 #3 2020-03-25 10:35:07 ~14 min android 📦apk 📲
✔️ c8c7684 #3 2020-03-25 10:36:20 ~15 min android-e2e 📦apk 📲
✔️ d56cdde #4 2020-03-25 23:34:22 ~8 min ios 📦ipa 📲
✔️ 28ac1c5 #5 2020-03-25 23:47:28 ~8 min ios 📦ipa 📲
✔️ 28ac1c5 #5 2020-03-25 23:52:59 ~14 min android-e2e 📦apk 📲
✔️ 28ac1c5 #5 2020-03-25 23:53:08 ~14 min android 📦apk 📲
✔️ 457a65a #6 2020-03-30 13:52:02 ~10 min android-e2e 📦apk 📲
✔️ 457a65a #6 2020-03-30 13:52:30 ~10 min ios 📦ipa 📲
✔️ 457a65a #6 2020-03-30 13:55:24 ~13 min android 📦apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 900e346 #7 2020-04-14 19:42:55 ~13 min ios 📦ipa 📲
✔️ 900e346 #7 2020-04-14 19:44:14 ~15 min android-e2e 📦apk 📲
✔️ 900e346 #7 2020-04-14 19:44:20 ~15 min android 📦apk 📲
✔️ 8f44de7 #8 2020-04-15 23:17:55 ~9 min ios 📦ipa 📲
✔️ 8f44de7 #8 2020-04-15 23:22:52 ~14 min android-e2e 📦apk 📲
✔️ 8f44de7 #8 2020-04-15 23:22:59 ~14 min android 📦apk 📲

@errorists
Copy link
Contributor

iOS build is sad so I didn't test yet.

confirmation that having the same effect in other users profile is desirable

absolutely, yes. sorry for not making it clear in my comment

figuring out what to do about the random names being gone

so this is a temporary quick fix anyway for 1.2 while I'm figuring out how to make multiple chat IDs work in the UI, wdyt about this

if random name -> disclose chat key
else -> disclose random name

it's still an improvement that might be just enough until we have a more thorough fix in place

Screenshot 2020-03-25 at 09 14 59

waiting for android icons

Andrey kindly provided those in chat-ui discord. if it's not too much to ask, it would be cool to replace all instances of share on Android to use the platform specific icon like in accounts, browser, invite friends.

@churik churik mentioned this pull request Mar 25, 2020
Closed
20 tasks
@yenda yenda force-pushed the fix/10052 branch 2 times, most recently from c152362 to c8c7684 Compare March 25, 2020 10:20
@yenda yenda marked this pull request as ready for review March 25, 2020 10:48
@yenda yenda requested a review from a team as a code owner March 25, 2020 10:48
@yenda yenda requested review from Ferossgp and flexsurfer March 25, 2020 10:50
yenda
yenda commented Mar 25, 2020
View reviewed changes
src/status_im/ui/screens/profile/components/views.cljs Outdated
(defn- profile-header-display
[{:keys [name public-key ens-name] :as contact}
allow-icon-change? include-remove-action?]
[react/touchable-opacity {:on-press #(chat-key-popover public-key ens-name)}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have used [:<> but it looks like we are still using a deadass version of reagent

@jakubgs
Copy link
Member

jakubgs commented Mar 25, 2020

I checked the build and I noticed 2 things when looking at @bridge contact:

  1. The contact "header" doesn't show the share icon
  2. Despite ENS name being bridge.stateofus.eth only chat key is shown

Screenshot:
status_bridge_contact

@yenda
Copy link
Contributor Author

yenda commented Mar 25, 2020

@jakubgs thanks for having a look, @errorists should I add the icon to the user profiles as well and not only the account profile?

@errorists
Copy link
Contributor

@yenda yes please, let's have them consistent

@status-im-auto
Copy link
Member

98% of end-end tests have passed

Total executed tests: 93
Failed tests: 2
Passed tests: 91

Failed tests (2)

Click to expand
1. test_refresh_button_browsing_app_webview

Device 1: Tap on BrowserRefreshPageButton
Device 1: Looking for full text: 'defaultAccount'

Device 1: 'BaseElement' is not found on the screen

Device sessions

2. test_send_two_transactions_in_batch_in_dapp

Device 1: Wait for SignButton
Device 1: Wait for SignButton

Device 1: 'OkButton' is not found on the screen

Device sessions

Passed tests (91)

Click to expand
1. test_delete_chats_via_delete_button
Device sessions

2. test_can_see_all_transactions_in_history
Device sessions

3. test_install_pack_and_send_sticker
Device sessions

4. test_send_message_in_group_chat
Device sessions

5. test_login_with_new_account
Device sessions

6. test_clear_history_of_group_chat_via_group_view
Device sessions

7. test_timestamp_in_chats
Device sessions

8. test_password_in_logcat_sign_in
Device sessions

9. test_logcat_recovering_account
Device sessions

10. test_modify_transaction_fee_values
Device sessions

11. test_public_chat_clear_history (TestRail link is not found)
Device sessions

12. test_need_help_section
Device sessions

13. test_send_and_open_links
Device sessions

14. test_mobile_data_usage_popup_stop_syncing
Device sessions

15. test_mobile_data_usage_settings
Device sessions

16. test_create_new_group_chat
Device sessions

17. test_sign_typed_message
Device sessions

18. test_user_can_switch_network
Device sessions

19. test_mobile_data_usage_popup_continue_syncing
Device sessions

20. test_home_view
Device sessions

21. test_open_google_com_via_open_dapp
Device sessions

22. test_send_message_to_newly_added_contact
Device sessions

23. test_share_contact_code_and_wallet_address
Device sessions

24. test_make_admin_member_of_group_chat
Device sessions

25. test_connection_is_secure
Device sessions

26. test_add_to_contacts
Device sessions

27. test_add_account_to_multiaccount_instance_private_key
Device sessions

28. test_can_add_existing_ens
Device sessions

29. test_transaction_wrong_password_wallet
Device sessions

30. test_public_chat_messaging
Device sessions

31. test_unread_messages_counter_public_chat
Device sessions

32. test_text_message_1_1_chat
Device sessions

33. test_can_use_purchased_stickers_on_recovered_account
Device sessions

34. test_open_transaction_on_etherscan
Device sessions

35. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

36. test_contact_profile_view
Device sessions

37. test_logcat_backup_recovery_phrase
Device sessions

38. test_delete_group_chat_via_delete_button
Device sessions

39. test_start_chat_with_ens
Device sessions

40. test_add_and_remove_contact_from_public_chat
Device sessions

41. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions

42. test_open_blocked_site
Device sessions

43. test_open_chat_by_pasting_public_key
Device sessions

44. test_pair_devices_sync_one_to_one_contacts_public_chat
Device sessions

45. test_ens_username_recipient
Device sessions

46. test_token_with_more_than_allowed_decimals
Device sessions

47. test_fetch_more_history_in_empty_chat
Device sessions

48. test_switch_users_and_add_new_account
Device sessions

49. test_add_account_to_multiaccount_instance_generate_new
Device sessions

50. test_copy_contact_code_and_wallet_address
Device sessions

51. test_send_transaction_from_daap
Device sessions

52. test_send_two_transactions_one_after_another_in_dapp
Device sessions

53. test_message_marked_as_sent_in_1_1_chat
Device sessions

54. test_long_press_delete_clear_all_dapps
Device sessions

55. test_copy_and_paste_messages
Device sessions

56. test_deploy_contract_from_daap
Device sessions

57. test_back_forward_buttons_browsing_website
Device sessions

58. test_password_in_logcat_creating_account
Device sessions

59. test_add_custom_token
Device sessions

60. test_sign_message_from_daap
Device sessions

61. test_group_chat_system_messages
Device sessions

62. test_dapps_permissions
Device sessions

63. test_request_public_key_status_test_daap
Device sessions

64. test_logcat_send_transaction_from_wallet
Device sessions

65. test_long_press_to_delete_chat
Device sessions

66. test_log_level_and_fleet
Device sessions

67. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

68. test_recover_account_from_new_user_seedphrase (TestRail link is not found)
Device sessions

69. test_ens_in_public_and_1_1_chats
Device sessions

70. test_block_user_from_public_chat
Device sessions

71. test_fetching_balance_after_offline
Device sessions

72. test_logcat_sign_message_from_daap
Device sessions

73. test_offline_status
Device sessions

74. test_wallet_set_up
Device sessions

75. test_manage_assets
Device sessions

76. test_add_new_group_chat_member
Device sessions

77. test_offline_messaging_1_1_chat
Device sessions

78. test_decline_invitation_to_group_chat
Device sessions

79. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

80. test_send_token_with_7_decimals
Device sessions

81. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

82. test_pass_phrase_validation
Device sessions

83. test_send_emoji
Device sessions

84. test_filters_from_daap
Device sessions

85. test_redirect_to_public_chat_tapping_tag_message
Device sessions

86. test_logcat_send_transaction_from_daap
Device sessions

87. test_send_eth_from_wallet_to_address
Device sessions

88. test_send_stt_from_wallet
Device sessions

89. test_messaging_in_different_networks
Device sessions

90. test_collectible_from_wallet_opens_in_browser_view
Device sessions

91. test_insufficient_funds_wallet_positive_balance
Device sessions

@yenda
Copy link
Contributor Author

yenda commented Mar 25, 2020

@jakubgs regarding the ens name it doesn't seem to be related to this PR, the ens name is actually there after reopening the app, so I think there is something amiss with ens name validation that should be fixed.

@yenda yenda force-pushed the fix/10052 branch 3 times, most recently from 28ac1c5 to 457a65a Compare March 30, 2020 13:41
@churik
Copy link
Member

churik commented Mar 31, 2020

@yenda
I see 2 issues here.

1) No name is shown in headline when scrolling

photo_2020-03-31 12 59 48 jpeg 2020-03-31 13-00-28

2) On tap on own user picture don't see my ENS name (but I see it if I tap on "Share" icon in the heading)

On tap on "Share" icon in the headline:
photo_2020-03-31 13 05 29

On tap on your profile name or profile picture:

photo_2020-03-31 13 05 32

@churik churik self-assigned this Apr 15, 2020
@churik
Copy link
Member

churik commented Apr 15, 2020 •
edited
Loading

@yenda on build with 900e346 issue 1 is still reproducible (tested on IOS)
photo_2020-04-15 13 49 00

@status-im-auto
Copy link
Member

98% of end-end tests have passed

Total executed tests: 91
Failed tests: 2
Passed tests: 89

Failed tests (2)

Click to expand
1. test_wallet_set_up

Device 1: Looking for an element by text part: 'These three words prove that a transaction is safe.'
Device 1: Looking for an element by text part: 'You should see these words before signing each transaction. If you don't, cancel and sign out.'

'These three words prove that a transaction is safe.' text is not displayed 'You should see these words before signing each transaction. If you don't, cancel and sign out.' text is not displayed 'These three words prove that a transaction is sa

Device sessions

2. test_add_and_remove_contact_from_public_chat

Device 1: Tap on StartNewChatButton
Device 1: Wait for UserNameBelowNewChatButton

'Remove from contacts' is not changed to 'Add to contacts' List of contacts in profile contains removed user "Add to contacts" button is not shown in 1-1 after removing user from contacts List of contacts below "Start new chat" contains re

Device sessions

Passed tests (89)

Click to expand
1. test_request_public_key_status_test_daap
Device sessions

2. test_open_public_chat_using_deep_link
Device sessions

3. test_ens_username_recipient
Device sessions

4. test_offline_status
Device sessions

5. test_open_transaction_on_etherscan
Device sessions

6. test_open_chat_by_pasting_public_key
Device sessions

7. test_back_forward_buttons_browsing_website
Device sessions

8. test_password_in_logcat_creating_account
Device sessions

9. test_can_use_purchased_stickers_on_recovered_account
Device sessions

10. test_modify_transaction_fee_values
Device sessions

11. test_insufficient_funds_wallet_positive_balance
Device sessions

12. test_mobile_data_usage_settings
Device sessions

13. test_open_google_com_via_open_dapp
Device sessions

14. test_logcat_backup_recovery_phrase
Device sessions

15. test_unread_messages_counter_public_chat
Device sessions

16. test_send_two_transactions_one_after_another_in_dapp
Device sessions

17. test_message_marked_as_sent_in_1_1_chat
Device sessions

18. test_user_can_switch_network
Device sessions

19. test_public_chat_clear_history (TestRail link is not found)
Device sessions

20. test_timestamp_in_chats
Device sessions

21. test_delete_chats_via_delete_button
Device sessions

22. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions

23. test_fetch_more_history_in_empty_chat
Device sessions

24. test_mobile_data_usage_popup_continue_syncing
Device sessions

25. test_add_to_contacts
Device sessions

26. test_dapps_permissions
Device sessions

27. test_long_press_delete_clear_all_dapps
Device sessions

28. test_need_help_section
Device sessions

29. test_transaction_wrong_password_wallet
Device sessions

30. test_offline_messaging_1_1_chat
Device sessions

31. test_token_with_more_than_allowed_decimals
Device sessions

32. test_add_account_to_multiaccount_instance_private_key
Device sessions

33. test_text_message_1_1_chat
Device sessions

34. test_install_pack_and_send_sticker
Device sessions

35. test_send_eth_in_1_1_chat
Device sessions

36. test_pair_devices_sync_one_to_one_contacts_public_chat
Device sessions

37. test_send_emoji
Device sessions

38. test_copy_and_paste_messages
Device sessions

39. test_add_account_to_multiaccount_instance_generate_new
Device sessions

40. test_send_eth_from_wallet_to_address
Device sessions

41. test_messaging_in_different_networks
Device sessions

42. test_start_chat_with_ens
Device sessions

43. test_logcat_recovering_account
Device sessions

44. test_offline_add_new_group_chat_member
Device sessions

45. test_connection_is_secure
Device sessions

46. test_send_eth_to_ens
Device sessions

47. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

48. test_long_press_to_delete_chat
Device sessions

49. test_send_transaction_from_daap
Device sessions

50. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

51. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

52. test_open_blocked_site
Device sessions

53. test_refresh_button_browsing_app_webview
Device sessions

54. test_pass_phrase_validation
Device sessions

55. test_send_token_with_7_decimals
Device sessions

56. test_sign_message_from_daap
Device sessions

57. test_deploy_contract_from_daap
Device sessions

58. test_recover_account_from_new_user_seedphrase (TestRail link is not found)
Device sessions

59. test_add_new_keycard_account
Device sessions

60. test_add_custom_token
Device sessions

61. test_decline_transactions_in_1_1_chat
Device sessions

62. test_send_and_open_links
Device sessions

63. test_manage_assets
Device sessions

64. test_share_contact_code_and_wallet_address
Device sessions

65. test_request_and_receive_stt_in_1_1_chat_offline
Device sessions

66. test_redirect_to_public_chat_tapping_tag_message
Device sessions

67. test_block_user_from_public_chat
Device sessions

68. test_ens_in_public_and_1_1_chats
Device sessions

69. test_sign_typed_message
Device sessions

70. test_create_new_group_chat
Device sessions

71. test_password_in_logcat_sign_in
Device sessions

72. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

73. test_send_message_to_newly_added_contact
Device sessions

74. test_logcat_sign_message_from_daap
Device sessions

75. test_mobile_data_usage_popup_stop_syncing
Device sessions

76. test_collectible_from_wallet_opens_in_browser_view
Device sessions

77. test_logcat_send_transaction_from_daap
Device sessions

78. test_contact_profile_view
Device sessions

79. test_switch_users_and_add_new_account
Device sessions

80. test_logcat_send_transaction_from_wallet
Device sessions

81. test_filters_from_daap
Device sessions

82. test_send_stt_from_wallet
Device sessions

83. test_login_with_new_account
Device sessions

84. test_home_view
Device sessions

85. test_log_level_and_fleet
Device sessions

86. test_can_add_existing_ens
Device sessions

87. test_copy_contact_code_and_wallet_address
Device sessions

88. test_fetching_balance_after_offline
Device sessions

89. test_can_see_all_transactions_in_history
Device sessions

@churik
Copy link
Member

churik commented Apr 15, 2020

failed e2e are fixed in #10337 and not related to PR

@yenda
Copy link
Contributor Author

yenda commented Apr 15, 2020

@churik indeed sorry I missed that one, it was caused by the fact that the layout didn't worked with touchable-opacity, so I had to wrap the inner components in a view

@churik
Copy link
Member

churik commented Apr 16, 2020

@errorists would you mind to take a look?

@churik
Copy link
Member

churik commented Apr 16, 2020

@yenda thank you, all fixed, looks good to me!
1 question - why icons are different for IOS and Android, is it intended?
photo_2020-04-16 10 30 15 jpeg 2020-04-16 10-30-32

@errorists
Copy link
Contributor

@churik the different icons are a part of making it more obvious to their respective audience :)

@status-im-auto
Copy link
Member

100% of end-end tests have passed

Total executed tests: 91
Failed tests: 0
Passed tests: 91

Passed tests (91)

Click to expand
1. test_decline_transactions_in_1_1_chat
Device sessions

2. test_delete_chats_via_delete_button
Device sessions

3. test_can_see_all_transactions_in_history
Device sessions

4. test_install_pack_and_send_sticker
Device sessions

5. test_login_with_new_account
Device sessions

6. test_timestamp_in_chats
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_logcat_recovering_account
Device sessions

9. test_modify_transaction_fee_values
Device sessions

10. test_public_chat_clear_history (TestRail link is not found)
Device sessions

11. test_need_help_section
Device sessions

12. test_send_and_open_links
Device sessions

13. test_mobile_data_usage_popup_stop_syncing
Device sessions

14. test_mobile_data_usage_settings
Device sessions

15. test_create_new_group_chat
Device sessions

16. test_sign_typed_message
Device sessions

17. test_user_can_switch_network
Device sessions

18. test_mobile_data_usage_popup_continue_syncing
Device sessions

19. test_home_view
Device sessions

20. test_open_google_com_via_open_dapp
Device sessions

21. test_send_message_to_newly_added_contact
Device sessions

22. test_share_contact_code_and_wallet_address
Device sessions

23. test_connection_is_secure
Device sessions

24. test_add_to_contacts
Device sessions

25. test_add_account_to_multiaccount_instance_private_key
Device sessions

26. test_refresh_button_browsing_app_webview
Device sessions

27. test_can_add_existing_ens
Device sessions

28. test_transaction_wrong_password_wallet
Device sessions

29. test_unread_messages_counter_public_chat
Device sessions

30. test_text_message_1_1_chat
Device sessions

31. test_can_use_purchased_stickers_on_recovered_account
Device sessions

32. test_open_transaction_on_etherscan
Device sessions

33. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

34. test_contact_profile_view
Device sessions

35. test_offline_add_new_group_chat_member
Device sessions

36. test_logcat_backup_recovery_phrase
Device sessions

37. test_start_chat_with_ens
Device sessions

38. test_add_and_remove_contact_from_public_chat
Device sessions

39. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions

40. test_open_blocked_site
Device sessions

41. test_open_chat_by_pasting_public_key
Device sessions

42. test_pair_devices_sync_one_to_one_contacts_public_chat
Device sessions

43. test_ens_username_recipient
Device sessions

44. test_token_with_more_than_allowed_decimals
Device sessions

45. test_fetch_more_history_in_empty_chat
Device sessions

46. test_open_public_chat_using_deep_link
Device sessions

47. test_switch_users_and_add_new_account
Device sessions

48. test_add_account_to_multiaccount_instance_generate_new
Device sessions

49. test_copy_contact_code_and_wallet_address
Device sessions

50. test_send_transaction_from_daap
Device sessions

51. test_send_eth_to_ens
Device sessions

52. test_send_two_transactions_one_after_another_in_dapp
Device sessions

53. test_message_marked_as_sent_in_1_1_chat
Device sessions

54. test_long_press_delete_clear_all_dapps
Device sessions

55. test_copy_and_paste_messages
Device sessions

56. test_deploy_contract_from_daap
Device sessions

57. test_back_forward_buttons_browsing_website
Device sessions

58. test_password_in_logcat_creating_account
Device sessions

59. test_add_custom_token
Device sessions

60. test_sign_message_from_daap
Device sessions

61. test_dapps_permissions
Device sessions

62. test_request_public_key_status_test_daap
Device sessions

63. test_logcat_send_transaction_from_wallet
Device sessions

64. test_long_press_to_delete_chat
Device sessions

65. test_log_level_and_fleet
Device sessions

66. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

67. test_recover_account_from_new_user_seedphrase (TestRail link is not found)
Device sessions

68. test_send_eth_in_1_1_chat
Device sessions

69. test_ens_in_public_and_1_1_chats
Device sessions

70. test_block_user_from_public_chat
Device sessions

71. test_fetching_balance_after_offline
Device sessions

72. test_logcat_sign_message_from_daap
Device sessions

73. test_offline_status
Device sessions

74. test_wallet_set_up
Device sessions

75. test_manage_assets
Device sessions

76. test_offline_messaging_1_1_chat
Device sessions

77. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

78. test_add_new_keycard_account
Device sessions

79. test_send_token_with_7_decimals
Device sessions

80. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

81. test_pass_phrase_validation
Device sessions

82. test_send_emoji
Device sessions

83. test_filters_from_daap
Device sessions

84. test_redirect_to_public_chat_tapping_tag_message
Device sessions

85. test_logcat_send_transaction_from_daap
Device sessions

86. test_send_eth_from_wallet_to_address
Device sessions

87. test_send_stt_from_wallet
Device sessions

88. test_request_and_receive_stt_in_1_1_chat_offline
Device sessions

89. test_messaging_in_different_networks
Device sessions

90. test_collectible_from_wallet_opens_in_browser_view
Device sessions

91. test_insufficient_funds_wallet_positive_balance
Device sessions

@churik
Copy link
Member

churik commented Apr 16, 2020

approved by @errorists

@yenda yenda merged commit 23af624 into develop Apr 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/10052 branch April 16, 2020 11:34
@weekly-digest weekly-digest bot mentioned this pull request Apr 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer flexsurfer approved these changes

@Ferossgp Ferossgp Awaiting requested review from Ferossgp

Assignees

@churik churik

Labels
Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yenda @status-im-auto @errorists @jakubgs @churik @flexsurfer