Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#11003] Optionally use ENS name as author when building Android notifications #11115

Closed
wants to merge 1 commit into from
Closed

[#11003] Optionally use ENS name as author when building Android notifications #11115

wants to merge 1 commit into from

Conversation

jkrueger
Copy link

fixes #11003

Summary

This was an issue where the ENS name was not extracted from a chat message properly. The PR optionally gets the ENS name when present, and uses the 3-random name otherwise.

Review notes

Testing notes

Platforms

  • Android

Areas that maybe impacted

Functional
  • 1-1 chats

Steps to test

  • Open Status
  • As user A on an android device, start 1-1 chat with user B that has no ENS name yet
  • Minimize app
  • Send message from user B to user A
  • 3-random name should be shown in notification on user A's device
  • Register ENS name as user B
  • Send message from user B to user A
  • ENS name should be shown in notification on user A's device

status: wip

@jkrueger jkrueger requested a review from a team as a code owner August 27, 2020 07:46
@ghost
Copy link

ghost commented Aug 27, 2020

Hey @jkrueger, and thank you so much for making your first pull request in status-react! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2

@status-im-auto
Copy link
Member

status-im-auto commented Aug 27, 2020 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f080cc7 #1 2020-08-27 07:55:01 ~8 min android 📦apk 📲
✔️ f080cc7 #1 2020-08-27 07:56:45 ~10 min android-e2e 📦apk 📲
✔️ f080cc7 #1 2020-08-27 08:01:55 ~14 min ios 📦ipa 📲
✔️ fa94702 #2 2020-08-27 11:06:44 ~10 min android-e2e 📦apk 📲
✔️ fa94702 #2 2020-08-27 11:06:59 ~10 min android 📦apk 📲
✔️ fa94702 #2 2020-08-27 11:10:02 ~13 min ios 📦ipa 📲

@flexsurfer
Copy link
Member

thanks @jkrueger , is it still wip ?

@flexsurfer flexsurfer self-requested a review August 27, 2020 08:41
@jkrueger
Copy link
Author

thanks @jkrueger , is it still wip ?

I think it's fine, since it's a fairly simple fix.

flexsurfer
flexsurfer previously approved these changes Aug 27, 2020
View reviewed changes
@status-im-auto
Copy link
Member

98% of end-end tests have passed

Total executed tests: 98
Failed tests: 2
Passed tests: 96

Failed tests (2)

Click to expand
1. test_push_notification_1_1_chat

Device 2: Looking for an element by text part: 'Text push notification'
Device 2: Looking for an element by text part: 'Envious Mistyrose Tarsier'

Device 2: Push notification with text was not received

Device sessions

2. test_fetching_balance_after_offline

Transaction #5, amount is 0.002741313
{'blockNumber': '8573577', 'timeStamp': '1598501639', 'hash': '0xbde21b24a93df31e467284d20c22624dd398b95d12ad449a68c32060652f15ac', 'nonce': '1490', 'blockHash': '0x18663ac49d57eace91d393a97078b60fed365cd0ad585dc9c043e31e30520e16', 'from': '0xc8f8b3376814d0dfe61e4b9eaf7970697c24f6b2', 'to': '0xf184747445c3b85ceb147dfb136067cb93d95f1d', 'contractAddress': '0xc55cf4b03948d7ebc8b9e8bad92643703811d162', 'value': '2741313000000000', 'tokenName': 'Status Test Token', 'tokenSymbol': 'STT', 'tokenDecimal': '18', 'transactionIndex': '1', 'gas': '131542', 'gasPrice': '31000000000', 'gasUsed': '109619', 'cumulativeGasUsed': '174932', 'input': 'deprecated', 'confirmations': '1514'}

Transaction with amount 0.00279294 is not found in list of transactions, address is f184747445c3B85CEb147DfB136067CB93d95F1D

Device sessions

Passed tests (96)

Click to expand
1. test_decline_transactions_in_1_1_chat
Device sessions

2. test_delete_chats_via_delete_button
Device sessions

3. test_can_see_all_transactions_in_history
Device sessions

4. test_install_pack_and_send_sticker
Device sessions

5. test_login_with_new_account
Device sessions

6. test_timestamp_in_chats
Device sessions

7. test_password_in_logcat_sign_in
Device sessions

8. test_logcat_recovering_account
Device sessions

9. test_public_chat_clear_history
Device sessions

10. test_need_help_section
Device sessions

11. test_send_and_open_links
Device sessions

12. test_mobile_data_usage_popup_stop_syncing
Device sessions

13. test_keycard_send_eth_in_1_1_chat
Device sessions

14. test_mobile_data_usage_settings
Device sessions

15. test_create_new_group_chat
Device sessions

16. test_keycard_send_eth_to_ens (TestRail link is not found)
Device sessions

17. test_user_can_switch_network
Device sessions

18. test_mobile_data_usage_popup_continue_syncing
Device sessions

19. test_home_view
Device sessions

20. test_open_google_com_via_open_dapp
Device sessions

21. test_share_contact_code_and_wallet_address
Device sessions

22. test_connection_is_secure
Device sessions

23. test_add_to_contacts
Device sessions

24. test_add_account_to_multiaccount_instance_private_key
Device sessions

25. test_refresh_button_browsing_app_webview
Device sessions

26. test_keycard_send_two_transactions_one_after_another_in_dapp
Device sessions

27. test_can_add_existing_ens
Device sessions

28. test_transaction_wrong_password_wallet
Device sessions

29. test_public_chat_messaging
Device sessions

30. test_unread_messages_counter_public_chat
Device sessions

31. test_keycard_send_eth_from_wallet_to_address
Device sessions

32. test_keycard_fetching_balance_after_offline
Device sessions

33. test_keycard_send_transaction_from_daap
Device sessions

34. test_text_message_1_1_chat
Device sessions

35. test_can_use_purchased_stickers_on_recovered_account
Device sessions

36. test_open_transaction_on_etherscan
Device sessions

37. test_onboarding_screen_when_requesting_tokens_for_recovered_account
Device sessions

38. test_contact_profile_view
Device sessions

39. test_offline_add_new_group_chat_member
Device sessions

40. test_logcat_backup_recovery_phrase
Device sessions

41. test_can_recover_keycard_account_card_pairing
Device sessions

42. test_start_chat_with_ens
Device sessions

43. test_add_and_remove_contact_from_public_chat
Device sessions

44. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions

45. test_open_blocked_site
Device sessions

46. test_open_chat_by_pasting_public_key
Device sessions

47. test_pair_devices_sync_one_to_one_contacts_public_chat
Device sessions

48. test_keycard_sign_message_from_daap
Device sessions

49. test_send_non_english_message_to_newly_added_contact
Device sessions

50. test_ens_username_recipient
Device sessions

51. test_fetch_more_history_in_empty_chat
Device sessions

52. test_open_public_chat_using_deep_link
Device sessions

53. test_switch_users_and_add_new_account
Device sessions

54. test_add_account_to_multiaccount_instance_generate_new
Device sessions

55. test_copy_contact_code_and_wallet_address
Device sessions

56. test_send_transaction_from_daap
Device sessions

57. test_send_two_transactions_one_after_another_in_dapp
Device sessions

58. test_image_in_one_to_one_send_save_reply
Device sessions

59. test_add_new_keycard_account_and_login
Device sessions

60. test_long_press_delete_clear_all_dapps
Device sessions

61. test_copy_and_paste_messages
Device sessions

62. test_back_forward_buttons_browsing_website
Device sessions

63. test_password_in_logcat_creating_account
Device sessions

64. test_sign_message_from_daap
Device sessions

65. test_dapps_permissions
Device sessions

66. test_request_public_key_status_test_daap
Device sessions

67. test_long_press_to_delete_chat
Device sessions

68. test_log_level_and_fleet
Device sessions

69. test_reactions_to_message_in_chats
Device sessions

70. test_add_and_delete_watch_only_account_to_multiaccount_instance
Device sessions

71. test_recover_account_from_new_user_seedphrase
Device sessions

72. test_send_transaction_with_custom_token
Device sessions

73. test_send_eth_in_1_1_chat
Device sessions

74. test_send_two_transactions_in_batch_in_dapp
Device sessions

75. test_ens_in_public_and_1_1_chats
Device sessions

76. test_block_user_from_public_chat
Device sessions

77. test_offline_status
Device sessions

78. test_wallet_set_up
Device sessions

79. test_manage_assets
Device sessions

80. test_offline_messaging_1_1_chat
Device sessions

81. test_account_recovery_with_uppercase_recovery_phrase
Device sessions

82. test_send_token_with_7_decimals
Device sessions

83. test_user_can_see_all_own_assets_after_account_recovering
Device sessions

84. test_pass_phrase_validation
Device sessions

85. test_keycard_can_see_all_transactions_in_history
Device sessions

86. test_keycard_send_two_transactions_in_batch_in_dapp
Device sessions

87. test_send_emoji
Device sessions

88. test_filters_from_daap
Device sessions

89. test_redirect_to_public_chat_tapping_tag_message
Device sessions

90. test_restore_account_from_mnemonic_to_keycard
Device sessions

91. test_send_eth_to_ens_in_chat
Device sessions

92. test_send_eth_from_wallet_to_address
Device sessions

93. test_request_and_receive_stt_in_1_1_chat_offline
Device sessions

94. test_messaging_in_different_networks
Device sessions

95. test_collectible_from_wallet_opens_in_browser_view
Device sessions

96. test_insufficient_funds_wallet_positive_balance
Device sessions

@hesterbruikman
Copy link
Contributor

Hi @jkrueger, did a quick test with the PR build on Samsung Galaxy S10e (Android 10)

Send messages from a Fairphone 2 (Android 7)

  • Create User C on Samsung
  • Create User A on Fairphone - random name
  • Create User B on Fairphone - ENS

Send message from both to user C.

Notifications for user C are not showing random name or ENS name.

Tried if contact status makes a difference.

  • User C adds user A as contact > no random name in notification
  • User A adds user C as contact > no random name in notification

Screenshot_20200827-114330_One UI Home

Another issue, that I think is out of the scope of this PR, is that the notification seems overlaid by the notification for the first message; In this case I send a message from user B first. When sending a message from user A, notification for user C shows the message from user B on top. cc @churik @Serhy

Screenshot_20200827-120756_One UI Home

@jkrueger
Copy link
Author

I’ve tried this in a Genymotion machine, and it did work there. Let me double check

@cammellos
Copy link
Contributor

Another issue is that those ENS names are not going to be verified. So it will display anything that the user sets, but it might not be belonging to the user.
Unfortunately just by looking at ensName on message is not possible to check if it's verified.
To overcome this issue the best solution is to move creation of the notification inside status-go, that has all the information necessary.

@flexsurfer flexsurfer self-requested a review August 27, 2020 10:52
@jkrueger
Copy link
Author

@hesterbruikman I've added an extra test that makes sure that the 3-random name gets displayed if the ens name is present in the message, but empty. I think that may fix your case.

@cammellos Just so I understand this right, before I dig into the status-go code. The notification gets created from data that came from another user's message. What you want is, that whatever ENS name comes in the message gets verified on the receiver's side?

@jkrueger
Copy link
Author

@cammellos I've taken the time to read the go code, so I understand the flow of information better, and where the ENS name comes from, and gets verified. I have a couple of proposals for how to pass this information through to the android notification handler. I wrote some code that could be discussed, that solves the problem, but I feel this reaches fairly deeply into the application logic, in ways that could break things easily. Teo mentioned that you're off work at the moment. It would be good if we could quickly chat next week, and see how we sync this fix with any potential status-go work. I will write a regression test for this bug in status-rect in the mean time, and add it here.

@cammellos
Copy link
Contributor

@jkrueger Thanks for the contribution,
yes the solution is to move things in status-go, that's something that soon either me or @Ferossgp will be addressing, as we are working on issues that rely on the code being in status-go, so we will be taking over if you are ok, but of course you are free to work on it if you wish to do so.
I will close this for now, but you can consider your contribution complete and next step will be a technical interview.
Thanks for handling this!

@cammellos cammellos closed this Aug 31, 2020
@jkrueger
Copy link
Author

@andremedeiros That's fair enough. I'll wait for you, or Teo to get in touch with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer Awaiting requested review from flexsurfer

Assignees
No one assigned
Labels
request-manual-qa
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3-random name is displayed instead of ENS name in mention push notification
5 participants
@jkrueger @status-im-auto @flexsurfer @hesterbruikman @cammellos