Private Profile Photos #11768

Samyoul · 2021-02-18T16:51:36Z

Addressing the issue of status-im/status#56 to disable broadcasting profile images to the network by default.

The react side of status-im/status-go#2151

Using https://github.com/status-im/status-react/pull/11650/files as a template

A new option in the privacy and security settings:

The default the option is "Contact"

Changing option persists

Log out

Log back in

Selection is still there.

status-im-auto · 2021-02-18T17:01:12Z

Jenkins Builds

Click to see older builds (80)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`ce64d2c`	#1	2021-02-18 17:01:12	~9 min	`android-e2e`	📦`apk` 📲
✔️	`ce64d2c`	#1	2021-02-18 17:01:28	~9 min	`android`	📦`apk` 📲
✔️	`ce64d2c`	#1	2021-02-18 17:06:27	~14 min	`ios`	📦`ipa` 📲

✔️	`fa08687`	#2	2021-02-24 14:10:54	~9 min	`android`	📦`apk` 📲
✔️	`fa08687`	#2	2021-02-24 14:13:15	~11 min	`android-e2e`	📦`apk` 📲
✔️	`fa08687`	#2	2021-02-24 14:18:31	~16 min	`ios`	📦`ipa` 📲

❌	`67d9698`	#3	2021-02-25 23:38:38	~14 sec	`ios`	📄`log`
❌	`67d9698`	#3	2021-02-25 23:38:41	~22 sec	`android`	📄`log`
❌	`67d9698`	#3	2021-02-25 23:38:42	~23 sec	`android-e2e`	📄`log`

❌	`25e407c`	#4	2021-02-26 13:21:37	~14 sec	`android`	📄`log`
❌	`25e407c`	#4	2021-02-26 13:21:38	~15 sec	`android-e2e`	📄`log`
❌	`25e407c`	#4	2021-02-26 13:21:42	~14 sec	`ios`	📄`log`

❌	`41c239f`	#5	2021-02-26 15:30:55	~11 sec	`android`	📄`log`
❌	`41c239f`	#5	2021-02-26 15:30:55	~11 sec	`android-e2e`	📄`log`
❌	`41c239f`	#5	2021-02-26 15:30:58	~13 sec	`ios`	📄`log`

❌	`45d150d`	#6	2021-03-01 22:03:42	~14 sec	`android-e2e`	📄`log`
❌	`45d150d`	#6	2021-03-01 22:03:42	~14 sec	`android`	📄`log`
❌	`45d150d`	#6	2021-03-01 22:03:42	~14 sec	`ios`	📄`log`

❌	`902e38b`	#7	2021-03-01 22:06:05	~12 sec	`android`	📄`log`
❌	`902e38b`	#7	2021-03-01 22:06:05	~12 sec	`android-e2e`	📄`log`
❌	`902e38b`	#7	2021-03-01 22:06:06	~13 sec	`ios`	📄`log`

❌	`e52f43b`	#8	2021-03-01 22:13:18	~10 sec	`android-e2e`	📄`log`
❌	`e52f43b`	#8	2021-03-01 22:13:18	~10 sec	`android`	📄`log`
❌	`e52f43b`	#8	2021-03-01 22:13:19	~11 sec	`ios`	📄`log`

✖️	`5756f01`	#9	2021-03-04 16:19:40	~12 min	`android`	📦`apk` 📲
✖️	`5756f01`	#9	2021-03-04 16:19:45	~12 min	`android-e2e`	📦`apk` 📲
✖️	`5756f01`	#9	2021-03-04 16:27:43	~20 min	`ios`	📦`ipa` 📲

✖️	`945affa`	#10	2021-03-04 16:44:23	~14 min	`android`	📦`apk` 📲
✖️	`945affa`	#10	2021-03-04 16:44:52	~15 min	`android-e2e`	📦`apk` 📲
✖️	`945affa`	#10	2021-03-04 16:54:05	~24 min	`ios`	📦`ipa` 📲

✔️	`adee279`	#11	2021-03-04 16:53:45	~14 min	`android-e2e`	📦`apk` 📲
✔️	`adee279`	#11	2021-03-04 16:55:36	~15 min	`android`	📦`apk` 📲
✔️	`adee279`	#11	2021-03-04 16:59:33	~19 min	`ios`	📦`ipa` 📲

✔️	`bd2a7ee`	#12	2021-03-23 15:55:50	~14 min	`android`	📦`apk` 📲
✔️	`bd2a7ee`	#12	2021-03-23 15:56:31	~14 min	`android-e2e`	📦`apk` 📲
✔️	`bd2a7ee`	#12	2021-03-23 16:03:19	~21 min	`ios`	📦`ipa` 📲

✔️	`4420465`	#13	2021-03-24 10:56:07	~12 min	`android-e2e`	📦`apk` 📲
✔️	`4420465`	#13	2021-03-24 10:56:09	~12 min	`android`	📦`apk` 📲
✔️	`4420465`	#14	2021-03-24 12:48:40	~19 min	`ios`	📦`ipa` 📲

✔️	`923f628`	#14	2021-03-31 11:18:43	~13 min	`android-e2e`	📦`apk` 📲
✔️	`923f628`	#14	2021-03-31 11:19:55	~14 min	`android`	📦`apk` 📲
❌	`923f628`	#15	2021-03-31 11:25:12	~20 min	`ios`	📄`log`

✔️	`fee3d45`	#15	2021-03-31 11:19:53	~10 min	`android-e2e`	📦`apk` 📲
✔️	`fee3d45`	#15	2021-03-31 11:20:36	~11 min	`android`	📦`apk` 📲
❌	`fee3d45`	#16	2021-03-31 11:25:26	~16 min	`ios`	📄`log`
✔️	`fee3d45`	#17	2021-03-31 11:52:03	~15 min	`ios`	📦`ipa` 📲

❌	`3ac663e`	#16	2021-04-19 16:12:39	~7 min	`android`	📄`log`
❌	`3ac663e`	#16	2021-04-19 16:13:51	~8 min	`android-e2e`	📄`log`
❌	`3ac663e`	#18	2021-04-19 16:23:15	~17 min	`ios`	📄`log`

✔️	`9195b50`	#17	2021-04-20 10:15:28	~13 min	`android-e2e`	📦`apk` 📲
✔️	`9195b50`	#19	2021-04-20 10:22:40	~20 min	`ios`	📦`ipa` 📲
❌	`9195b50`	#18	2021-04-20 10:36:45	~2 min	`android`	📄`log`
❌	`9195b50`	#19	2021-04-20 10:40:30	~2 min	`android`	📄`log`
✔️	`9195b50`	#20	2021-04-20 10:50:36	~9 min	`android`	📦`apk` 📲

✔️	`c6df65c`	#18	2021-04-27 15:43:18	~15 min	`android-e2e`	📦`apk` 📲
✔️	`c6df65c`	#21	2021-04-27 15:43:19	~15 min	`android`	📦`apk` 📲

✔️	`4ae7382`	#19	2021-04-27 16:03:48	~12 min	`android-e2e`	📦`apk` 📲
✔️	`4ae7382`	#23	2021-04-27 16:19:21	~20 min	`ios`	📦`ipa` 📲
✔️	`4ae7382`	#23	2021-04-28 08:25:33	~16 min	`android`	📦`apk` 📲

❌	`ec8d8a9`	#24	2021-06-07 14:49:13	~3 min	`ios`	📄`log`
❌	`ec8d8a9`	#24	2021-06-07 14:50:04	~4 min	`android`	📄`log`
❌	`ec8d8a9`	#20	2021-06-07 14:51:03	~5 min	`android-e2e`	📄`log`

✖️	`d8bfe09`	#25	2021-08-11 12:01:03	~17 min	`android`	📦`apk` 📲
✖️	`d8bfe09`	#21	2021-08-11 12:02:09	~18 min	`android-e2e`	📦`apk` 📲
✖️	`d8bfe09`	#25	2021-08-11 12:02:26	~18 min	`ios`	📦`ipa` 📲

❌	`1282a45`	#26	2021-08-17 11:43:34	~17 sec	`ios`	📄`log`
❌	`1282a45`	#22	2021-08-17 11:43:35	~20 sec	`android-e2e`	📄`log`
❌	`1282a45`	#26	2021-08-17 11:43:45	~31 sec	`android`	📄`log`

❌	`fb6c4bc`	#23	2021-08-17 12:29:45	~14 sec	`android-e2e`	📄`log`
❌	`fb6c4bc`	#27	2021-08-17 12:29:51	~14 sec	`ios`	📄`log`
❌	`fb6c4bc`	#27	2021-08-17 12:29:58	~26 sec	`android`	📄`log`

✔️	`2d3b5d4`	#24	2021-09-24 22:17:23	~15 min	`android-e2e`	📦`apk` 📲
✔️	`2d3b5d4`	#28	2021-09-24 22:19:38	~17 min	`android`	📦`apk` 📲
✔️	`2d3b5d4`	#28	2021-09-24 22:23:56	~21 min	`ios`	📦`ipa` 📲

✔️	`60438a4`	#25	2021-09-27 10:46:21	~11 min	`android-e2e`	📦`apk` 📲
✔️	`60438a4`	#29	2021-09-27 10:50:12	~15 min	`ios`	📦`ipa` 📲
✔️	`60438a4`	#29	2021-09-27 10:53:49	~18 min	`android`	📦`apk` 📲

✔️	`0601a4c`	#26	2021-09-27 11:35:56	~15 min	`android-e2e`	📦`apk` 📲
✔️	`0601a4c`	#30	2021-09-27 11:36:10	~15 min	`android`	📦`apk` 📲
✔️	`0601a4c`	#30	2021-09-27 11:39:53	~19 min	`ios`	📦`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`398d040`	#27	2021-09-29 08:51:15	~14 min	`android-e2e`	📦`apk` 📲
✔️	`398d040`	#31	2021-09-29 08:52:42	~15 min	`ios`	📦`ipa` 📲
✔️	`398d040`	#31	2021-09-29 08:54:23	~17 min	`android`	📦`apk` 📲

✔️	`fca2f9c`	#28	2021-09-29 15:44:59	~16 min	`android-e2e`	📦`apk` 📲
✔️	`fca2f9c`	#32	2021-09-29 15:44:59	~16 min	`android`	📦`apk` 📲
✔️	`fca2f9c`	#32	2021-09-29 16:01:22	~33 min	`ios`	📦`ipa` 📲

src/status_im/ui/screens/privacy_and_security_settings/views.cljs

Samyoul · 2021-02-26T14:36:06Z

How do I resolve the conflict while at the same time pointing to the branch that gives the functionality I need to use?

cammellos · 2021-02-26T14:39:55Z

How do I resolve the conflict while at the same time pointing to the branch that gives the functionality I need to use?

Rebase your status-go against develop
Push changes to your branch
Rebase your status-react branch to status-react develop
update status-go version to your branch

Samyoul · 2021-03-04T16:15:33Z

I attempted an interactive rebase to clean this PR up but I kept getting noop, and no commits to target. Manually entering the commit hashes didn't work.

In the end I created a new branch cherry-picked my original commits into the new branch and switch the names of the old and new branches. Force pushed.

cammellos · 2021-03-19T07:59:15Z

@Samyoul would you mind rebasing status-go and status-react please?
Ping me once done that I will put it to testing after, thanks!

status-im-auto · 2021-03-31T13:30:17Z

96% of end-end tests have passed

Total executed tests: 80
Failed tests: 3
Passed tests: 77

IDs of failed tests: 6253,3994,6646

Failed tests (3)

Click to expand

1. test_send_eth_in_1_1_chat_transaction_push, id: 6253
Device 1: TimeStampText is 1:08 PM Device 1: Wait for text element TransactionStatus to be equal to Pending `Device 1: 'Confirmed' is not equal to expected 'Pending' in 30 sec` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_create_new_group_chat_messaging_pn_delived, id: 3994
Device 2: ========================================================================= Device 2: Find Button by xpath: `//[contains(@text, "Message from device: 1")]` Device 2: Button by xpath: `//[contains(@text, "Message from device: 1")]` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_set_profile_picture, id: 6646
Device 2: Looking for a message by text: Text message Device 2: Find MemberPhoto by xpath: `//[starts-with(@text,'Text message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='member-photo']` `Device 1: Profile picture was not updated in chat` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (77)

Click to expand

1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
Device sessions Device 1: Steps, video, logs
3. test_send_eth_from_wallet_to_address, id: 5308
Device sessions Device 1: Steps, video, logs
4. test_onboarding_screen_when_requesting_tokens_for_recovered_account, id: 5677
Device sessions Device 1: Steps, video, logs
5. test_keycard_can_see_all_transactions_in_history, id: 6291
Device sessions Device 1: Steps, video, logs
6. test_push_notification_1_1_chat, id: 6283
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
Device sessions Device 1: Steps, video, logs
8. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
Device sessions Device 1: Steps, video, logs
9. test_open_public_chat_using_deep_link, id: 5396
Device sessions Device 1: Steps, video, logs
10. test_offline_add_new_group_chat_member, id: 3998
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
11. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
12. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
Device sessions Device 1: Steps, video, logs
13. test_keycard_create_login_resotore_unlock_same_seed, id: 5689
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
14. test_insufficient_funds_wallet_positive_balance, id: 5412
Device sessions Device 1: Steps, video, logs
15. test_delete_close_all_tabs, id: 5390
Device sessions Device 1: Steps, video, logs
16. test_send_token_with_7_decimals, id: 5350
Device sessions Device 1: Steps, video, logs
17. test_delete_chats_via_delete_button_rejoin, id: 5387
Device sessions Device 1: Steps, video, logs
18. test_send_transaction_set_recipient_options, id: 6328
Device sessions Device 1: Steps, video, logs
19. test_recover_account_from_new_user_seedphrase, id: 6296
Device sessions Device 1: Steps, video, logs
20. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
Device sessions Device 1: Steps, video, logs
21. test_block_user_from_public_chat, id: 5786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
22. test_send_audio_message_with_push_notification_check, id: 6316
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
23. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
Device sessions Device 1: Steps, video, logs
24. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
25. test_keycard_send_eth_from_wallet_to_address, id: 6289
Device sessions Device 1: Steps, video, logs
26. test_request_public_key_status_test_daap, id: 5397
Device sessions Device 1: Steps, video, logs
27. test_sign_message_from_daap, id: 5342
Device sessions Device 1: Steps, video, logs
28. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
Device sessions Device 1: Steps, video, logs
29. test_back_forward_refresh_navigation_history_kept_after_relogin (TestRail link is not found)
Device sessions Device 1: Steps, video, logs
30. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
31. test_redirect_to_public_chat_tapping_tag_message, id: 5675
Device sessions Device 1: Steps, video, logs
32. test_keycard_send_two_transactions_one_after_another_in_dapp, id: 6288
Device sessions Device 1: Steps, video, logs
33. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
34. test_long_press_to_delete_chat, id: 5319
Device sessions Device 1: Steps, video, logs
35. test_copy_and_paste_messages, id: 5317
Device sessions Device 1: Steps, video, logs
36. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
Device sessions Device 1: Steps, video, logs
37. test_unread_messages_counter_public_chat, id: 5360
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
38. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
Device sessions Device 1: Steps, video, logs
39. test_transaction_wrong_password_wallet, id: 5408
Device sessions Device 1: Steps, video, logs
40. test_mobile_data_usage_complex_settings, id: 6228
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
41. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
Device sessions Device 1: Steps, video, logs
42. test_send_two_transactions_one_after_another_in_dapp, id: 5744
Device sessions Device 1: Steps, video, logs
43. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
44. test_fetch_more_history_in_empty_chat, id: 6205
Device sessions Device 1: Steps, video, logs
45. test_install_pack_and_send_sticker, id: 5782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
46. test_keycard_send_two_transactions_in_batch_in_dapp, id: 6287
Device sessions Device 1: Steps, video, logs
47. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
Device sessions Device 1: Steps, video, logs
48. test_keycard_sign_message_from_daap, id: 6251
Device sessions Device 1: Steps, video, logs
49. test_manage_assets, id: 5341
Device sessions Device 1: Steps, video, logs
50. test_send_two_transactions_in_batch_in_dapp, id: 5743
Device sessions Device 1: Steps, video, logs
51. test_browser_managing_bookmarks, id: 6633
Device sessions Device 1: Steps, video, logs
52. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
Device sessions Device 1: Steps, video, logs
53. test_request_stt_from_daap, id: 5309
Device sessions Device 1: Steps, video, logs
54. test_send_emoji, id: 5328
Device sessions Device 1: Steps, video, logs
55. test_can_use_purchased_stickers_on_recovered_account, id: 5783
Device sessions Device 1: Steps, video, logs
56. test_dapps_permissions, id: 5738
Device sessions Device 1: Steps, video, logs
57. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
Device sessions Device 1: Steps, video, logs
58. test_send_eth_to_ens_in_chat, id: 6279
Device sessions Device 1: Steps, video, logs
59. test_share_copy_contact_code_and_wallet_address, id: 5323
Device sessions Device 1: Steps, video, logs
60. test_wallet_set_up, id: 5335
Device sessions Device 1: Steps, video, logs
61. test_send_transaction_with_custom_token, id: 6208
Device sessions Device 1: Steps, video, logs
62. test_home_view, id: 5379
Device sessions Device 1: Steps, video, logs
63. test_can_add_existing_ens, id: 5502
Device sessions Device 1: Steps, video, logs
64. test_logcat_backup_recovery_phrase, id: 5419
Device sessions Device 1: Steps, video, logs
65. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
66. test_collectible_from_wallet, id: 5346
Device sessions Device 1: Steps, video, logs
67. test_public_chat_messaging, id: 5313
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
68. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
69. test_keycard_request_stt_from_daap, id: 6249
Device sessions Device 1: Steps, video, logs
70. test_restore_account_from_mnemonic_to_keycard, id: 6240
Device sessions Device 1: Steps, video, logs
71. test_pass_phrase_validation, id: 5363
Device sessions Device 1: Steps, video, logs
72. test_keycard_send_eth_in_1_1_chat, id: 6293
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
73. test_send_and_open_links_with_previews, id: 5373
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
74. test_reactions_to_message_in_chats, id: 6315
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
75. test_filters_from_daap, id: 5353
Device sessions Device 1: Steps, video, logs
76. test_fetching_balance_after_offline, id: 6237
Device sessions Device 1: Steps, video, logs
77. test_keycard_fetching_balance_after_offline, id: 6290
Device sessions Device 1: Steps, video, logs

churik · 2021-04-15T13:30:16Z

@Samyoul
if PR is ready for manual testing, please resolve conflict and I'll relaunch e2e tests.
Thank you.

flexsurfer · 2021-09-27T10:34:53Z

@churik done

qoqobolo · 2021-09-27T13:44:06Z

@Samyoul @flexsurfer thanks!

ISSUE 4

@Samyoul unfortunately, can't see User's A profile picture on the device of UserB with default settings (See PP from: Contacts, Show your PP to: Contacts) if both users are added to contacts to each other :(

Steps:

UserA sets profile picture
UserA adds UserB to contacts
UserB adds UserA to contacts
UserA starts 1-1 chat with UserB

Expected result: UserB can see PP of UserA
Actual result: UserB does not see PP

status-im-auto · 2021-09-27T16:43:36Z

94% of end-end tests have passed

Total executed tests: 67
Failed tests: 4
Passed tests: 63

IDs of failed tests: 6645,5396,6228,6646

Failed tests (4)

Click to expand

Rerun tests

1. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
Device 1: Tap on found Button Device 1: Find Button by accessibility id: `back-button` Device 1: Button by accessibility id: `back-button` is not found on the screen Device sessions Device 1: Steps, video, logs Failure screenshot
2. test_open_public_chat_using_deep_link, id: 5396
Device 1: Signed in successfully! Device 1: Find Text by accessibility id: `chat-name-text` Device 1: Text by accessibility id: `chat-name-text` is not found on the screen `During handling of the above exception, another exception occurred: E Failed: Device 1: Public chat 'zbgsatw' is not opened` Device sessions Device 1: Steps, video, logs Failure screenshot
3. test_mobile_data_usage_complex_settings, id: 6228
Device 1: Find Button by xpath: `//[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]` Device 1: Find Button by xpath:* `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]` `Chat history was not fetched with mobile data fetching ON` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_set_profile_picture, id: 6646
Device 2: Looking for a message by text: Text message Device 2: Find MemberPhoto by xpath: `//[starts-with(@text,'Text message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='member-photo']` `Device 1: Profile picture was not updated in chat` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (63)

Click to expand

1. test_send_token_with_7_decimals, id: 5350
Device sessions Device 1: Steps, video, logs
2. test_keycard_create_login_restore_unlock_same_seed, id: 5689
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_keycard_send_eth_from_wallet_to_address, id: 6289
Device sessions Device 1: Steps, video, logs
4. test_install_pack_and_send_sticker, id: 5782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_send_audio_message_with_push_notification_check, id: 6316
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
Device sessions Device 1: Steps, video, logs
7. test_long_press_to_delete_chat, id: 5319
Device sessions Device 1: Steps, video, logs
8. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
Device sessions Device 1: Steps, video, logs
9. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_send_and_open_links_with_previews, id: 5373
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_manage_assets, id: 5341
Device sessions Device 1: Steps, video, logs
12. test_public_chat_messaging_emojis_timestamps, id: 5313
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
13. test_send_transaction_set_recipient_options, id: 6328
Device sessions Device 1: Steps, video, logs
14. test_unread_messages_counter_public_chat, id: 5360
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
15. test_logcat_backup_recovery_phrase, id: 5419
Device sessions Device 1: Steps, video, logs
16. test_keycard_send_eth_in_1_1_chat, id: 6293
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
17. test_keycard_request_stt_from_daap, id: 6249
Device sessions Device 1: Steps, video, logs
18. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
19. test_browser_managing_bookmarks, id: 6633
Device sessions Device 1: Steps, video, logs
20. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
Device sessions Device 1: Steps, video, logs
21. test_add_account_to_multiaccount_instance_generate_new, id: 6224
Device sessions Device 1: Steps, video, logs
22. test_send_eth_to_ens_in_chat, id: 6279
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
23. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
Device sessions Device 1: Steps, video, logs
24. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
25. test_can_use_purchased_stickers_on_recovered_account, id: 5783
Device sessions Device 1: Steps, video, logs
26. test_dapps_permissions, id: 5738
Device sessions Device 1: Steps, video, logs
27. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
Device sessions Device 1: Steps, video, logs
28. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
29. test_keycard_can_see_all_transactions_in_history, id: 6291
Device sessions Device 1: Steps, video, logs
30. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
Device sessions Device 1: Steps, video, logs
31. test_request_stt_from_daap, id: 5309
Device sessions Device 1: Steps, video, logs
32. test_send_eth_in_1_1_chat_transaction_push, id: 6253
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
33. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
34. test_delete_close_all_tabs, id: 5390
Device sessions Device 1: Steps, video, logs
35. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
Device sessions Device 1: Steps, video, logs
36. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
37. test_block_user_from_public_chat, id: 5786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
38. test_keycard_sign_message_and_transactions_from_daap, id: 6251
Device sessions Device 1: Steps, video, logs
39. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
Device sessions Device 1: Steps, video, logs
40. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
41. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
42. test_home_view, id: 5379
Device sessions Device 1: Steps, video, logs
43. test_create_new_group_chat_messaging_pn_delivered, id: 3994
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
44. test_reactions_to_message_in_chats, id: 6315
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
45. test_restore_account_from_mnemonic_to_keycard, id: 6240
Device sessions Device 1: Steps, video, logs
46. test_share_copy_contact_code_and_wallet_address, id: 5323
Device sessions Device 1: Steps, video, logs
47. test_delete_chats_via_delete_button_rejoin, id: 5387
Device sessions Device 1: Steps, video, logs
48. test_send_transaction_with_custom_token, id: 6208
Device sessions Device 1: Steps, video, logs
49. test_fetching_balance_after_offline, id: 6237
Device sessions Device 1: Steps, video, logs
50. test_offline_add_new_group_chat_member, id: 3998
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
51. test_copy_and_paste_messages, id: 5317
Device sessions Device 1: Steps, video, logs
52. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
Device sessions Device 1: Steps, video, logs
53. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
Device sessions Device 1: Steps, video, logs
54. test_pass_phrase_validation, id: 5363
Device sessions Device 1: Steps, video, logs
55. test_insufficient_funds_wallet_positive_balance, id: 5412
Device sessions Device 1: Steps, video, logs
56. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
Device sessions Device 1: Steps, video, logs
57. test_wallet_set_up, id: 5335
Device sessions Device 1: Steps, video, logs
58. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
Device sessions Device 1: Steps, video, logs
59. test_can_add_existing_ens_on_mainnet, id: 5502
Device sessions Device 1: Steps, video, logs
60. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
Device sessions Device 1: Steps, video, logs
61. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
62. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
63. test_recover_account_from_new_user_seedphrase, id: 6296
Device sessions Device 1: Steps, video, logs

cammellos · 2021-09-29T09:47:34Z

@qoqobolo would you mind testing again, the issue should be fixed? Thank you

qoqobolo · 2021-09-29T11:26:39Z

@cammellos thanks for the fix!
But well, there is still pretty strange behavior here.

Currently, ISSUE 4 is reproducible sporadically.
In 4 out of 5 cases, the feature worked for me if the user with the profile picture (UserA) added the second user (UserB) to the contacts first. In that case, UserB immediately saw the PP after adding UserA to contacts.

I mean these steps to reproduce successful flow:

UserA sets profile picture
UserA adds UserB to contacts (e.g via QR scanner)
UserB adds UserA to contacts (via QR scanner)
UserA starts 1-1 chat with UserB

But it doesn't work for me anymore :(

However, if after that both users join the same public chat, and UserA (with PP) sends a message, then the PP will be displayed for UserB in the chat history and in 1-1 chat as well.

So, this issue can be described:

ISSUE 5: Profile photo is only visible for UserB after UserA sends a message to public chat

Steps:

UserA sets profile picture
UserA adds UserB to contacts (e.g via QR scanner)
UserB adds UserA to contacts (via QR scanner)
UserA starts 1-1 chat with UserB
UserA and UserB join the same public chat
UserA sends a message

Expected result: UserB can see PP after adding UserA to contacts in User Profile and in 1-1 chat
Actual result: UserB can only see UserA's PP after joining a public chat and sending message by UserA

cammellos · 2021-09-29T11:57:55Z

@qoqobolo thanks for the info, I will be taking a look at it

qoqobolo · 2021-09-30T10:03:54Z

@cammellos issues 4 and 5 are fixed 🥳 Default settings See PP from: Contacts, Show your PP to: Contacts work fine. Thanks!

ISSUE 6: Profile photo of UserA is visible to UserB if UserA sets `Show your PP to: None` or `Show your PP to: Contacts`, but UserB is not contact of UserA

The issue is reproducible only if UserB has already seen UserA's photo profile, i.e if at first UserA's had Show your PP to: Contacts and UserB were contact of UserA, but then UserA changed this setting to Show your PP to: None.
So if UserA first changed the settings to Show your PP to: None, and then started a chat with UserB, then UserB will not see UserA's profile photo.

Reproduction:

Add profile photo
Add UserB to contacts and start 1-1 chat
UserB adds UserA to contacts
UserA: Settings > Privacy and security > Show your PP to: None
UserB: check profile photo of UserA
Expected behavior: UserB cannot see PP of UserA
Actual behavior: UserB sees PP of UserA

There are cases when PP is visible, although it should be hidden.

UserA (with PP) sets Show your PP to: Contacts, UserB See PP from: Everyone
UserB is not contact of UserA
UserA (with PP) sets Show your PP to: None, UserB See PP from: Everyone
UserA (with PP) sets Show your PP to: None, UserB See PP from: Contacts
UserB adds to contacts UserA

For all these cases
Expected behavior: UserB cannot see PP of UserA
Actual behavior: UserB sees PP of UserA

Please ping me for clarification if needed.

churik · 2021-09-30T11:35:18Z

@cammellos I wouldn't mind merging it with #11768 (comment) but if it is too much effort to fix it now, as a temporary decision might be for example to warn the user that he couldn't hide PP anymore for users that already seen his PP (add some explanation to Show my picture to screen)
Can we do it in this PR or we should log separate issue?

cammellos · 2021-09-30T11:38:11Z

@churik if you don't mind logging on a separate issue so we can get this merged, and we can add it to 1.17 so we make sure we don't release without, if that's ok

churik · 2021-09-30T11:40:44Z

Sure, we will do this
Thank you @qoqobolo for testing and @cammellos for resolving issues!

cammellos · 2021-09-30T12:06:44Z

Thank you @churik @qoqobolo @Samyoul , merged!

cammellos reviewed Feb 26, 2021

View reviewed changes

src/status_im/ui/screens/privacy_and_security_settings/views.cljs Outdated Show resolved Hide resolved

src/status_im/ui/screens/privacy_and_security_settings/views.cljs Outdated Show resolved Hide resolved

Samyoul marked this pull request as ready for review February 26, 2021 14:33

Samyoul requested review from cammellos, rasom and shivekkhurana February 26, 2021 14:34

shivekkhurana approved these changes Feb 26, 2021

View reviewed changes

Samyoul requested review from churik and jakubgs as code owners March 1, 2021 22:03

Samyoul force-pushed the feature/private-profile-pictures branch from e52f43b to 5756f01 Compare March 4, 2021 16:07

Samyoul self-assigned this Mar 4, 2021

Samyoul added the request-manual-qa label Mar 5, 2021

Samyoul force-pushed the feature/private-profile-pictures branch 2 times, most recently from bd2a7ee to 4420465 Compare March 24, 2021 10:43

Samyoul force-pushed the feature/private-profile-pictures branch from 4420465 to 923f628 Compare March 31, 2021 11:04

Samyoul mentioned this pull request Apr 15, 2021

Private Profile Photos status-im/status-go#2151

Merged

Samyoul force-pushed the feature/private-profile-pictures branch from fee3d45 to 3ac663e Compare April 19, 2021 16:05

flexsurfer removed the Tested - Issues label Sep 27, 2021

Samyoul force-pushed the feature/private-profile-pictures branch from 60438a4 to 0601a4c Compare September 27, 2021 11:20

qoqobolo added the Tested - Issues label Sep 28, 2021

cammellos force-pushed the feature/private-profile-pictures branch from 0601a4c to 398d040 Compare September 29, 2021 08:36

cammellos force-pushed the feature/private-profile-pictures branch from 398d040 to fca2f9c Compare September 29, 2021 15:27

churik added Tested - OK and removed Tested - Issues labels Sep 30, 2021

Add private profile pictures

5108ae7

cammellos force-pushed the feature/private-profile-pictures branch from fca2f9c to 5108ae7 Compare September 30, 2021 12:06

cammellos merged commit 5108ae7 into develop Sep 30, 2021

cammellos deleted the feature/private-profile-pictures branch September 30, 2021 12:06

qoqobolo mentioned this pull request Oct 4, 2021

Can't hide Profile picture from another user if it was once seen #12680

Closed

Samyoul mentioned this pull request Oct 4, 2021

Profile picture privacy is worse than Signal status-im/status#56

Open

qoqobolo mentioned this pull request Oct 26, 2021

Show profile photos to list item is active by default #12751

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Private Profile Photos #11768

Private Profile Photos #11768

Samyoul commented Feb 18, 2021 •

edited

Loading

status-im-auto commented Feb 18, 2021 •

edited

Loading

Samyoul commented Feb 26, 2021

cammellos commented Feb 26, 2021

Samyoul commented Mar 4, 2021

cammellos commented Mar 19, 2021

status-im-auto commented Mar 31, 2021

churik commented Apr 15, 2021

flexsurfer commented Sep 27, 2021

qoqobolo commented Sep 27, 2021 •

edited

Loading

status-im-auto commented Sep 27, 2021

cammellos commented Sep 29, 2021

qoqobolo commented Sep 29, 2021

cammellos commented Sep 29, 2021

qoqobolo commented Sep 30, 2021 •

edited

Loading

churik commented Sep 30, 2021 •

edited

Loading

cammellos commented Sep 30, 2021

churik commented Sep 30, 2021 •

edited

Loading

cammellos commented Sep 30, 2021

Private Profile Photos #11768

Private Profile Photos #11768

Conversation

Samyoul commented Feb 18, 2021 • edited Loading

status-im-auto commented Feb 18, 2021 • edited Loading

Jenkins Builds

Samyoul commented Feb 26, 2021

cammellos commented Feb 26, 2021

Samyoul commented Mar 4, 2021

cammellos commented Mar 19, 2021

status-im-auto commented Mar 31, 2021

96% of end-end tests have passed

Failed tests (3)

Passed tests (77)

churik commented Apr 15, 2021

flexsurfer commented Sep 27, 2021

qoqobolo commented Sep 27, 2021 • edited Loading

ISSUE 4

status-im-auto commented Sep 27, 2021

94% of end-end tests have passed

Failed tests (4)

Passed tests (63)

cammellos commented Sep 29, 2021

qoqobolo commented Sep 29, 2021

ISSUE 5: Profile photo is only visible for UserB after UserA sends a message to public chat

cammellos commented Sep 29, 2021

qoqobolo commented Sep 30, 2021 • edited Loading

ISSUE 6: Profile photo of UserA is visible to UserB if UserA sets Show your PP to: None or Show your PP to: Contacts, but UserB is not contact of UserA

churik commented Sep 30, 2021 • edited Loading

cammellos commented Sep 30, 2021

churik commented Sep 30, 2021 • edited Loading

cammellos commented Sep 30, 2021

Samyoul commented Feb 18, 2021 •

edited

Loading

status-im-auto commented Feb 18, 2021 •

edited

Loading

qoqobolo commented Sep 27, 2021 •

edited

Loading

qoqobolo commented Sep 30, 2021 •

edited

Loading

ISSUE 6: Profile photo of UserA is visible to UserB if UserA sets `Show your PP to: None` or `Show your PP to: Contacts`, but UserB is not contact of UserA

churik commented Sep 30, 2021 •

edited

Loading

churik commented Sep 30, 2021 •

edited

Loading