Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trigger migration to Keycard from logged in state #12395

Merged
merged 1 commit into from
Aug 2, 2021
Merged

trigger migration to Keycard from logged in state #12395

merged 1 commit into from
Aug 2, 2021

Conversation

bitgamma
Copy link
Member

Closes #11778. It logs you out and redirects to the key management UI since it is the safest way to actually perform the migration.

The entry point is from Profile -> Privacy and Settings -> Manage Keys and Storage.

When we do #12336 the menu label will be renamed to whatever we decide it should be called (Migrate account to Keycard I guess)

@bitgamma bitgamma self-assigned this Jul 29, 2021
@status-im-auto
Copy link
Member

status-im-auto commented Jul 29, 2021 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c624e89 #1 2021-07-29 13:49:07 ~15 min android 📦apk 📲
✔️ c624e89 #1 2021-07-29 13:49:39 ~15 min android-e2e 📦apk 📲
✔️ c624e89 #1 2021-07-29 13:54:00 ~20 min ios 📦ipa 📲
✔️ 7631884 #2 2021-08-02 09:05:19 ~12 min android-e2e 📦apk 📲
✔️ 7631884 #2 2021-08-02 09:07:38 ~14 min android 📦apk 📲
✔️ 7631884 #2 2021-08-02 09:09:27 ~16 min ios 📦ipa 📲

shivekkhurana
shivekkhurana reviewed Jul 30, 2021
View reviewed changes
Copy link
Contributor

@shivekkhurana shivekkhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if nil in on-cancel will throw an error or not. Everything else seems fine.

src/status_im/multiaccounts/key_storage/core.cljs Show resolved Hide resolved
@status-im-auto
Copy link
Member

94% of end-end tests have passed

Total executed tests: 71
Failed tests: 4
Passed tests: 67

IDs of failed tests: 6228,6265,6646,6237

Failed tests (4)

Click to expand
  • Rerun tests

    • 1. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: *Find Button by xpath:* `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: *Find Button by xpath:* `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Chat history was not fetched with mobile data fetching ON

    Device sessions

    2. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265

    Device 1: Decline transaction request and check that state is changed
    Device 1: =========================================================================

    Device 1: RequestCommand by xpath: `//*[@text="Request transaction"]` is not found on the screen

    Device sessions

    3. test_set_profile_picture, id: 6646

    Device 1: *Click system back button*
    Device 1: *Find Button by accessibility id:* `take-photo`

    Device 1: Button by accessibility id: `take-photo` is not found on the screen

    Device sessions

    4. test_fetching_balance_after_offline, id: 6237

    Device 1: **Signing transaction (keycard:False, default_gas_price:False)**
    Device 1: *Find Button by accessibility id:* `custom-gas-fee`

    Device 1: Button by accessibility id: `custom-gas-fee` is not found on the screen

    Device sessions

    Passed tests (67)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    3. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    4. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    5. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    6. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    7. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    8. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    9. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    10. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    11. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    12. test_delete_close_all_tabs, id: 5390
    Device sessions

    13. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    14. test_send_token_with_7_decimals, id: 5350
    Device sessions

    15. test_edit_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    16. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    17. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    18. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    19. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    20. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    21. test_block_user_from_public_chat, id: 5786
    Device sessions

    22. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    23. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    24. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    25. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    26. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    27. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    28. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    29. test_back_forward_refresh_navigation_history_kept_after_relogin (TestRail link is not found)
    Device sessions

    30. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    31. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    32. test_long_press_to_delete_chat, id: 5319
    Device sessions

    33. test_copy_and_paste_messages, id: 5317
    Device sessions

    34. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    35. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    36. test_user_can_see_all_own_assets_after_account_recovering, id: 5381
    Device sessions

    37. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    38. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    39. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    40. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    41. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    42. test_manage_assets, id: 5341
    Device sessions

    43. test_browser_managing_bookmarks, id: 6633
    Device sessions

    44. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    45. test_request_stt_from_daap, id: 5309
    Device sessions

    46. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    47. test_dapps_permissions, id: 5738
    Device sessions

    48. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    49. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    50. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    51. test_wallet_set_up, id: 5335
    Device sessions

    52. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    53. test_home_view, id: 5379
    Device sessions

    54. test_can_add_existing_ens, id: 5502
    Device sessions

    55. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    56. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    57. test_collectible_from_wallet, id: 5346
    Device sessions

    58. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    59. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    60. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    61. test_pass_phrase_validation, id: 5363
    Device sessions

    62. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    63. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    64. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    65. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    66. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    67. test_keycard_fetching_balance_after_offline, id: 6290
    Device sessions

    @churik
    Copy link
    Member

    churik commented Jul 30, 2021 •
    edited
    Loading

    Looks good to me! The only thing I could suggest to improve: maybe change the copy for "Log out" popup for this case to explicitly pointing that Log out is required for migration.
    Currently, it looks like the default "Log out?" popup
    IMAGE 2021-07-30 17:33:52
    Appreciate your opinion here @errorists

    However, don't think it is a blocker for PR.

    @bitgamma
    Copy link
    Member Author

    bitgamma commented Aug 2, 2021

    @churik Thanks, I changed to message to make it clearer. I think it will be changed again when we do #12336 but at least for now it should be ok

    @bitgamma bitgamma merged commit 9759add into develop Aug 2, 2021
    @bitgamma bitgamma deleted the feature/11778 branch August 2, 2021 08:54
    @churik churik mentioned this pull request Sep 22, 2021
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    @shivekkhurana shivekkhurana shivekkhurana left review comments

    Assignees

    @bitgamma bitgamma

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Enable migration to keycard from signed-in state
    5 participants
    @bitgamma @status-im-auto @churik @shivekkhurana @flexsurfer