Bug reporting and logs sharing improvements #12773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (48)
|
rasom
force-pushed
the
some-bug-reporting-logs-sharing-improvements
branch
from
2d514e0 to
9dc200f
Compare
rasom
force-pushed
the
some-bug-reporting-logs-sharing-improvements
branch
from
4496366 to
18ea3f6
Compare
ISSUE 1: fields are overlapped with keyboard on Android
ISSUE 2: If I closed error reporting form one time, can't open it again on shaking until app reopening (Android)ISSUE 3: On
|
rasom
force-pushed
the
some-bug-reporting-logs-sharing-improvements
branch
from
bc8023e to
332183d
Compare
|
@churik 2-4 are fixed 1 is also fixed by using modal instead of bottom sheet, it just works there |
rasom
force-pushed
the
some-bug-reporting-logs-sharing-improvements
branch
from
332183d to
dd2689b
Compare
|
awesome work @rasom! |
rasom
force-pushed
the
some-bug-reporting-logs-sharing-improvements
branch
from
dd2689b to
d0f14e9
Compare
|
@churik fixed |
|
@rasom FILE.2021-11-10.11.43.58.mp4Please, mind my commit when squashing. thanks! |
rasom
force-pushed
the
some-bug-reporting-logs-sharing-improvements
branch
from
de51124 to
7a09aa5
Compare
|
@rasom FILE.2021-11-10.15.02.36.mp4 |
rasom
force-pushed
the
some-bug-reporting-logs-sharing-improvements
branch
from
91a7e08 to
6175850
Compare
|
@churik done |
rasom
force-pushed
the
some-bug-reporting-logs-sharing-improvements
branch
from
6175850 to
7359c52
Compare
bitgamma
approved these changes
Nov 12, 2021
flexsurfer
reviewed
Nov 12, 2021
| (defn bug-report [] | ||
| (let [{:keys [description steps]} @(re-frame/subscribe [:bug-report/details])] | ||
| [react-native/view {:style {:flex 1}} | ||
| [topbar/topbar |
There was a problem hiding this comment.
better to use native topbar in this case
| [topbar/topbar | ||
| {:title (i18n/label :t/bug-report) | ||
| :modal? true}] | ||
| [react-native/view {:style {:flex 1 |
There was a problem hiding this comment.
this is something new, usually we use react/view or rn/view
| @@ -1194,7 +1194,7 @@ | |||
| "remove-token": "Alisin ang token", | |||
| "removed": "alisin", | |||
| "repeat-pin": "Ulitin ang bagong 6-digit na passcode", | |||
| "report-bug-email-template": "1. Paglalarawan ng Isyu\n(Ilarawan ang tampok na nais mo, o maikli ang buod ng bug at kung ano ang iyong ginawa, kung ano ang inaasahan mong mangyari, at kung ano ang tunay na mangyayari. Mga seksyon sa ibaba)\n\n\n2. Mga hakbang upang makalikha\n(Ilarawan kung paano namin maaaring kopyahin ang sunud-sunod na hakbang.)\n-Buksan ang Status\n-...\n-Step 3, atbp.\n\n3. Inaasahang pag-uugali\n(Ilarawan kung ano ang inaasahan mong mangyari.)\n\n\n4. Aktwal na pag-uugali\n(Ilarawan kung ano talaga ang nangyari.)\n\n\n5. Ikabit ang mga screenshot na maaaring mag-demo sa problema, kung maaari sana", | |||
| "report-bug-email-template": "1. Paglalarawan ng Isyu\{{description}}\n\n\n2. Mga hakbang upang makalikha\n {{steps}}\n\n\n3. Ikabit ang mga screenshot na maaaring mag-demo sa problema, kung maaari sana", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
fix #12042
status: wip