-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to be reinvited to the same group after leaving #12814
Allow user to be reinvited to the same group after leaving #12814
Conversation
Jenkins BuildsClick to see older builds (23)
|
e6bed1a
to
8236011
Compare
46% of end-end tests have passed
Failed tests (37)Click to expand
Passed tests (32)Click to expand
|
65% of end-end tests have passed
Failed tests (13)Click to expand
Passed tests (24)Click to expand |
81% of end-end tests have passed
Failed tests (13)Click to expand
Passed tests (56)Click to expand |
Hi @Parveshdhull! Took the PR for testing. FYI, the e2e fails are not PR related, so you can ignore them for now. |
8236011
to
4a782b9
Compare
71% of end-end tests have passed
Failed tests (20)Click to expand
Passed tests (49)Click to expand |
8% of end-end tests have passed
Failed tests (12)Click to expand
Passed tests (1) |
ISSUE 1: Can't add a user to contactsNothing happens when trying to add a user to contacts in any way (scanning QR, adding in the chat view, etc) Steps:
OS: iOS, Android video_2021-11-16_11-57-43.mp4 |
@Parveshdhull yeah, I checked before reporting. On the latest develop it works fine. |
Thanks, I will fix this issue 👍
|
maybe status-go needs to be rebased too |
4a782b9
to
f6216e9
Compare
@qoqobolo, Sorry about that 😅, Now I rebased status-go too and tested, and this fixed the issue. Thanks |
@Parveshdhull it's okay, thank you! :) ISSUE 2: No push notification if the user was reinvited to the group by their contact on AndroidAlso, this group appears in the activity center, but currently, group chat invitations from contacts appear on the home screen. I believe re-invitations from contacts should be displayed on the home screen as well. WDYT? Steps:
Expected behavior:
Actual behavior:
|
f6216e9
to
2b1019b
Compare
ISSUE 2: fixed |
0% of end-end tests have passed
Failed tests (25)Click to expand
|
@Parveshdhull thank you! ISSUE 3: Re-invites to group chats from contacts are not highlighted on the home screen as new chatsBased on #12654 they should be :) |
2b1019b
to
80699aa
Compare
ISSUE 3: fixed |
Thanks @Parveshdhull ! Unfortunately, found a strange behavior ISSUE 4: Re-invitations come endlessly after declining an invitation to a group until the admin of the group re-logs inIf UserA declines the invitation from UserB, then UserA will receive re-invitations to the group while UserB is logged-in (presumably until the first relogin of UserB). Steps:
User on the video just waits: video_2021-11-17_16-41-09.mp4 |
80699aa
to
5fb533e
Compare
ISSUE 4: fixed 👍 |
99% of end-end tests have passed
Failed tests (1)Click to expand
Passed tests (68)Click to expand |
@Parveshdhull Thanks for your hard work and patience in solving issues! |
5fb533e
to
dead30e
Compare
fixes #12079
Summary:
This PR allows users to be reinvited to the same group after leaving. Group invitation is received in the activity center notification.
status-go PR:
status-im/status-go#2431