Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Keycard timeout on iOS 15 #12826

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Handle Keycard timeout on iOS 15 #12826

merged 1 commit into from
Nov 18, 2021

Conversation

bitgamma
Copy link
Member

@bitgamma bitgamma commented Nov 17, 2021 •
edited
Loading

Fixes #12762.

in IOS15 retrying to immediately reopen the NFC dialog after it has been closed for timeout results in an error. The new behaviour is to retry every 500ms until it succeeds. This will results in a small delay between the disappearance of the timed-out dialog and the appearance of the new one, but the application will work normally.

@status-im-auto
Copy link
Member

status-im-auto commented Nov 17, 2021 •
edited
Loading

Jenkins Builds

Click to see older builds (6)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ cbb6e6a #1 2021-11-17 09:25:40 ~13 min ios 📦ipa 📲
✔️ cbb6e6a #1 2021-11-17 09:29:43 ~17 min android-e2e 📦apk 📲
✔️ cbb6e6a #1 2021-11-17 09:29:50 ~17 min android 📦apk 📲
✔️ 175229b #2 2021-11-17 10:28:48 ~18 min android-e2e 📦apk 📲
✔️ 175229b #2 2021-11-17 10:29:15 ~18 min ios 📦ipa 📲
✔️ 175229b #3 2021-11-17 10:47:07 ~18 min android 📦apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ceea02a #3 2021-11-17 10:57:29 ~12 min ios 📦ipa 📲
✔️ ceea02a #3 2021-11-17 10:57:53 ~12 min android-e2e 📦apk 📲
✔️ ceea02a #4 2021-11-17 11:01:42 ~16 min android 📦apk 📲
✔️ a4de9da #4 2021-11-17 11:25:29 ~18 min ios 📦ipa 📲
✔️ a4de9da #5 2021-11-17 11:41:44 ~16 min android-e2e 📦apk 📲
✔️ a4de9da #6 2021-11-17 11:41:44 ~17 min android 📦apk 📲

@bitgamma bitgamma self-assigned this Nov 17, 2021
@bitgamma bitgamma changed the title [wip] Handle Keycard timeout on iOS 15 Handle Keycard timeout on iOS 15 Nov 17, 2021
@status-im-auto
Copy link
Member

96% of end-end tests have passed

Total executed tests: 69
Failed tests: 3
Passed tests: 66

IDs of failed tests: 6316,5403,6279

Failed tests (3)

Click to expand
  • Rerun tests

    • 1. test_send_audio_message_with_push_notification_check, id: 6316

    Device 1: Find 'Button' by 'accessibility id': `start-stop-audio-recording-button`
    Device 1: Tap on found: Button

    Device 1: Exceeded 2 mins limit of recording time.

    Device sessions

    2. test_start_chat_with_ens_mention_in_one_to_one, id: 5403

    Device 1: Double tap on: HomeButton
    Device 1: Find 'HomeButton' by 'xpath': `//*[contains(@content-desc,'tab, 1 out of 5')]`

    Device 1: HomeButton by xpath: `//*[contains(@content-desc,'tab, 1 out of 5')]` is not found on the screen

    Device sessions

    3. test_send_eth_to_ens_in_chat, id: 6279

    # STEP: Check that message is fetched for receiver
    Device 2: Wait for text element 'TransactionStatus' to be equal to 'Confirmed'

    Device 2: 'TransactionStatus' by xpath:'//*[starts-with(@text,'↓ Incoming transaction')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/*[1]/*[1]/*[5]/android.widget.TextView' not found on the screen

    Device sessions

    Passed tests (66)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    3. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    4. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    5. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    6. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    7. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    8. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    9. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    10. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    11. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    12. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    13. test_delete_close_all_tabs, id: 5390
    Device sessions

    14. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    15. test_send_token_with_7_decimals, id: 5350
    Device sessions

    16. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    17. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    18. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    19. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    20. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    21. test_block_user_from_public_chat, id: 5786
    Device sessions

    22. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    23. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    24. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    25. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    26. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    27. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    28. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    29. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    30. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    31. test_long_press_to_delete_chat, id: 5319
    Device sessions

    32. test_copy_and_paste_messages, id: 5317
    Device sessions

    33. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    34. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    35. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    36. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    37. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    38. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    39. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    40. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    41. test_manage_assets, id: 5341
    Device sessions

    42. test_browser_managing_bookmarks, id: 6633
    Device sessions

    43. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    44. test_request_stt_from_daap, id: 5309
    Device sessions

    45. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    46. test_dapps_permissions, id: 5738
    Device sessions

    47. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    48. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    49. test_wallet_set_up, id: 5335
    Device sessions

    50. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    51. test_home_view, id: 5379
    Device sessions

    52. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    53. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    54. test_set_profile_picture, id: 6646
    Device sessions

    55. test_collectible_from_wallet, id: 5346
    Device sessions

    56. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    57. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    58. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    59. test_pass_phrase_validation, id: 5363
    Device sessions

    60. test_user_can_see_collectibles_on_rinkeby_after_account_recovering, id: 5381
    Device sessions

    61. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    62. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    63. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    64. test_fetching_balance_after_offline, id: 6237
    Device sessions

    65. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    66. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    @status-im-auto
    Copy link
    Member

    100% of end-end tests have passed

    Total executed tests: 69
Failed tests: 0
Passed tests: 69

    Passed tests (69)

    Click to expand

    1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    2. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    3. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    4. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    5. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    6. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    7. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    8. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    9. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    10. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    11. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    12. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    13. test_delete_close_all_tabs, id: 5390
    Device sessions

    14. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    15. test_send_token_with_7_decimals, id: 5350
    Device sessions

    16. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    17. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    18. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    19. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    20. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    21. test_block_user_from_public_chat, id: 5786
    Device sessions

    22. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    23. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    24. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    25. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    26. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    27. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    28. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    29. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    30. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    31. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    32. test_long_press_to_delete_chat, id: 5319
    Device sessions

    33. test_copy_and_paste_messages, id: 5317
    Device sessions

    34. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    35. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    36. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    37. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    38. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    39. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    40. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    41. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    42. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    43. test_manage_assets, id: 5341
    Device sessions

    44. test_browser_managing_bookmarks, id: 6633
    Device sessions

    45. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    46. test_request_stt_from_daap, id: 5309
    Device sessions

    47. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    48. test_dapps_permissions, id: 5738
    Device sessions

    49. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    50. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    51. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    52. test_wallet_set_up, id: 5335
    Device sessions

    53. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    54. test_home_view, id: 5379
    Device sessions

    55. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    56. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    57. test_set_profile_picture, id: 6646
    Device sessions

    58. test_collectible_from_wallet, id: 5346
    Device sessions

    59. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    60. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    61. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    62. test_pass_phrase_validation, id: 5363
    Device sessions

    63. test_user_can_see_collectibles_on_rinkeby_after_account_recovering, id: 5381
    Device sessions

    64. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    65. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    66. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    67. test_fetching_balance_after_offline, id: 6237
    Device sessions

    68. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    69. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    @qoqobolo qoqobolo self-assigned this Nov 18, 2021
    @qoqobolo
    Copy link
    Contributor

    @bitgamma thank you!
    The issue is fixed, no regression found.
    PR can be merged.

    @bitgamma
    better NFC timeout handling on iOS
    b919df6 
    Signed-off-by: Michele Balistreri <[email protected]>
    @bitgamma bitgamma merged commit b919df6 into develop Nov 18, 2021
    @bitgamma bitgamma deleted the fix/12762 branch November 18, 2021 11:57
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @rasom rasom rasom approved these changes

    Assignees

    @bitgamma bitgamma

    @qoqobolo qoqobolo

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    App freezes after keycard connection timeout on IOS 15
    5 participants
    @bitgamma @status-im-auto @qoqobolo @rasom @Parveshdhull