Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12782] Re-open app on the last open chat #12873

Merged
merged 1 commit into from
Dec 15, 2021
Merged

[#12782] Re-open app on the last open chat #12873

merged 1 commit into from
Dec 15, 2021

Conversation

rasom
Copy link
Contributor

@rasom rasom commented Dec 2, 2021 •
edited
Loading

fixes #12782

status: ready

@rasom rasom self-assigned this Dec 2, 2021
@status-im-auto
Copy link
Member

status-im-auto commented Dec 2, 2021 •
edited
Loading

Jenkins Builds

Click to see older builds (46)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3e2f54b #1 2021-12-02 11:18:30 ~11 min ios 📦ipa 📲
✔️ 3e2f54b #1 2021-12-02 11:21:19 ~14 min android 📦apk 📲
✔️ 3e2f54b #1 2021-12-02 11:22:42 ~15 min android-e2e 📦apk 📲
✔️ 7cf41b5 #2 2021-12-02 12:18:47 ~10 min ios 📦ipa 📲
✔️ 7cf41b5 #2 2021-12-02 12:19:49 ~11 min android-e2e 📦apk 📲
✔️ 7cf41b5 #2 2021-12-02 12:20:55 ~12 min android 📦apk 📲
✔️ 383399e #3 2021-12-02 12:52:31 ~10 min ios 📦ipa 📲
✔️ 383399e #3 2021-12-02 12:56:17 ~14 min android-e2e 📦apk 📲
✔️ 383399e #3 2021-12-02 12:56:18 ~14 min android 📦apk 📲
✔️ 1de0288 #4 2021-12-02 13:12:12 ~10 min ios 📦ipa 📲
✔️ 1de0288 #4 2021-12-02 13:15:40 ~14 min android-e2e 📦apk 📲
✔️ 1de0288 #4 2021-12-02 13:15:41 ~14 min android 📦apk 📲
❌ e7357b9 #5 2021-12-02 13:30:19 ~2 min ios 📄log
❌ e7357b9 #5 2021-12-02 13:31:30 ~3 min android-e2e 📄log
❌ e7357b9 #5 2021-12-02 13:31:30 ~3 min android 📄log
✔️ 0016ac0 #6 2021-12-02 13:47:21 ~10 min ios 📦ipa 📲
✔️ 0016ac0 #6 2021-12-02 13:50:40 ~14 min android 📦apk 📲
✔️ 0016ac0 #6 2021-12-02 13:50:50 ~14 min android-e2e 📦apk 📲
✔️ 9575597 #7 2021-12-02 14:01:33 ~10 min ios 📦ipa 📲
✔️ 9575597 #7 2021-12-02 14:05:52 ~14 min android 📦apk 📲
✔️ 9575597 #7 2021-12-02 14:05:59 ~15 min android-e2e 📦apk 📲
✔️ ca4876e #8 2021-12-02 14:52:26 ~14 min ios 📦ipa 📲
✔️ ca4876e #8 2021-12-02 14:53:16 ~15 min android 📦apk 📲
✔️ ca4876e #8 2021-12-02 14:54:03 ~16 min android-e2e 📦apk 📲
✔️ 089b007 #9 2021-12-02 15:23:01 ~11 min ios 📦ipa 📲
✔️ 089b007 #9 2021-12-02 15:25:57 ~14 min android 📦apk 📲
✔️ 089b007 #9 2021-12-02 15:25:57 ~14 min android-e2e 📦apk 📲
✔️ 089b007 #10 2021-12-06 12:51:47 ~12 min ios 📦ipa 📲
✔️ 7ffbe4a #11 2021-12-06 15:37:27 ~11 min ios 📦ipa 📲
✔️ 7ffbe4a #10 2021-12-06 15:38:59 ~12 min android-e2e 📦apk 📲
✔️ 7ffbe4a #10 2021-12-06 15:47:22 ~21 min android 📦apk 📲
✔️ 2c108b6 #12 2021-12-07 14:07:42 ~15 min ios 📦ipa 📲
✔️ 2c108b6 #11 2021-12-07 14:10:46 ~18 min android-e2e 📦apk 📲
✔️ 2c108b6 #11 2021-12-07 14:10:54 ~18 min android 📦apk 📲
✔️ 0107adb #13 2021-12-08 10:07:21 ~10 min ios 📦ipa 📲
✔️ 0107adb #12 2021-12-08 10:11:53 ~14 min android 📦apk 📲
✔️ 0107adb #12 2021-12-08 10:11:55 ~14 min android-e2e 📦apk 📲
✔️ 49292a1 #13 2021-12-09 09:44:16 ~14 min android-e2e 📦apk 📲
✔️ 49292a1 #13 2021-12-09 09:44:16 ~14 min android 📦apk 📲
✔️ 49292a1 #14 2021-12-09 09:44:48 ~15 min ios 📦ipa 📲
✔️ 2bb9893 #15 2021-12-09 10:07:57 ~10 min ios 📦ipa 📲
✔️ 2bb9893 #14 2021-12-09 10:10:21 ~13 min android 📦apk 📲
✔️ 2bb9893 #14 2021-12-09 10:15:04 ~18 min android-e2e 📦apk 📲
✔️ f269b18 #15 2021-12-09 11:14:27 ~11 min android 📦apk 📲
✔️ f269b18 #15 2021-12-09 11:15:02 ~12 min android-e2e 📦apk 📲
✔️ f269b18 #16 2021-12-09 11:20:56 ~18 min ios 📦ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 876ae13 #17 2021-12-09 11:54:22 ~10 min ios 📦ipa 📲
✔️ 876ae13 #16 2021-12-09 11:57:47 ~14 min android-e2e 📦apk 📲
✔️ 876ae13 #16 2021-12-09 11:57:49 ~14 min android 📦apk 📲
✔️ 876ae13 #18 2021-12-15 11:05:28 ~16 min ios 📦ipa 📲
✔️ 646add5 #19 2021-12-15 11:57:33 ~11 min ios 📦ipa 📲
✔️ 646add5 #17 2021-12-15 11:58:53 ~12 min android-e2e 📦apk 📲
✔️ 646add5 #17 2021-12-15 12:03:06 ~16 min android 📦apk 📲

@rasom rasom force-pushed the feat/#12782-re-open-app-on-the-last-open-chat branch 5 times, most recently from ca4876e to 089b007 Compare December 2, 2021 15:10
flexsurfer
flexsurfer reviewed Dec 3, 2021
View reviewed changes
src/status_im/events.cljs Show resolved Hide resolved
src/status_im/events.cljs Show resolved Hide resolved
src/status_im/multiaccounts/login/core.cljs Outdated Show resolved Hide resolved
src/status_im/utils/fx.cljs Show resolved Hide resolved
@status-im-auto
Copy link
Member

87% of end-end tests have passed

Total executed tests: 69
Failed tests: 9
Passed tests: 60

IDs of failed tests: 6305,5387,5786,5675,695843,5310,5762,6228,6279

Failed tests (9)

Click to expand
  • Rerun tests

    • 1. test_image_in_one_to_one_send_save_reply_timeline, id: 6305

    Device 2: Find 'Button' by 'xpath': `//*[@text="Hey hey hey"]`
    Device 2: Find 'Button' by 'xpath': `//*[@text="Hey hey hey"]`

    Device 2: Button by xpath: `//*[@text="Hey hey hey"]` is not found on the screen

    Device sessions

    2. test_delete_chats_via_delete_button_rejoin, id: 5387

    ## Public chat 'public-delete-long-press' is created successfully!
    Device 1: Looking for a message by text: test message:pyorqpkcdt

    Messages are not fetched when rejoining public chat after deleting

    Device sessions

    3. test_block_user_from_public_chat, id: 5786

    Device 1: Find 'Button' by 'accessibility id': `new-chat-button`
    Device 1: ChatButton element not found

    Device 1: ChatButton by accessibility id:`join-public-chat-button` is not found on the screen

    Device sessions

    4. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675

    Device 1: 'Text' is '#spectentur'
    # STEP: Check that can fetch previous history

    Device 1: "Dec 2, 2021" is not shown

    Device sessions

    5. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843

    Device 1: Looking for a message by text: Message AFTER edit 2
    Device 2: Looking for a message by text: Message AFTER edit 2

    No mark in message bubble about this message was edited Message is not edited.

    Device sessions

    6. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310

    Device 1: Looking for chat: 'Flimsy Ancient Chanticleer'
    Device 1: Wait for element 'Button' for max 30s and click when it is available

    Device 1: Button by accessibility id:`notifications-unread-badge` is not found on the screen

    Device sessions

    7. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762

    Device 1: Looking for a message by text: I am blocked user
    Device 1: Find 'ChatElementByText' by 'xpath': `//*[starts-with(@text,'I am blocked user')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']`

    Device 1: ChatElementByText by xpath:`//*[starts-with(@text,'I am blocked user')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen

    Device sessions

    8. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: Find 'Button' by 'xpath': `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: Find 'Button' by 'xpath': `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Chat history was not fetched with mobile data fetching ON

    Device sessions

    9. test_send_eth_to_ens_in_chat, id: 6279

    Transaction #5, amount is 0.00371545
    {'blockNumber': '11543418', 'timeStamp': '1638515739', 'hash': '0x6b5ae41151d13368c89c6589ba19b71d9a0252f7c68289c0f9b545c98d534543', 'nonce': '6790', 'blockHash': '0xa62d2f6188142f2929228de0ea7f2004feac62d17eadd63ff4c725e546365555', 'transactionIndex': '24', 'from': '0xf7cb60839c0de25e37be0391c33bb34a8f0f8414', 'to': '0x58d8c3d70ce4fa4b9fb10a665c8712238746f2ff', 'value': '3715450000000000', 'gas': '21000', 'gasPrice': '2499999951', 'isError': '0', 'txreceipt_status': '1', 'input': '0x', 'contractAddress': '', 'cumulativeGasUsed': '4096497', 'gasUsed': '21000', 'confirmations': '1568'}

    Transaction with amount 0.003131637 is not found in list of ETH transactions, address is f7cb60839c0de25e37be0391c33bb34a8f0f8414 during 300s

    Device sessions

    Passed tests (60)

    Click to expand

    1. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    2. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    3. test_request_stt_from_dapp, id: 5309
    Device sessions

    4. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    5. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    6. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    7. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    8. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    9. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    10. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    11. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    12. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    13. test_delete_close_all_tabs, id: 5390
    Device sessions

    14. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    15. test_send_token_with_7_decimals, id: 5350
    Device sessions

    16. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    17. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    18. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    19. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    20. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    21. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    22. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    23. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    24. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    25. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    26. test_long_press_to_delete_chat, id: 5319
    Device sessions

    27. test_copy_and_paste_messages, id: 5317
    Device sessions

    28. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    29. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    30. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    31. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    32. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    33. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    34. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    35. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    36. test_manage_assets, id: 5341
    Device sessions

    37. test_browser_managing_bookmarks, id: 6633
    Device sessions

    38. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    39. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    40. test_dapps_permissions, id: 5738
    Device sessions

    41. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    42. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    43. test_wallet_set_up, id: 5335
    Device sessions

    44. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    45. test_home_view, id: 5379
    Device sessions

    46. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    47. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    48. test_set_profile_picture, id: 6646
    Device sessions

    49. test_collectible_from_wallet, id: 5346
    Device sessions

    50. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    51. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    52. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    53. test_pass_phrase_validation, id: 5363
    Device sessions

    54. test_user_can_see_collectibles_on_rinkeby_after_account_recovering, id: 5381
    Device sessions

    55. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    56. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    57. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    58. test_fetching_balance_after_offline, id: 6237
    Device sessions

    59. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    60. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    @status-im-auto
    Copy link
    Member

    89% of end-end tests have passed

    Total executed tests: 9
Failed tests: 1
Passed tests: 8

    IDs of failed tests: 5786

    Failed tests (1)

    Click to expand
  • Rerun tests

    • 1. test_block_user_from_public_chat, id: 5786

    Device 1: Find 'Button' by 'accessibility id': `new-chat-button`
    Device 1: ChatButton element not found

    Device 1: ChatButton by accessibility id:`join-public-chat-button` is not found on the screen

    Device sessions

    Passed tests (8)

    Click to expand

    1. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    2. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    3. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    4. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    5. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    6. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    7. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    8. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    @churik churik self-assigned this Dec 6, 2021
    @status-im-auto
    Copy link
    Member

    88% of end-end tests have passed

    Total executed tests: 86
Failed tests: 10
Passed tests: 76

    IDs of failed tests: 695847,6232,5456,5763,5784,6322,6292,6636,4001,5742

    Failed tests (10)

    Click to expand
  • Rerun tests

    • 1. test_can_pin_messages_in_one_to_one_and_group_chats, id: 695847

    Device 2: Tap on found: ViewProfileButton
    Device 2: Find 'PinnedMessageCounter' by 'xpath': `//*[@content-desc='pinned-messages-item']/android.widget.TextView[2]`

    Device 2: PinnedMessageCounter by xpath: `//*[@content-desc='pinned-messages-item']/android.widget.TextView[2]` is not found on the screen

    Device sessions

    2. test_switching_accounts_in_dapp, id: 6232

    Device 1: Find 'ProfileButton' by 'xpath': `//*[contains(@content-desc,'5 out of 5')]`
    Device 1: Find 'Button' by 'xpath': `//*[@text="simpledapp.eth"]`

    Device 1: Button by xpath: `//*[@text="simpledapp.eth"]` is not found on the screen

    Device sessions

    3. test_can_access_images_by_link, id: 5456

    Device 1: Find 'Button' by 'accessibility id': `previous-page-button`
    Device 1: EditBox element not found

    Web page does not match expected template url2.png

    Device sessions

    4. test_block_user_from_one_to_one_header_check_push_notification_service, id: 5763

    Device 1: Find 'Button' by 'accessibility id': `new-chat-button`
    Device 1: ChatButton element not found

    Device 1: ChatButton by accessibility id:`join-public-chat-button` is not found on the screen

    Device sessions

    5. test_sign_typed_message_deploy_simple_contract_request_pub_key_from_dapp, id: 5784

    Device 1: Text element not found
    Device 1: Find 'EditBox' by 'accessibility id': `enter-password-input`

    Device 1: EditBox by accessibility id: `enter-password-input` is not found on the screen

    Device sessions

    6. test_can_scan_different_links_with_universal_qr_scanner, id: 6322

    Device 1: Tap on found: Button
    Device 1: Find 'BackButton' by 'accessibility id': `Navigate Up`

    No allow button is shown in case of navigating to Status dapp!

    Device sessions

    7. test_keycard_send_funds_between_accounts_set_max_in_multiaccount_instance, id: 6292

    Expected amount of confirmations is 6, in fact 5
    Finding tx in ETH transactions, attempt #1

    Expecting value: line 1 column 1 (char 0)

    Device sessions

    8. test_show_profile_picture_of_setting, id: 6636

    Device 2: Looking for a message by text: Trololo
    Device 2: Find 'MemberPhoto' by 'xpath': `//*[starts-with(@text,'Trololo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='member-photo']`

    Device 2: MemberPhoto by xpath: `//*[starts-with(@text,'Trololo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='member-photo']` is not found on the screen

    Device sessions

    9. test_remove_member_from_group_chat, id: 4001

    Device 3: Looking for a message by text: after removing member
    Device 2: Looking for a message by text: after removing member

    Message with text 'Dazzling Handsome Andeancondor left the group' was not received

    Device sessions

    10. test_keycard_interruption_creating_onboarding_flow, id: 5742

    Device 1: Tap on found: Button
    Device 1: Enter default pin 111111

    Device 1: Button by accessibility id:`maybe-later` is not found on the screen

    Device sessions

    Passed tests (76)

    Click to expand

    1. test_set_currency, id: 5429
    Device sessions

    2. test_can_change_account_settings, id: 6235
    Device sessions

    3. test_pair_devices_group_chat_different_messages_nicknames, id: 6317
    Device sessions

    4. test_open_url_with_non_english_text_connect_revoke_wallet_new_tab_open_chat_options, id: 5424
    Device sessions

    5. test_deny_access_camera_and_gallery, id: 6319
    Device sessions

    6. test_can_start_chat_from_suggestions_using_search_chat, id: 6320
    Device sessions

    7. test_can_scan_eip_681_links, id: 6282
    Device sessions

    8. test_decline_invitation_to_group_chat, id: 5756
    Device sessions

    9. test_mention_users_not_in_chats_if_not_in_contacts, id: 6326
    Device sessions

    10. test_mark_all_messages_as_read_public_chat, id: 6270
    Device sessions

    11. test_leave_group_chat_highligted_via_group_info, id: 3997
    Device sessions

    12. test_can_not_connect_to_mailserver, id: 5767
    Device sessions

    13. test_push_notifications_reactions_for_messages_in_stickers_audio_image, id: 6321
    Device sessions

    14. test_invite_to_group_chat_handling, id: 6324
    Device sessions

    15. test_same_seed_added_inside_multiaccount_and_keycard, id: 6311
    Device sessions

    16. test_search_chat_on_home, id: 5757
    Device sessions

    17. test_deep_link_with_invalid_user_public_key_own_profile_key, id: 5781
    Device sessions

    18. test_keycard_settings_pin_puk_pairing, id: 695841
    Device sessions

    19. test_recover_accounts_with_certain_seedphrase, id: 5455
    Device sessions

    20. test_webview_camera_permission, id: 6635
    Device sessions

    21. test_send_funds_between_accounts_in_multiaccount_instance, id: 6225
    Device sessions

    22. test_keycard_sign_typed_message_deploy_simple_contract, id: 6310
    Device sessions

    23. test_cant_add_more_twenty_participants_to_group_chat, id: 5721
    Device sessions

    24. test_custom_bootnodes, id: 5432
    Device sessions

    25. test_activity_center_group_chats_trusted_contacts, id: 695771
    Device sessions

    26. test_change_log_level_and_fleet, id: 5368
    Device sessions

    27. test_app_on_background_by_back_button, id: 6221
    Device sessions

    28. test_can_accept_or_reject_multiple_chats_from_activity_center, id: 695782
    Device sessions

    29. test_open_user_profile_long_press_on_message, id: 6267
    Device sessions

    30. test_keycard_frozen_card_flows, id: 695851
    Device sessions

    31. test_make_admin_member_of_group_chat, id: 5694
    Device sessions

    32. test_block_and_unblock_user_from_group_chat_via_group_info, id: 5752
    Device sessions

    33. test_creating_community_accept_membership, id: 695842
    Device sessions

    34. test_delete_cut_and_paste_messages, id: 5322
    Device sessions

    35. test_keycard_interruption_access_key_onboarding_flow, id: 6246
    Device sessions

    36. test_rename_group_chat, id: 6280
    Device sessions

    37. test_unread_messages_counter_preview_highlited_1_1_chat, id: 5362
    Device sessions

    38. test_open_user_profile_using_deep_link, id: 5441
    Device sessions

    39. test_send_eth_from_wallet_incorrect_address, id: 5461
    Device sessions

    40. test_can_reset_password, id: 695850
    Device sessions

    41. test_pair_devices_sync_photo_community_group_chats, id: 695856
    Device sessions

    42. test_disable_use_history_node, id: 6332
    Device sessions

    43. test_markdown_support_in_messages, id: 5425
    Device sessions

    44. test_nicknames_ens_group_chats, id: 6327
    Device sessions

    45. test_notification_in_activity_center_for_mention_in_community_and_group_chat, id: 695845
    Device sessions

    46. test_reply_to_message_in_chats, id: 6233
    Device sessions

    47. test_add_custom_network, id: 5431
    Device sessions

    48. test_search_asset_and_currency, id: 6269
    Device sessions

    49. test_validation_amount_errors, id: 5437
    Device sessions

    50. test_set_primary_ens_custom_domain, id: 6219
    Device sessions

    51. test_public_clear_history_via_options_and_long_press, id: 5426
    Device sessions

    52. test_can_scan_qr_with_chat_key_from_home_start_chat, id: 6298
    Device sessions

    53. test_open_dapp_using_deep_link, id: 5442
    Device sessions

    54. test_use_pinned_mailserver, id: 5766
    Device sessions

    55. test_can_delete_several_multiaccounts, id: 6318
    Device sessions

    56. test_keycard_send_eth_to_ens, id: 6295
    Device sessions

    57. test_keycard_blocked_card_lost_or_frozen_flows, id: 695852
    Device sessions

    58. test_keycard_request_and_receive_stt_in_1_1_chat_offline_opened_from_push, id: 6294
    Device sessions

    59. test_privacy_policy_terms_of_use_node_version_need_help_in_profile, id: 5453
    Device sessions

    60. test_unblocked_user_is_not_added_in_contacts, id: 6213
    Device sessions

    61. test_create_account_short_and_mismatch_password, id: 5460
    Device sessions

    62. test_back_forward_refresh_navigation_history_kept_after_relogin, id: 5395
    Device sessions

    63. test_custom_gas_settings, id: 695855
    Device sessions

    64. test_resolve_ipns_name, id: 6323
    Device sessions

    65. test_network_mismatch_for_send_request_in_1_1_chat, id: 6257
    Device sessions

    66. test_share_user_profile_url_public_chat, id: 5498
    Device sessions

    67. test_can_use_another_fleets_and_networks_advanced_set_nonce, id: 695890
    Device sessions

    68. test_receive_message_while_in_different_tab_and_emoji_messages_long_press, id: 6275
    Device sessions

    69. test_add_remove_contact_via_contacts_view, id: 6312
    Device sessions

    70. test_keycard_can_recover_keycard_account_offline_and_add_watch_only_acc, id: 6243
    Device sessions

    71. test_backup_recovery_phrase_warning_from_wallet, id: 5358
    Device sessions

    72. test_invite_friends, id: 5433
    Device sessions

    73. test_different_status_in_timeline, id: 6342
    Device sessions

    74. test_offline_can_login_cant_send_transaction, id: 5407
    Device sessions

    75. test_can_send_all_tokens_via_max_option, id: 6330
    Device sessions

    76. test_add_switch_delete_custom_mailserver, id: 5436
    Device sessions

    @churik
    Copy link
    Member

    churik commented Dec 6, 2021 •
    edited
    Loading

    @rasom

    ISSUE 1: when app is closed on group chat view, user is redirected to "Join group chat" screen after reopening app

    Steps:

    1. User A: create a group chat
    2. User A: on group chat view, close app
    3. User A: reopen app (force close / relogin)

    Expected result:
    same chat view

    Actual result:
    IMAGE 2021-12-06 14:44:00
    OS: IOS, Android

    Question 2: in case of reopening app on community channel > tap back user is redirected to main home view instead of the community page. Expected?

    It differs from tapping back when a user is on channel view and tap back without relogin, better if it will be the same in both cases to prevent different navigation for the same scenarios.

    @rasom
    Copy link
    Contributor Author

    rasom commented Dec 6, 2021

    ISSUE 1: figuring out how to fix this

    Question 2: its hard to say, if we don't plan to have community chats in the list on Home Screen then we probably should add community screen to the views stack, but as it is now is probably fine. I will check how hard is to add another screen there

    @rasom rasom force-pushed the feat/#12782-re-open-app-on-the-last-open-chat branch from 089b007 to 7ffbe4a Compare December 6, 2021 15:25
    @churik
    Copy link
    Member

    churik commented Dec 7, 2021

    @rasom
    on the last build, 7ffbe4a feature doesn't work anymore so if you reopen the app on chat view (tried with public and 1-1 chat), home view is shown

    @rasom rasom force-pushed the feat/#12782-re-open-app-on-the-last-open-chat branch 2 times, most recently from 0107adb to 49292a1 Compare December 9, 2021 09:29
    @churik
    Copy link
    Member

    churik commented Dec 15, 2021

    Awesome work!
    Checked with all types of chats, combinations of several multiaccounts, PNs, deep links (they have a priority)
    Some e2e should be fixed, will be done separately.

    Devices:

    • IPhone 12 Mini (IOS 14)
    • IPhone 7 (IOS 13)
    • Xiaomi Mi Note 9 Pro (Android 10)

    @rasom rasom force-pushed the feat/#12782-re-open-app-on-the-last-open-chat branch from 876ae13 to 646add5 Compare December 15, 2021 11:46
    @rasom rasom merged commit 646add5 into develop Dec 15, 2021
    @rasom rasom deleted the feat/#12782-re-open-app-on-the-last-open-chat branch December 15, 2021 11:46
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    @shivekkhurana shivekkhurana Awaiting requested review from shivekkhurana

    @briansztamfater briansztamfater Awaiting requested review from briansztamfater

    Assignees

    @rasom rasom

    @churik churik

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Re-open app on the last open chat
    4 participants
    @rasom @status-im-auto @churik @flexsurfer