Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#13235] Fix opening of the last shown chat with local notifications #13252

Merged
merged 1 commit into from
Apr 5, 2022
Merged

[#13235] Fix opening of the last shown chat with local notifications #13252

merged 1 commit into from
Apr 5, 2022

Conversation

rasom
Copy link
Contributor

@rasom rasom commented Apr 5, 2022

fix #13235

status: ready

@rasom rasom requested review from flexsurfer and Parveshdhull April 5, 2022 08:51
@rasom rasom self-assigned this Apr 5, 2022
@status-im-auto
Copy link
Member

status-im-auto commented Apr 5, 2022 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4036e21 #1 2022-04-05 09:01:29 ~10 min android-e2e 📦apk 📲
✔️ 4036e21 #1 2022-04-05 09:01:29 ~10 min android 📦apk 📲
✔️ 4036e21 #1 2022-04-05 09:04:28 ~13 min ios 📦ipa 📲

@pavloburykh pavloburykh self-assigned this Apr 5, 2022
@status-im-auto
Copy link
Member

97% of end-end tests have passed

Total executed tests: 67
Failed tests: 2
Passed tests: 65

IDs of failed tests: 700750,6228

Failed tests (2)

Click to expand
  • Rerun tests

    • 1. test_restore_validation_seed_phrase_field, id: 700750

    Device 1: Logging out
    Device 1: Scrolling down to LogoutButton

    Device 1: LogoutButton by accessibility id: `log-out-button` is not found on the screen

    Device sessions

    2. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: Find `Button` by `xpath`: `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: Find `Button` by `xpath`: `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Chat history was not fetched with mobile data fetching ON

    Device sessions

    Passed tests (65)

    Click to expand

    1. test_can_add_existing_ens_on_mainnet, id: 5502
    Device sessions

    2. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    3. test_public_chat_message_edit, id: 700734
    Device sessions

    4. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843
    Device sessions

    5. test_keycard_relogin_after_restore, id: 700768
    Device sessions

    6. test_group_chat_push_system_messages_when_invited, id: 3994
    Device sessions

    7. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    8. test_send_tx_token_7_decimals, id: 700764
    Device sessions

    9. test_public_chat_open_using_deep_link, id: 700739
    Device sessions

    10. test_public_chat_unread_messages_counter, id: 5360
    Device sessions

    11. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265
    Device sessions

    12. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    13. test_public_chat_emoji_send_copy_paste_reply, id: 700719
    Device sessions

    14. test_browser_bookmarks_create_edit_remove (TestRail link is not found)
    Device sessions

    15. test_send_tx_eth_check_logcat, id: 700763
    Device sessions

    16. test_1_1_chat_command_send_eth_outgoing_tx_push, id: 6253
    Device sessions

    17. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718
    Device sessions

    18. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765
    Device sessions

    19. test_public_chat_delete_chat_long_press, id: 5319
    Device sessions

    20. test_browser_blocked_url (TestRail link is not found)
    Device sessions

    21. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    22. test_1_1_chat_message_reaction, id: 6315
    Device sessions

    23. test_block_user_from_public_chat, id: 5786
    Device sessions

    24. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769
    Device sessions

    25. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    26. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    27. test_1_1_chat_image_send_save_reply, id: 6305
    Device sessions

    28. test_1_1_chat_emoji_and_link_send_and_open, id: 5373
    Device sessions

    29. test_public_chat_link_send_open, id: 700736
    Device sessions

    30. test_restore_set_up_wallet_sign_phrase, id: 700749
    Device sessions

    31. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310
    Device sessions

    32. test_browser_delete_close_tabs (TestRail link is not found)
    Device sessions

    33. test_public_chat_mark_all_messages_as_read, id: 6270
    Device sessions

    34. test_browser_connection_is_secure_not_secure_warning (TestRail link is not found)
    Device sessions

    35. test_send_tx_set_recipient_options, id: 700757
    Device sessions

    36. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342
    Device sessions

    37. test_group_chat_join_send_text_messages_push, id: 700731
    Device sessions

    38. test_browser_web3_permissions_testdapp (TestRail link is not found)
    Device sessions

    39. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    40. test_1_1_chat_text_message_with_push, id: 6316
    Device sessions

    41. test_group_chat_decline_invite_chat_highligted, id: 5756
    Device sessions

    42. test_set_profile_picture, id: 6646
    Device sessions

    43. test_public_chat_tag_message, id: 700738
    Device sessions

    44. test_keycard_create_account_unlock_same_seed, id: 5689
    Device sessions

    45. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
    Device sessions

    46. test_1_1_chat_command_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    47. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317
    Device sessions

    48. test_public_chat_fetch_more_history, id: 5675
    Device sessions

    49. test_group_chat_offline_pn, id: 3998
    Device sessions

    50. test_group_chat_add_new_member_activity_centre, id: 700732
    Device sessions

    51. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
    Device sessions

    52. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315
    Device sessions

    53. test_keycard_send_tx_eth, id: 700767
    Device sessions

    54. test_browser_offline (TestRail link is not found)
    Device sessions

    55. test_browser_invalid_url (TestRail link is not found)
    Device sessions

    56. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    57. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
    Device sessions

    58. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313
    Device sessions

    59. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    60. test_1_1_chat_delete_via_delete_button_relogin, id: 5387
    Device sessions

    61. test_group_chat_leave_relogin, id: 3997
    Device sessions

    62. test_public_chat_message_delete, id: 700735
    Device sessions

    63. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    64. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
    Device sessions

    65. test_1_1_chat_push_emoji, id: 6283
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    @rasom thanks. ready for merge.

    @rasom rasom merged commit 4036e21 into develop Apr 5, 2022
    @rasom rasom deleted the fix/#13235-last-open-chat-with-local-notifications branch April 5, 2022 13:25
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @flexsurfer flexsurfer Awaiting requested review from flexsurfer

    Assignees

    @rasom rasom

    @pavloburykh pavloburykh

    Labels
    Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Last open chat does not open after app re-opening when local notifications are enabled (Android)
    4 participants
    @rasom @status-im-auto @pavloburykh @Parveshdhull