Reply component in chat input & quoted messages redesign #13706
Conversation
Jenkins BuildsClick to see older builds (18)
|
briansztamfater
changed the title
briansztamfater
force-pushed
the
feat/reply-redesign
branch
from
5b288d5 to
5f48df3
Compare
51% of end-end tests have passedNot executed tests (3)Failed tests (41)Click to expand
Passed tests (43)Click to expand
|
|
@briansztamfater thanx for the PR. Please take a look at following issue: ISSUE 1 Invalid arity: 1 error when calling dropdown with usernames by typing @ in chats (1-1/public/group)Steps:
Actual result: Invalid arity: 1 error appears. telegram-cloud-document-2-5422493586698541860.mp4Expected result: dropdown with chat users appears. OS: IOS/Android |
|
Hi @pavloburykh, thanks for pointing out the issue! It should be fixed now :) |
Great, thanx for the fix @briansztamfater Is PR ready for testing? I see that it is still in contributor column and has changes requested status. |
|
@pavloburykh should be ready, if @ibrkhalil does not have any other comments we can continue with testing |
98% of end-end tests have passedFailed tests (2)Click to expandClass TestOneToOneChatMultipleSharedDevices:
Class TestRestoreOneDeviceMerged:
Passed tests (85)Click to expandClass TestPublicChatMultipleDeviceMerged:
Class TestRestoreOneDeviceMerged:
Class TestEnsStickersMultipleDevicesMerged:
Class TestSendTxDeviceMerged:
Class TestPairingSyncMultipleDevicesMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestGroupChatMultipleDeviceMerged:
Class TestOnboardingOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevices:
Class TestWalletManagementDeviceMerged:
Class TestKeycardTxOneDeviceMerged:
Class TestPublicChatBrowserOneDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
|
65% of end-end tests have passedNot executed tests (3)Failed tests (29)Click to expand
Passed tests (55)Click to expand
|
83% of end-end tests have passedFailed tests (5)Click to expandClass TestSendTxDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestPairingSyncMultipleDevicesMerged:
Class TestRestoreOneDeviceMerged:
Class TestKeycardTxOneDeviceMerged:
Passed tests (24)Click to expandClass TestWalletManagementDeviceMerged:
Class TestEnsStickersMultipleDevicesMerged:
Class TestSendTxDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestPairingSyncMultipleDevicesMerged:
Class TestPublicChatBrowserOneDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestKeycardTxOneDeviceMerged:
|
Go for it |
80% of end-end tests have passedFailed tests (1)Click to expandClass TestRestoreOneDeviceMerged:
Passed tests (4)Click to expandClass TestSendTxDeviceMerged:
Class TestKeycardTxOneDeviceMerged:
Class TestPairingSyncMultipleDevicesMerged:
Class TestCommandsMultipleDevicesMerged:
|
|
@briansztamfater thanx. Tested and for merge. |
| constants/content-type-audio "Audio" | ||
| (get-quoted-text-with-mentions (or parsed-text (:parsed-text content))))]]] | ||
| (when in-chat-input? | ||
| [rn/view |
|
@briansztamfater does PR need to be re tested due to new commit? |
Yes please, smoke testing should fine, the change was super minor |
99% of end-end tests have passedFailed tests (1)Click to expandClass TestSendTxDeviceMerged:
Passed tests (86)Click to expandClass TestKeycardTxOneDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestGroupChatMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevices:
Class TestPairingSyncMultipleDevicesMerged:
Class TestRestoreOneDeviceMerged:
Class TestPublicChatMultipleDeviceMerged:
Class TestWalletManagementDeviceMerged:
Class TestSendTxDeviceMerged:
Class TestOnboardingOneDeviceMerged:
Class TestPublicChatBrowserOneDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestEnsStickersMultipleDevicesMerged:
|
100% of end-end tests have passedPassed tests (1)Click to expandClass TestSendTxDeviceMerged:
|
|
@briansztamfater I've re-ran e2e and made manual smoke tests. Looks good to me, no regression for old UI was found. |
Signed-off-by: Brian Sztamfater <[email protected]>
briansztamfater
force-pushed
the
feat/reply-redesign
branch
from
91e5405 to
647dfc7
Compare
fixes #13538 #13539
Summary
Redesign of reply component in chat input and quoted / replied messages
Testing notes
Platforms
Functional
Steps to test
Open Status
Open a chat
Reply a message
Open Status
Open a chat
See a replied message in a chat
status: ready