-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#13894] Update activity indicator on removed contact request #13902
[#13894] Update activity indicator on removed contact request #13902
Conversation
fc2f860
to
64c89d5
Compare
Jenkins BuildsClick to see older builds (19)
|
79% of end-end tests have passed
Failed tests (18)Click to expandClass TestOnboardingOneDeviceMerged:
Class TestKeycardTxOneDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestCommandsMultipleDevicesMerged:
Class TestEnsStickersMultipleDevicesMerged:
Class TestSendTxDeviceMerged:
Class TestPairingSyncMultipleDevicesMerged:
Passed tests (69)Click to expandClass TestRestoreOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevices:
Class TestOnboardingOneDeviceMerged:
Class TestPublicChatBrowserOneDeviceMerged:
Class TestPublicChatMultipleDeviceMerged:
Class TestWalletManagementDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestKeycardTxOneDeviceMerged:
Class TestEnsStickersMultipleDevicesMerged:
Class TestSendTxDeviceMerged:
Class TestGroupChatMultipleDeviceMerged:
|
5e504ea
to
50198b1
Compare
@rasom hi! Could you please rebase this branch to latest develop? Thanx! |
50198b1
to
148b94c
Compare
@rasom thanx for the fix. Please, take a look at another case below, we might want to handle it by this PR. Let me know if you want me to log a separate issue for that. ISSUE 1 Unread indicator remains on activity centre if message was removed by senderIf sending and then removing the very first message to a user without opening activity center by the receiver, the activity center unread indicator remains despite that there are no unread messages. It also remains after re-login. Preconditions: User A and User B are not contacts and do not have any active 1-1 chats yet
Actual result: unread indicator remains for User B although activity center is empty. Another issue is that in such case another messages sent by User A will not trigger unread indicator in activity center for User B. unread_indicator_ac.mp4Expected result: no unread indicator |
logged a separate issue for above case #13933 |
100% of end-end tests have passed
Passed tests (18)Click to expandClass TestSendTxDeviceMerged:
Class TestPairingSyncMultipleDevicesMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestOnboardingOneDeviceMerged:
Class TestEnsStickersMultipleDevicesMerged:
Class TestKeycardTxOneDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
|
148b94c
to
0dcd572
Compare
0dcd572
to
b9015c5
Compare
fix #13894
status: ready