Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: upgrade Xcode from 14.2 to 14.3 #15581

Merged
merged 1 commit into from
Apr 19, 2023
Merged

ci: upgrade Xcode from 14.2 to 14.3 #15581

merged 1 commit into from
Apr 19, 2023

Conversation

jakubgs
Copy link
Member

@jakubgs jakubgs commented Apr 5, 2023 •
edited
Loading

@jakubgs jakubgs self-assigned this Apr 5, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Apr 5, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (24)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ af6df57 #1 2023-04-05 11:31:01 ~4 min ios 📄log
✔️ af6df57 #1 2023-04-05 11:32:28 ~6 min tests 📄log
✔️ af6df57 #1 2023-04-05 11:34:41 ~8 min android-e2e 🤖apk 📲
✔️ af6df57 #1 2023-04-05 11:35:15 ~9 min android 🤖apk 📲
❌ be16db9 #2 2023-04-05 12:01:13 ~2 min ios 📄log
✔️ be16db9 #2 2023-04-05 12:05:29 ~6 min tests 📄log
✔️ be16db9 #2 2023-04-05 12:06:30 ~7 min android-e2e 🤖apk 📲
✔️ be16db9 #2 2023-04-05 12:06:41 ~7 min android 🤖apk 📲
✔️ ea93291 #3 2023-04-06 11:40:27 ~6 min tests 📄log
✔️ ea93291 #3 2023-04-06 11:40:54 ~7 min ios 📱ipa 📲
✔️ ea93291 #3 2023-04-06 11:41:30 ~7 min android 🤖apk 📲
✔️ ea93291 #3 2023-04-06 11:42:32 ~8 min android-e2e 🤖apk 📲
✔️ 8ebda03 #4 2023-04-06 12:03:54 ~7 min tests 📄log
✔️ 8ebda03 #4 2023-04-06 12:04:03 ~7 min ios 📱ipa 📲
✔️ 8ebda03 #4 2023-04-06 12:04:37 ~7 min android 🤖apk 📲
✔️ 8ebda03 #4 2023-04-06 12:05:17 ~8 min android-e2e 🤖apk 📲
✔️ 95df228 #5 2023-04-17 16:45:05 ~6 min android-e2e 🤖apk 📲
✔️ 95df228 #5 2023-04-17 16:45:30 ~6 min android 🤖apk 📲
✔️ 95df228 #5 2023-04-17 16:45:46 ~6 min tests 📄log
✔️ 95df228 #5 2023-04-17 16:56:39 ~17 min ios 📱ipa 📲
✔️ c12c780 #6 2023-04-19 10:55:16 ~5 min android 🤖apk 📲
✔️ c12c780 #6 2023-04-19 10:56:14 ~6 min android-e2e 🤖apk 📲
✔️ c12c780 #6 2023-04-19 10:57:02 ~7 min ios 📱ipa 📲
✔️ c12c780 #6 2023-04-19 10:58:28 ~8 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 40cce75 #7 2023-04-19 13:33:51 ~5 min tests 📄log
✔️ 40cce75 #7 2023-04-19 13:34:33 ~6 min ios 📱ipa 📲
✔️ 40cce75 #7 2023-04-19 13:34:35 ~6 min android-e2e 🤖apk 📲
✔️ 40cce75 #7 2023-04-19 13:34:35 ~6 min android 🤖apk 📲
✔️ 40bb07a #8 2023-04-19 17:16:38 ~5 min android 🤖apk 📲
✔️ 40bb07a #8 2023-04-19 17:18:34 ~7 min android-e2e 🤖apk 📲
✔️ 40bb07a #8 2023-04-19 17:18:35 ~7 min tests 📄log
✔️ 40bb07a #8 2023-04-19 17:23:04 ~11 min ios 📱ipa 📲

@jakubgs
Copy link
Member Author

jakubgs commented Apr 5, 2023 •
edited
Loading

And it looks like iOS build explodes due to:

❌  /Users/jenkins/workspace/status-mobile_prs_ios_PR-15581/node_modules/react-native/ReactCommon/yoga/yoga/Yoga.cpp:2285:9: use of bitwise '|' with boolean operands [-Werror,-Wbitwise-instead-of-logical]

        node->getLayout().hadOverflow() |
                   ^~~~~~~

Which appears to have been fixed in Yoga already:

And there's no releases with this fix included. Last 1.19.0 release is from May of 2021.

@siddarthkay
Copy link
Contributor

siddarthkay commented Apr 5, 2023 •
edited
Loading

A fix for Xcode 14.3 was probably patched yesterday in react-native 0.69.9 : https://github.com/facebook/react-native/releases/tag/v0.69.9
and other newer versions 0.70 and 0.71
not sure if its related to this error

@jakubgs
Copy link
Member Author

jakubgs commented Apr 6, 2023

Thanks to this fix we can now try to proceed:

@jakubgs jakubgs marked this pull request as ready for review April 6, 2023 11:42
@jakubgs jakubgs requested review from cammellos and flexsurfer April 6, 2023 11:53
@status-im-auto
Copy link
Member

93% of end-end tests have passed

Total executed tests: 29
Failed tests: 2
Passed tests: 27

IDs of failed tests: 702850,702838

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Find `Username` by `xpath`: `//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/android.view.ViewGroup/android.widget.TextView[1]`
    Device 2: `Username` is `test user` 

    critical/test_public_chat_browsing.py:421: in test_community_message_send_check_timestamps_sender_username
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Timestamp is not shown, expected: '9:42 AM, 9:41 AM, 9:40 AM', in fact: '9:39 AM'

    [[blocked by 14797]]

    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 2: Find Button by accessibility id: tab-recent
    Device 2: Tap on found: Button 

    medium/test_activity_center.py:142: in test_activity_center_contact_request_decline
    self.errors.verify_no_errors()
base_test_case.py:184: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Username is not shown on 'Add contact' page after entering valid public key

    [[Blocked by 15500]]

    Device sessions

    Passed tests (27)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_leave, id: 702845
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    @jakubgs
    Copy link
    Member Author

    jakubgs commented Apr 17, 2023

    I believe we are putting this on-hold until the release is out. Unless for some reason we want Xcode 14.3 for the 1.23 release.

    @churik
    Copy link
    Member

    churik commented Apr 19, 2023

    The next release is planned for the end of May, so I believe we're ready to go - 1.22 is already out

    @jakubgs jakubgs merged commit 40bb07a into develop Apr 19, 2023
    @jakubgs jakubgs deleted the ci/xcode-14.3 branch April 19, 2023 17:29
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    @cammellos cammellos cammellos approved these changes

    Assignees

    @jakubgs jakubgs

    Labels
    infra ios
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @jakubgs @status-im-auto @siddarthkay @churik @cammellos @flexsurfer