feat: implement audio message component #15594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (91)
|
briansztamfater
force-pushed
the
feat/audio-message-component
branch
2 times, most recently
from
a19692f to
97d5aec
Compare
briansztamfater
force-pushed
the
feat/audio-message-component
branch
4 times, most recently
from
f6bd97b to
4570164
Compare
briansztamfater
force-pushed
the
feat/audio-message-component
branch
4 times, most recently
from
7c4f809 to
3fd7424
Compare
briansztamfater
changed the title
briansztamfater
force-pushed
the
feat/audio-message-component
branch
from
3fd7424 to
9d844f9
Compare
briansztamfater
force-pushed
the
feat/audio-message-component
branch
from
9d844f9 to
29bfef7
Compare
briansztamfater
requested review from
ilmotta,
erikseppanen,
flexsurfer,
yqrashawn,
smohamedjavid,
ulisesmac,
cammellos and
J-Son89
ilmotta
reviewed
Apr 26, 2023
| [react-native.audio-toolkit :as audio] | ||
| [re-frame.core :as re-frame])) | ||
|
|
||
| (defonce message |
There was a problem hiding this comment.
@briansztamfater, defonce is unnecessary in pure maps, since they never change.
| (defn audio-message | ||
| [message context] | ||
| (let [player-state (reagent/atom :not-loaded) | ||
| progress (reagent/atom 0) |
There was a problem hiding this comment.
@briansztamfater, I see progress is passed along in this file to other functions and it's named as progress-ref, even though it's not a ref. Refs are non-reactive and usually start as (atom nil). If that makes sense, could you rename all instances of progress-ref to just progress, for example? I was confused by the suffix ref when it's a reactive state :)
| #(update-state player-state :error))))) | ||
| (update-state player-state :preparing)) | ||
|
|
||
| (defn play-pause-player |
There was a problem hiding this comment.
I see you tried to separate some of the state management outside the f-audio-message component, but still @briansztamfater, I'd just like to share some thoughts or suggestions.
- A very good chunk of this namespace is not concerned or doesn't need to know about hiccup, reagent, etc, it's just raw timers and manipulation of atoms. In my experience in other React projects, this is a perfect candidate for a separate hook with good unit tests.
- HTTP effects should happen at re-frame's event layer, ideally.
- If we so desire to reduce usages of
use-effect, we can also extract the whole state management into re-frame. Of course this is not a trivial task since the code is already written in the style of hooks, but it could lead to the best results.
But to summarize, I think the effectful part should exist as a separate hook, even outside this file, for example in content/audio/hooks.cljs and unit tested.
There was a problem hiding this comment.
@ilmotta As always, thanks for your valuable feedback, and agree with them. As I have another ongoing time consuming task and given that manual testing went fine, I wanted to merge this PR, and created an issue to keep track of this suggestion 👍 #15816
Will make sure to address it as soon as possible!
There was a problem hiding this comment.
Thank you for taking the time to create the issue @briansztamfater. I would have done the same, priorities first :)
ilmotta
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Nicely done @briansztamfater 🚀! I left some comments I feel are important, but they're not blockers.
briansztamfater
force-pushed
the
feat/audio-message-component
branch
from
c0d3995 to
b88e2c7
Compare
churik
force-pushed
the
feat/audio-message-component
branch
from
700636c to
d290a6f
Compare
jo-mut
approved these changes
May 2, 2023
93% of end-end tests have passedFailed tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Passed tests (28)Click to expandClass TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
|
LGTM, @briansztamfater thanks for your work! |
Signed-off-by: Brian Sztamfater <[email protected]>
briansztamfater
force-pushed
the
feat/audio-message-component
branch
from
d290a6f to
e5913cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #13530 #15536
Summary
Audio message component implementation
Screenshots
Testing notes
In #13530, these items were listed to be resolved. Those not checked should be worked separately in follow up issues / PRs.
Should be implemented separately:
Platforms
Areas that maybe impacted
Functional
Steps to test
status: ready