nix: add ios-deploy package to ios shell #15699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (41)
|
siddarthkay
approved these changes
Apr 20, 2023
jakubgs
force-pushed
the
nix/add-ios-deploy
branch
from
911749a to
1e5493a
Compare
|
It works: |
jakubgs
force-pushed
the
nix/add-ios-deploy
branch
from
1e5493a to
fecd809
Compare
|
I'm getting some weird And they appear to be specific to Xcode 14.3: |
|
Xcode 14.3 appears to be missing ``: |
|
I found this workaround in # On Darwin, using clang 6 to build fails because of a linker error (see #105573),
# but using clang 7 fails because libarclite_macosx.a cannot be found when linking
# the xcode_locator tool.
# This patch removes using the -fobjc-arc compiler option and makes the code
# compile without automatic reference counting. Caveat: this leaks memory, but
# we accept this fact because xcode_locator is only a short-lived process used during the build.
(substituteAll {
src = ./no-arc.patch;
multiBinPatch = if stdenv.hostPlatform.system == "aarch64-darwin" then "arm64" else "x86_64";
})Maybe we can use this |
|
And I can't copy the files from Xcode 14.2 into Xcode 14.3 because OSX me from modifying the Xcode directory: |
jakubgs
force-pushed
the
nix/add-ios-deploy
branch
7 times, most recently
from
5564115 to
c4bd20d
Compare
|
Looks like my workaround is the actual fix in the package: ios-control/ios-deploy@bbd951d But it appears the |
jakubgs
force-pushed
the
nix/add-ios-deploy
branch
from
c4bd20d to
63ae9b8
Compare
Also adds an assertion that gives a better error when trying to use an `ios` Nix shell on an unsupported operating system. Resolves: #15695 Signed-off-by: Jakub Sokołowski <[email protected]>
jakubgs
force-pushed
the
nix/add-ios-deploy
branch
from
63ae9b8 to
3e8647d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds an assertion that gives a better error when trying to use an
iosNix shell on an unsupported operating system.Resolves:
ios-deployand install on systems that runmake run-ios-deviceif not present. #15695