-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix UI freeze issue #15761
fix UI freeze issue #15761
Conversation
Jenkins BuildsClick to see older builds (2)
|
4489804
to
edeb851
Compare
88% of end-end tests have passed
Not executed tests (5)Failed tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (22)Click to expandClass TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
|
return useDerivedValue( | ||
function () { | ||
'worklet' | ||
return selectedStackId.value == stackId ? "auto" : "none"; | ||
return selectedStackId.value == stackId ? 10 : 9; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems like something that might benefit from having a comment explaining. Or at least put 10
and 9
in some variables that describe what is going on here.
Curious of why you selected 10 and 9? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious of why you selected 10 and 9?
Because, 10 > 9, no particular reason :)
Docs: https://reactnative.dev/docs/layout-props#zindex
Mighty z-index: https://www.digitalocean.com/community/tutorials/css-z-index
Somewhat related Discussions:
#13620 (comment)
#13620 (comment)
this seems like something that might benefit from having a comment explaining. Or at least put 10 and 9 in some variables that describe what is going on here.
suggestions are welcome
|
0% of end-end tests have passed
Not executed tests (5)Failed tests (25)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
|
edeb851
to
b0fe8f1
Compare
fixes #15310
Summary
Pointer events not working well once view recreated using hot-reload. Actually UI not freezing only allowing touch events on wrong screen. (More details)
status: ready