Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pin image in community leads to error #16017

Merged
merged 1 commit into from
May 25, 2023

Conversation

Parveshdhull
Copy link
Member

fixes: #16008

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented May 24, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6396fe8 #1 2023-05-24 18:45:34 ~6 min ios 📱ipa 📲
✔️ 6396fe8 #1 2023-05-24 18:45:34 ~6 min android-e2e 🤖apk 📲
✔️ 6396fe8 #1 2023-05-24 18:45:40 ~6 min android 🤖apk 📲
✔️ 6396fe8 #1 2023-05-24 18:47:35 ~8 min tests 📄log
✔️ 708741a #2 2023-05-24 19:47:51 ~5 min android 🤖apk 📲
✔️ 708741a #2 2023-05-24 19:48:40 ~6 min android-e2e 🤖apk 📲
✔️ 708741a #2 2023-05-24 19:50:29 ~8 min ios 📱ipa 📲
✔️ 708741a #2 2023-05-24 19:50:59 ~8 min tests 📄log

@status-im-auto
Copy link
Member

97% of end-end tests have passed

Total executed tests: 33
Failed tests: 1
Passed tests: 32
IDs of failed tests: 702838 

Failed tests (1)

Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Verifying that 'hello' is under today
    Device 2: Looking for a message by text: hello

    critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
        channel.verify_message_is_under_today_text(message, self.errors)
    ../views/chat_view.py:944: in verify_message_is_under_today_text
        message_element.wait_for_visibility_of_element()
    ../views/base_element.py:135: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element 
    

    [[blocked by 14797]]

    Device sessions

    Passed tests (32)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    2. test_1_1_chat_edit_message, id: 702855
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    9. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_navigation_jump_to, id: 702936
    Device sessions

    4. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    3. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_several_images_send_reply, id: 703194
    Device sessions

    3. test_community_one_image_send_reply, id: 702859
    Device sessions

    4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    5. test_community_mentions_push_notification, id: 702786
    Device sessions

    6. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    7. test_community_leave, id: 702845
    Device sessions

    8. test_community_unread_messages_badge, id: 702841
    Device sessions

    9. test_community_message_delete, id: 702839
    Device sessions

    10. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    11. test_community_message_edit, id: 702843
    Device sessions

    @Parveshdhull Parveshdhull force-pushed the fix/community-pin-message branch from 6396fe8 to 708741a Compare May 24, 2023 19:41
    @status-im status-im deleted a comment from status-im-auto May 25, 2023
    @churik
    Copy link
    Member

    churik commented May 25, 2023

    Thanks for your amazing work!
    e2e failures are known not related to PR.
    Tested basic flows, LGTM!

    Devices:

    • IPhone 12 Mini (IOS 16)
    • Xiaomi Mi Note 9 Pro (Android 10)
    • BlackView BV5200 Pro (Android 12)

    @Parveshdhull Parveshdhull merged commit b7cc54a into develop May 25, 2023
    @Parveshdhull Parveshdhull deleted the fix/community-pin-message branch May 25, 2023 08:31
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    No open projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    Pin image or emoji in community channel leads to error and unusable mobile app
    5 participants