Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#16691 fix navigation to community from discover communities screen #16702

Merged
merged 1 commit into from
Jul 17, 2023
Merged

#16691 fix navigation to community from discover communities screen #16702

merged 1 commit into from
Jul 17, 2023

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Jul 17, 2023 •
edited
Loading

fixes: #16691

Summary

Community is opening from the discover communities screen but it's hidden behind. The quickest solution is to close the discover communities screen while opening the community (handled by :communities/navigate-to-community). Later we can either embed a floating screen inside the discover communities screen or better make the discover community screen itself use shell navigation, so jump-to animation works nicely.
will be implemented in: #16701

status: ready

@Parveshdhull Parveshdhull self-assigned this Jul 17, 2023
@Parveshdhull Parveshdhull requested a review from cammellos July 17, 2023 06:23
@status-im-auto
Copy link
Member

status-im-auto commented Jul 17, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c06c18c #1 2023-07-17 06:27:42 ~7 min android-e2e 🤖apk 📲
✔️ c06c18c #1 2023-07-17 06:27:45 ~7 min android 🤖apk 📲
✔️ c06c18c #1 2023-07-17 06:28:55 ~8 min tests 📄log
✔️ c06c18c #1 2023-07-17 06:38:08 ~17 min ios 📱ipa 📲

@status-im-auto
Copy link
Member

89% of end-end tests have passed

Total executed tests: 36
Failed tests: 4
Passed tests: 32

IDs of failed tests: 702731,702732,703133,703202

Failed tests (4)

Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 
    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_reactions, id: 703202

    Device 3: Wait for text element EmojisNumber to be equal to 1
    Device 3: Find EmojisNumber by xpath: //*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-1']/android.widget.TextView 

    critical/chats/test_group_chat.py:251: in test_group_chat_reactions
    message_element.emojis_below_message(emoji="love").wait_for_element_text(1)
../views/base_element.py:152: in wait_for_element_text
    text_element = self.find_element().text
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 3: EmojisNumber by xpath: `//*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-1']/android.widget.TextView` is not found on the screen



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find Button by accessibility id: show-profiles
    Device 1: Tap on found: Button 

    critical/test_public_chat_browsing.py:433: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Contact(s) was (were) not restored from backup: MyCustomNickname!



    Device sessions

    Passed tests (32)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_one_image_send_reply, id: 702859
    Device sessions

    2. test_community_message_edit, id: 702843
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    5. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    6. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_several_images_send_reply, id: 703194
    Device sessions

    9. test_community_leave, id: 702845
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    11. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    12. test_community_message_delete, id: 702839
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    4. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    5. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    8. test_1_1_chat_edit_message, id: 702855
    Device sessions

    9. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    3. test_activity_center_mentions, id: 702957
    Device sessions

    4. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    smohamedjavid
    smohamedjavid approved these changes Jul 17, 2023
    View reviewed changes
    Copy link
    Member

    @smohamedjavid smohamedjavid left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks Good! 🚀 This fixes the issue.

    I believe once design system confirms the opening navigation animation, we need to implement it.
    Because, right now, the navigation animation looks bit off.

    RPReplay_Final1689578706.MP4

    @churik churik self-assigned this Jul 17, 2023
    @churik
    Copy link
    Member

    churik commented Jul 17, 2023

    Not possible to reproduce performance issue mentioned in #16691 as the flow redirects to community screen as it is supposed.
    Thanks you for the fix @Parveshdhull !

    @Parveshdhull Parveshdhull merged commit bb3b306 into develop Jul 17, 2023
    @Parveshdhull Parveshdhull deleted the fix/discover-communities-navigation branch July 17, 2023 08:26
    Parveshdhull added a commit that referenced this pull request Jul 17, 2023
    @Parveshdhull
    fix navigation to community from discover communities screen (#16702)
    7e9f3fd
    @tumanov-alex tumanov-alex mentioned this pull request Aug 3, 2023
    Closed
    J-Son89 pushed a commit that referenced this pull request Aug 8, 2023
    @tumanov-alex @J-Son89
    Add transaction_sheet
    40a7c8a 
    Add locked input component, tests, styles
Add translations
Add duration icons

Remove extra code

Use theme from context

Add missing code

Update styles
Update gas icon (previous was not reacting to size change)
Use text from components instead of rn/text

Fix styling for transaction sheet preview, locked input & account selector components
Fix purple 50 color since it doesn't match design

Work on PR suggestions
Fix style to be pixel-perfect

Comment-in tests

Fix style

Add docs for locked-input component

Remove extra code

Fixed design discrepancies

Fix font-weight

Fix purple color in account selector

Remove unused icons

Fix linter

Fix tests

fix for airplane mode

[161108] Optimize message styling when there's multiple mentions on top of each other (#16505)

Fix failing mute till test (#16453)

fix navigation to community from discover communities screen (#16702)

Update version to 0.162.3

[#16703] The display name is not resolved in chats for user sender after relogin (#16704)

Mute community

* mute and unmute community

status-im/status-go@dfdaa72...e6187ae

* mute and unmute community and all community chats

status-im/status-go@dfdaa72...3abc86e

* updated statu-go

status-im/status-go@dfdaa72...919123e

* refactored mute chat drawer

status-im/status-go@d3e650d...3af0b17

* refactored mute chat drawer

status-im/status-go@dfdaa72...3af0b17

* fixing mute channels

* fixed mute community channels

* update community chats mute status

status-im/status-go@dfdaa72...dc50ac2

* added mute and unmute community toast

status-im/status-go@dfdaa72...c06f7a6

* unmute community when atleast one community channel is unmuted

status-im/status-go@dfdaa72...e691c47

* updated status-go

status-im/status-go@b2e56f5...c52718c

* updated status-go version v0.162.5

[Fix] Scroll to bottom on editing message (#16630)

This commit fixes (by skipping) the scroll to the bottom of messages when the user edits a message and sends it.

Signed-off-by: Mohamed Javid <[email protected]>

Refactor `Bottom Sheet` to use Theme Context (#16710)

This commit updates "Bottom Sheet" to use the theme (for theme provider) provided on the bottom sheet args when dispatching. This will ensure the theme is passed down to its child components where it can consume and render based on the theme.

Changes done:

In Bottom Sheet:
 - Fix Bottom Sheet to use the correct background colour (neutral-95) for dark mode (as per Figma)
 - Fix the Icon colour for danger in light mode
 - Updated Quo2 Preview to provide an option for the bottom sheet theme

In Action Drawer:
 - Refactor the Action Drawer component to consume theme context

Signed-off-by: Mohamed Javid <[email protected]>

Revert extra commits

Revert extra commits

Revert extra changes
    J-Son89 pushed a commit that referenced this pull request Aug 8, 2023
    @tumanov-alex @J-Son89
    Add transaction_sheet
    02f8fce 
    Add locked input component, tests, styles
Add translations
Add duration icons

Remove extra code

Use theme from context

Add missing code

Update styles
Update gas icon (previous was not reacting to size change)
Use text from components instead of rn/text

Fix styling for transaction sheet preview, locked input & account selector components
Fix purple 50 color since it doesn't match design

Work on PR suggestions
Fix style to be pixel-perfect

Comment-in tests

Fix style

Add docs for locked-input component

Remove extra code

Fixed design discrepancies

Fix font-weight

Fix purple color in account selector

Remove unused icons

Fix linter

Fix tests

fix for airplane mode

[161108] Optimize message styling when there's multiple mentions on top of each other (#16505)

Fix failing mute till test (#16453)

fix navigation to community from discover communities screen (#16702)

Update version to 0.162.3

[#16703] The display name is not resolved in chats for user sender after relogin (#16704)

Mute community

* mute and unmute community

status-im/status-go@dfdaa72...e6187ae

* mute and unmute community and all community chats

status-im/status-go@dfdaa72...3abc86e

* updated statu-go

status-im/status-go@dfdaa72...919123e

* refactored mute chat drawer

status-im/status-go@d3e650d...3af0b17

* refactored mute chat drawer

status-im/status-go@dfdaa72...3af0b17

* fixing mute channels

* fixed mute community channels

* update community chats mute status

status-im/status-go@dfdaa72...dc50ac2

* added mute and unmute community toast

status-im/status-go@dfdaa72...c06f7a6

* unmute community when atleast one community channel is unmuted

status-im/status-go@dfdaa72...e691c47

* updated status-go

status-im/status-go@b2e56f5...c52718c

* updated status-go version v0.162.5

[Fix] Scroll to bottom on editing message (#16630)

This commit fixes (by skipping) the scroll to the bottom of messages when the user edits a message and sends it.

Signed-off-by: Mohamed Javid <[email protected]>

Refactor `Bottom Sheet` to use Theme Context (#16710)

This commit updates "Bottom Sheet" to use the theme (for theme provider) provided on the bottom sheet args when dispatching. This will ensure the theme is passed down to its child components where it can consume and render based on the theme.

Changes done:

In Bottom Sheet:
 - Fix Bottom Sheet to use the correct background colour (neutral-95) for dark mode (as per Figma)
 - Fix the Icon colour for danger in light mode
 - Updated Quo2 Preview to provide an option for the bottom sheet theme

In Action Drawer:
 - Refactor the Action Drawer component to consume theme context

Signed-off-by: Mohamed Javid <[email protected]>

Revert extra commits

Revert extra commits

Revert extra changes
    @Parveshdhull Parveshdhull mentioned this pull request Oct 9, 2023
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ibrkhalil ibrkhalil ibrkhalil approved these changes

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    @cammellos cammellos Awaiting requested review from cammellos

    Assignees

    @churik churik

    @Parveshdhull Parveshdhull

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Communities form Discover communities screen cannot be opened and causing performance issues
    5 participants
    @Parveshdhull @status-im-auto @churik @smohamedjavid @ibrkhalil