-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
discard backup message when recovering account #16748
discard backup message when recovering account #16748
Conversation
Jenkins BuildsClick to see older builds (8)
|
86% of end-end tests have passed
Not executed tests (3)Failed tests (5)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (31)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
|
798018e
to
571e96a
Compare
Unfortuanately, the flow "recover with keycard" is not implemented in re-designed app, so I can't verify it. ISSUE 1: unable to restore a multiaccount from seed on IOSSteps:
Actual result: OS: IOS |
Hi @churik , issue 1 should be relate to this commit id which include |
if it's not implemented in re-designed app, maybe we can just merge it so that building status-mobile won't get blocked. but before merge it , we have to fix issue 1 , could you help take a look? @saledjenic or i may take a deep look tomorrow. |
@qfrank I haven't ever run the iOS app, don't have an environment set for it to check. For the desktop app all went well, also looking at this script cannot see anything problematic. |
f32f64d
to
6640d47
Compare
this PR aligned with PR
Testing notes
recovery account using keycard should works as before, pls attach debug logs if it works as before so i can check configuration passed correctly, thanks!
Platforms
status: ready