Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement activity logs photos component #16760

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Implement activity logs photos component #16760

merged 1 commit into from
Jul 24, 2023

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull self-assigned this Jul 24, 2023
Parveshdhull
Parveshdhull commented Jul 24, 2023
View reviewed changes
src/status_im2/contexts/quo_preview/list_items/preview_lists.cljs
Comment on lines -43 to -45
{:source (resources/get-mock-image :photo4)}
{:source (resources/get-mock-image :photo5)}
{:source (resources/get-mock-image :photo6)}])
Copy link
Member Author

@Parveshdhull Parveshdhull Jul 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These photos not available anymore

@status-im-auto
Copy link
Member

status-im-auto commented Jul 24, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a284abb #1 2023-07-24 08:19:04 ~9 min android-e2e 🤖apk 📲
✔️ a284abb #1 2023-07-24 08:19:07 ~9 min android 🤖apk 📲
✔️ a284abb #1 2023-07-24 08:19:28 ~9 min tests 📄log
✔️ a284abb #1 2023-07-24 08:19:34 ~9 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4faf089 #2 2023-07-24 09:03:11 ~6 min android-e2e 🤖apk 📲
✔️ 4faf089 #2 2023-07-24 09:03:14 ~6 min android 🤖apk 📲
✔️ 4faf089 #2 2023-07-24 09:04:51 ~7 min ios 📱ipa 📲
✔️ 4faf089 #2 2023-07-24 09:05:09 ~8 min tests 📄log
✔️ 9ad2fe9 #3 2023-07-24 19:15:43 ~5 min android-e2e 🤖apk 📲
✔️ 9ad2fe9 #3 2023-07-24 19:17:32 ~7 min ios 📱ipa 📲
✔️ 9ad2fe9 #3 2023-07-24 19:18:46 ~8 min android 🤖apk 📲
✔️ 9ad2fe9 #3 2023-07-24 19:19:13 ~9 min tests 📄log

@status-im-auto
Copy link
Member

67% of end-end tests have passed

Total executed tests: 36
Failed tests: 12
Passed tests: 24
Not executed tests: 3

IDs of not executed tests: 703496,703495,703382 

IDs of failed tests: 702732,703133,702957,702851,703086,702894,702936,702786,702947,702731,702845,702958

Not executed tests (3)

Click to expand
  • Rerun not executed tests

    • Failed tests (12)

    Click to expand
  • Rerun failed tests

    • Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    Device 2: Find `Button` by `accessibility id`: `tab-contacts`
    Device 2: Tap on found: Button 

    medium/test_activity_center.py:111: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.errors.verify_no_errors()
base_test_case.py:183: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Contact was not added to contact list after accepting contact request (as receiver)
E    Contact was not added to contact list after accepting contact request (as sender)



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mark_all_messages_as_read, id: 703086

    Device 1: Looking for chat: 'uzsjcrs'
    Device 1: Long press on ChatElement until expected element is shown 

    critical/test_public_chat_browsing.py:898: in test_community_mark_all_messages_as_read
    community_1_element.long_press_until_element_is_shown(mark_as_read_button)
../views/base_element.py:302: in long_press_until_element_is_shown
    action.long_press(element).release().perform()
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/common/touch_action.py:163: in perform
    self._driver.execute(Command.TOUCH_ACTION, params)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute
    self.error_handler.check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response
    raise wde
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response
    super().check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:242: in check_response
    raise exception_class(message, screen, stacktrace)
 The element 'By.xpath: //*[@content-desc='chat-name-text'][starts-with(@text,'uzsjcrs')]/..' does not exist in DOM anymore; also Unexpected Alert is shown: 'Feature not implemented.'



    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Tap on found: Button
    Device 1: Looking for a message by text: Hurray! unblocked 

    critical/test_public_chat_browsing.py:852: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:183: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Hurray! unblocked was not received in public chat after user unblock!



    Device sessions

    3. test_community_mentions_push_notification, id: 702786

    Device 1: Looking for a message by text: user_1
    Device 1: Find ChatElementByText by xpath: //*[starts-with(@text,'user_1')]/ancestor::android.view.ViewGroup[@content-desc='chat-item'] 

    critical/test_public_chat_browsing.py:942: in test_community_mentions_push_notification
    self.channel_1.set_reaction(message=self.username_1, emoji="sad")
../views/chat_view.py:1020: in set_reaction
    self.chat_element_by_text(message).long_press_until_element_is_shown(element)
../views/base_element.py:298: in long_press_until_element_is_shown
    element = self.find_element()
../views/chat_view.py:133: in find_element
    self.wait_for_visibility_of_element(20)
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: ChatElementByText by xpath:`//*[starts-with(@text,'user_1')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element; also Unexpected Alert is shown: 'Feature not implemented.'



    Device sessions

    4. test_community_leave, id: 702845

    Device 2: Find Button by xpath: //*[@text="Leave community"]
    Device 2: Tap on found: Button 

    None; also Unexpected Alert is shown: 'Feature not implemented.'



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_mentions, id: 702957 

    Test setup failed: medium/test_activity_center.py:132: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:351: in handle_contact_request
    self.close_activity_centre.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `close-activity-center` is not found on the screen



    2. test_navigation_jump_to, id: 702936

    Device 2: Find Button by xpath: //*[contains(@text, 'user1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]
    Device 2: Find Button by accessibility id: close-activity-center 

    Test setup failed: medium/test_activity_center.py:132: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:351: in handle_contact_request
    self.close_activity_centre.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `close-activity-center` is not found on the screen



    Device sessions

    3. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 

    Test setup failed: medium/test_activity_center.py:132: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:351: in handle_contact_request
    self.close_activity_centre.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `close-activity-center` is not found on the screen



    4. test_activity_center_admin_notification_accept_swipe, id: 702958 

    Test setup failed: medium/test_activity_center.py:132: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:351: in handle_contact_request
    self.close_activity_centre.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `close-activity-center` is not found on the screen



    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find Button by accessibility id: show-profiles
    Device 1: Tap on found: Button 

    critical/test_public_chat_browsing.py:433: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:183: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Contact(s) was (were) not restored from backup: Test_contact, MyCustomNickname!



    Device sessions

    Passed tests (24)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    4. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    5. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    7. test_1_1_chat_edit_message, id: 702855
    Device sessions

    8. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    9. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_message_delete, id: 702839
    Device sessions

    5. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    6. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    7. test_community_message_edit, id: 702843
    Device sessions

    8. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    2. test_group_chat_reactions, id: 703202
    Device sessions

    3. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    4. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    @Parveshdhull Parveshdhull requested a review from Francesca-G July 24, 2023 15:05
    ilmotta
    ilmotta approved these changes Jul 24, 2023
    View reviewed changes
    Copy link
    Contributor

    @ilmotta ilmotta left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    Francesca-G
    Francesca-G approved these changes Jul 24, 2023
    View reviewed changes
    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    The component looks good to me :)

    @Parveshdhull Parveshdhull force-pushed the quo2/implement-activity-log-photos branch from 4faf089 to 9ad2fe9 Compare July 24, 2023 19:09
    @Parveshdhull Parveshdhull merged commit 2a8e6cb into develop Jul 24, 2023
    @Parveshdhull Parveshdhull deleted the quo2/implement-activity-log-photos branch July 24, 2023 19:19
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Francesca-G Francesca-G Francesca-G approved these changes

    @J-Son89 J-Son89 J-Son89 approved these changes

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    @ilmotta ilmotta ilmotta approved these changes

    Assignees

    @Parveshdhull Parveshdhull

    Labels
    None yet
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @Parveshdhull @status-im-auto @ilmotta @smohamedjavid @J-Son89 @Francesca-G