Quo2: Network Amount #16764
Merged
Quo2: Network Amount #16764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarBasem
commented
Jul 24, 2023
Comment on lines
1
to
+6
| (ns status-im2.contexts.quo-preview.wallet.network-amount | ||
| (:require [clojure.string :as string] | ||
| [quo2.components.wallet.network-amount :refer [network-amount]] | ||
| [quo2.foundations.colors :as colors] | ||
| [react-native.core :as rn] | ||
| [reagent.core :as reagent] | ||
| [utils.i18n :as i18n] | ||
| [status-im2.contexts.quo-preview.preview :as preview])) | ||
| (:require | ||
| [quo2.core :as quo] | ||
| [react-native.core :as rn] | ||
| [reagent.core :as reagent] | ||
| [status-im2.contexts.quo-preview.preview :as preview])) |
There was a problem hiding this comment.
This is a new file. Would be easier to review by viewing the file.
OmarBasem
requested review from
erikseppanen,
briansztamfater,
smohamedjavid,
J-Son89 and
ibrkhalil
Jenkins BuildsClick to see older builds (21)
|
J-Son89
reviewed
Jul 24, 2023
J-Son89
reviewed
Jul 24, 2023
OmarBasem
force-pushed
the
quo2/network-amount
branch
from
9823241 to
18f86b9
Compare
OmarBasem
requested review from
J-Son89,
ibrkhalil,
smohamedjavid and
mmilad75
and removed request for
ibrkhalil and
smohamedjavid
J-Son89
reviewed
Jul 26, 2023
J-Son89
reviewed
Jul 26, 2023
|
Hi @Francesca-G, here is another one :) Component is under quo2 preview > wallet > Network Amount |
OmarBasem
force-pushed
the
quo2/network-amount
branch
from
18f86b9 to
e64b851
Compare
erikseppanen
approved these changes
Jul 28, 2023
Francesca-G
reviewed
Jul 28, 2023
There was a problem hiding this comment.
Here's the Figma frame with the design review for the component
OmarBasem
force-pushed
the
quo2/network-amount
branch
from
0c1c390 to
b3d7e03
Compare
|
Hi @Francesca-G, thanks for your review! I see something weird in the Figma frame. The text looks like it has shadow. How are you getting this? Are you getting it in light mode only? Is it happening iOS or Andriod? 
|
not a shadow, I overlapped the design with the PR screenshot to let you see that the text isn't matching and there's probably something different in the weight / kerning of the text :) |
|
@Francesca-G Oh okay, the weight was different that's why. It is fixed now! |
Francesca-G
approved these changes
Jul 31, 2023
OmarBasem
force-pushed
the
quo2/network-amount
branch
from
b3d7e03 to
3d860e3
Compare
mmilad75
pushed a commit
that referenced
this pull request
Aug 2, 2023
* feat: network amount component
mmilad75
pushed a commit
that referenced
this pull request
Aug 2, 2023
* feat: network amount component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #16750
This PR implements Network Amount component (and deletes old wallet components in Quo2).
Designs.