[#16254] Add new system messages in chat history when accepting a con… #16775

flexsurfer · 2023-07-25T14:39:52Z

status-im-auto · 2023-07-25T14:45:52Z

Jenkins Builds

Click to see older builds (40)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`26dd8bd`	#1	2023-07-25 14:45:52	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`26dd8bd`	#1	2023-07-25 14:46:56	~6 min	`ios`	📱`ipa` 📲
✔️	`26dd8bd`	#1	2023-07-25 14:48:51	~8 min	`android`	🤖`apk` 📲
✔️	`26dd8bd`	#1	2023-07-25 14:49:14	~9 min	`tests`	📄`log`

❌	`985cdb3`	#2	2023-07-27 10:06:33	~2 min	`tests`	📄`log`
✔️	`985cdb3`	#2	2023-07-27 10:09:11	~5 min	`android`	🤖`apk` 📲
✔️	`985cdb3`	#2	2023-07-27 10:09:18	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`985cdb3`	#2	2023-07-27 10:10:04	~6 min	`ios`	📱`ipa` 📲

✔️	`4c4505f`	#3	2023-07-27 11:29:50	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`4c4505f`	#3	2023-07-27 11:30:22	~6 min	`android`	🤖`apk` 📲
✔️	`4c4505f`	#3	2023-07-27 11:31:02	~6 min	`ios`	📱`ipa` 📲
✔️	`4c4505f`	#3	2023-07-27 11:36:29	~12 min	`tests`	📄`log`

✔️	`f442b28`	#5	2023-07-28 13:16:16	~5 min	`android`	🤖`apk` 📲
✔️	`f442b28`	#5	2023-07-28 13:16:38	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`f442b28`	#5	2023-07-28 13:17:44	~7 min	`ios`	📱`ipa` 📲
✔️	`f442b28`	#5	2023-07-28 13:19:05	~8 min	`tests`	📄`log`

✔️	`1b6db9e`	#6	2023-07-28 13:43:12	~6 min	`android`	🤖`apk` 📲
✔️	`1b6db9e`	#6	2023-07-28 13:44:34	~7 min	`ios`	📱`ipa` 📲
✔️	`1b6db9e`	#6	2023-07-28 13:45:27	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`1b6db9e`	#6	2023-07-28 13:48:25	~11 min	`tests`	📄`log`

✔️	`b8e6c20`	#7	2023-07-28 14:10:30	~5 min	`android`	🤖`apk` 📲
✔️	`b8e6c20`	#7	2023-07-28 14:11:45	~6 min	`ios`	📱`ipa` 📲
✔️	`b8e6c20`	#7	2023-07-28 14:13:39	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`b8e6c20`	#7	2023-07-28 14:13:59	~9 min	`tests`	📄`log`

✔️	`5a27e9a`	#8	2023-07-31 07:39:41	~7 min	`ios`	📱`ipa` 📲
✔️	`5a27e9a`	#8	2023-07-31 07:41:32	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`5a27e9a`	#8	2023-07-31 07:41:46	~9 min	`android`	🤖`apk` 📲
✔️	`5a27e9a`	#8	2023-07-31 07:42:24	~9 min	`tests`	📄`log`

❌	`287e2dc`	#9	2023-08-03 07:19:31	~2 min	`tests`	📄`log`
✔️	`287e2dc`	#9	2023-08-03 07:22:30	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`287e2dc`	#9	2023-08-03 07:22:37	~5 min	`android`	🤖`apk` 📲
✔️	`287e2dc`	#9	2023-08-03 07:24:10	~7 min	`ios`	📱`ipa` 📲

✔️	`45553bc`	#10	2023-08-03 07:39:32	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`45553bc`	#10	2023-08-03 07:39:34	~6 min	`android`	🤖`apk` 📲
✔️	`45553bc`	#10	2023-08-03 07:39:53	~6 min	`ios`	📱`ipa` 📲
✔️	`45553bc`	#10	2023-08-03 07:42:25	~9 min	`tests`	📄`log`

✔️	`39646de`	#11	2023-08-04 12:06:09	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`39646de`	#11	2023-08-04 12:06:16	~6 min	`android`	🤖`apk` 📲
✔️	`39646de`	#11	2023-08-04 12:08:44	~8 min	`tests`	📄`log`
✔️	`39646de`	#11	2023-08-04 12:13:45	~13 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`7d2d4ca`	#12	2023-08-07 07:29:05	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`7d2d4ca`	#12	2023-08-07 07:30:30	~6 min	`ios`	📱`ipa` 📲
✔️	`7d2d4ca`	#12	2023-08-07 07:31:16	~7 min	`android`	🤖`apk` 📲
✔️	`7d2d4ca`	#12	2023-08-07 07:32:31	~8 min	`tests`	📄`log`

✔️	`517acbf`	#13	2023-08-07 08:51:12	~5 min	`android`	🤖`apk` 📲
✔️	`517acbf`	#13	2023-08-07 08:52:39	~7 min	`ios`	📱`ipa` 📲
✔️	`517acbf`	#13	2023-08-07 08:54:00	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`517acbf`	#13	2023-08-07 08:55:20	~9 min	`tests`	📄`log`

status-im-auto · 2023-07-25T17:16:56Z

77% of end-end tests have passed

Total executed tests: 39
Failed tests: 9
Passed tests: 30

IDs of failed tests: 702733,702732,703133,702851,702894,703496,702839,702731,703382

Failed tests (9)

Click to expand

Rerun failed tests

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

Device 2: Find Button by accessibility id: tab-contacts
Device 2: Tap on found: Button

medium/test_activity_center.py:112: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.errors.verify_no_errors()
base_test_case.py:183: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Contact was not added to contact list after accepting contact request (as receiver)
E    Contact was not added to contact list after accepting contact request (as sender)

Device sessions

Device 1:

Device 2:

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device 1: Find `Button` by `accessibility id`: `show-profiles` Device 1: Tap on found: Button critical/test_public_chat_browsing.py:486: in test_restore_multiaccount_with_waku_backup_remove_switch self.errors.verify_no_errors() base_test_case.py:183: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) admin_open was not restored from waku-backup!! E member_open was not restored from waku-backup!! E admin_closed was not restored from waku-backup!! E member_closed was not restored from waku-backup!! E Incorrect contacts number restored: 0 instead of 2 E Contact(s) was (were) not restored from backup: Test_contact, MyCustomNickname! Device sessions Device 1: Steps, video, logs Failure screenshot
2. test_community_mute_community_and_channel, id: 703382
Device 1: Find `MuteButton` by `accessibility id`: `mute-community` Device 1: Click system back button `critical/test_public_chat_browsing.py:402: in test_community_mute_community_and_channel self.errors.verify_no_errors() base_test_case.py:183: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Text 'Muted until 16:50 Tue 01 Aug' is not shown for a muted community channel` Device sessions Device 1: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device 1: Getting PN by 'DELETE ME' Device 2: Could not reach ChatsTab element by pressing back `critical/chats/test_1_1_public_chats.py:1329: in test_1_1_chat_text_message_delete_push_disappear self.errors.verify_no_errors() base_test_case.py:183: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) System message about deletion for you is not displayed` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_mute_chat, id: 703496
Device 1: Click until `ChatMessageInput` by `accessibility id`: `chat-message-input` will be presented Device 1: Looking for a message by text: after unmute critical/chats/test_1_1_public_chats.py:1421: in test_1_1_chat_mute_chat self.errors.verify_no_errors() base_test_case.py:183: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message text 'should be muted' is not shown in chat preview after mute E Message 'should be muted' is not shown in chat for receiver after mute E New messages counter is not shown after unmute E Message text 'after unmute' is not shown in chat preview after unmute E Message 'after unmute' is not shown in chat for receiver after unmute Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestCommunityMultipleDeviceMerged:

1. test_community_contact_block_unblock_offline, id: 702894
Device 1: Tap on found: Button Device 1: Looking for a message by text: Hurray! unblocked `critical/test_public_chat_browsing.py:905: in test_community_contact_block_unblock_offline self.errors.verify_no_errors() base_test_case.py:183: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Hurray! unblocked was not received in public chat after user unblock!` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_message_delete, id: 702839
Device 2: Looking for a message by text: delete for me Device 1: Looking for a message by text: delete for me `critical/test_public_chat_browsing.py:594: in test_community_message_delete self.errors.verify_no_errors() base_test_case.py:183: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) System message about deletion for everyone is not displayed E System message about deletion for you is not displayed` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (30)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

src/quo2/components/messages/system_message.cljs

src/quo2/core.cljs

J-Son89

Looks good @flexsurfer, left one or two points which would be nice to check.

Thanks for making the changes, I realise now that perhaps you were away when some of this discussion was happening. As @ilmotta said, we can try this approach to see how it improves over the next while and if there are better alternatives then we can always update the approach - at the very least it seems to be making devs more aware of how to properly interact with Figma 👍

src/quo2/components/drawers/permission_context/style.cljs

src/quo2/components/drawers/permission_context/view.cljs

src/quo2/components/messages/system_message.cljs

pavloburykh · 2023-08-03T10:48:00Z

@flexsurfer thank you for the fixes!

Please take a look at these issues

ISSUE 1 New system messages are not displayed in chat preview

is fixed partially.

chat preview is still not displayed for contact removal messages

telegram-cloud-document-2-5359650965253271647.mp4

Also, preview is not displayed within cards in Jump to section

pavloburykh · 2023-08-03T10:51:53Z

ISSUE 8 CR system messages do not not generate unread counters in 1-1 chat

Here is discussion with design team https://discord.com/channels/624634427930312714/975775548007678033/1136605269644808304

Expected result: unread counters should be generated

Actual result: unread counters are not generated

status-im-auto · 2023-08-04T12:45:36Z

85% of end-end tests have passed

Total executed tests: 41
Failed tests: 6
Passed tests: 35

IDs of failed tests: 702809,702732,703133,702894,702731,703382

Failed tests (6)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_markdown_support, id: 702809
# STEP: Checking that "bold text in asterics" is applied () in 1-1 chat Device 1: Sending message 'bold text in asterics**' critical/test_public_chat_browsing.py:1104: in test_community_markdown_support chat_1.send_message(message_to_send) ../views/chat_view.py:968: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:117: in wait_for_element raise TimeoutException( Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_contact_block_unblock_offline, id: 702894
Device 1: Tap on found: Button Device 1: Looking for a message by text: Hurray! unblocked `critical/test_public_chat_browsing.py:927: in test_community_contact_block_unblock_offline self.errors.verify_no_errors() base_test_case.py:183: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Hurray! unblocked was not received in public chat after user unblock!` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
`Test is not run, e2e blocker` [[reason: [NOTRUN] Restoring communities issue: 16787; restoring contacts issue: 15500]]
2. test_community_mute_community_and_channel, id: 703382
Device 1: Find `MuteButton` by `accessibility id`: `mute-community` Device 1: Click system back button `critical/test_public_chat_browsing.py:418: in test_community_mute_community_and_channel self.errors.verify_no_errors() base_test_case.py:183: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Text 'Muted until 12:19 Fri 11 Aug' is not shown for a muted community channel` Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (35)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
3. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs

pavloburykh · 2023-08-04T14:50:47Z

Agreed with @flexsurfer to create followup for remained issues:

Missing counters for "you were removed from contact" and "now is contact" system messages
Preview is not shown for "you were removed from contact"/"you removed from contact" system messages

@Francesca-G please review the PR form your side. If there will be no additional issues please move to merge column.

@flexsurfer please, wait for @Francesca-G review before merging. Thank you!

Francesca-G

Here's the Figma frame with the design review :)

…tact request

flexsurfer · 2023-08-07T07:24:34Z

thanks @pavloburykh @Francesca-G

design doesn't have identicon ring
remove icon not updated
no icon for drawer button

message that I sent with the contact request didn't appear in the chat, will be addressed later in followup

pavloburykh · 2023-08-07T07:32:30Z

@flexsurfer thanx for the fixes. @Francesca-G could you please re-check?

Francesca-G

Here's the updated review :)

flexsurfer · 2023-08-07T08:47:06Z

thanks @Francesca-G , button is standard component, so we can't change the icon size, regarding ring, probably will be addressed here #16193

#16775) * [#16254] Add new system messages in chat history when accepting a contact request

…ing a con… (status-im#16775) * [status-im#16254] Add new system messages in chat history when accepting a contact request

churik · 2023-09-18T10:20:26Z

@flexsurfer
did you create an issue follow-up based on the design review?

Based on https://github.com/status-im/status-mobile/blob/develop/doc/pipeline_process.md > Design review, all follow-up issues have to be created when PR is merged and linked to the original PR.

flexsurfer · 2023-09-18T10:29:34Z

did you create an issue follow-up based on the design review?

no, I did not, according to my comment there were two issues, one is not an issue, and second there was already an issue

flexsurfer added the request-manual-qa label Jul 25, 2023

flexsurfer requested review from ajayesivan and siddarthkay July 25, 2023 14:39

flexsurfer self-assigned this Jul 25, 2023

J-Son89 reviewed Jul 25, 2023

View reviewed changes

src/quo2/components/messages/system_message.cljs Outdated Show resolved Hide resolved

J-Son89 reviewed Jul 25, 2023

View reviewed changes

src/quo2/components/messages/system_message.cljs Outdated Show resolved Hide resolved

churik self-assigned this Jul 27, 2023

flexsurfer requested review from J-Son89 and smohamedjavid July 27, 2023 10:03

J-Son89 reviewed Jul 27, 2023

View reviewed changes

src/quo2/components/messages/system_message.cljs Outdated Show resolved Hide resolved

J-Son89 reviewed Jul 27, 2023

View reviewed changes

src/quo2/components/messages/system_message.cljs Outdated Show resolved Hide resolved

J-Son89 reviewed Jul 27, 2023

View reviewed changes

src/quo2/core.cljs Outdated Show resolved Hide resolved

flexsurfer requested review from ilmotta and J-Son89 July 28, 2023 13:08

flexsurfer force-pushed the feature/Add_new_system_messages_in_chat_history_when_accepting_a_contact_request_#16254 branch from e59c6d8 to f442b28 Compare July 28, 2023 13:10

J-Son89 approved these changes Jul 28, 2023

View reviewed changes

src/quo2/components/drawers/permission_context/style.cljs Show resolved Hide resolved

src/quo2/components/drawers/permission_context/view.cljs Outdated Show resolved Hide resolved

src/quo2/components/messages/system_message.cljs Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

pavloburykh self-assigned this Jul 31, 2023

pavloburykh force-pushed the feature/Add_new_system_messages_in_chat_history_when_accepting_a_contact_request_#16254 branch from b8e6c20 to 5a27e9a Compare July 31, 2023 07:32

smohamedjavid approved these changes Jul 31, 2023

View reviewed changes

flexsurfer force-pushed the feature/Add_new_system_messages_in_chat_history_when_accepting_a_contact_request_#16254 branch from 45553bc to 39646de Compare August 4, 2023 11:59

pavloburykh added Tested - OK and removed Tested - Issues labels Aug 4, 2023

Francesca-G reviewed Aug 4, 2023

View reviewed changes

flexsurfer added 2 commits August 7, 2023 09:23

[#16254] Add new system messages in chat history when accepting a con…

9b87e85

…tact request

design review

7d2d4ca

flexsurfer force-pushed the feature/Add_new_system_messages_in_chat_history_when_accepting_a_contact_request_#16254 branch from 39646de to 7d2d4ca Compare August 7, 2023 07:23

Francesca-G approved these changes Aug 7, 2023

View reviewed changes

Francesca-G added the followup-required label Aug 7, 2023

design review

517acbf

flexsurfer merged commit bc18e8a into develop Aug 7, 2023

flexsurfer deleted the feature/Add_new_system_messages_in_chat_history_when_accepting_a_contact_request_#16254 branch August 7, 2023 08:56

pavloburykh mentioned this pull request Aug 7, 2023

Add preview and counters for CR system messages #16898

Closed

mmilad75 pushed a commit that referenced this pull request Aug 7, 2023

[#16254] Add new system messages in chat history when accepting a con… (

9e197a8

#16775) * [#16254] Add new system messages in chat history when accepting a contact request

pavloburykh mentioned this pull request Aug 10, 2023

Add preview and counters for CR system messages #16898 #16969

Merged

[#16254] Add new system messages in chat history when accepting a con… #16775

[#16254] Add new system messages in chat history when accepting a con… #16775

Conversation

flexsurfer commented Jul 25, 2023

status-im-auto commented Jul 25, 2023 • edited Loading

Jenkins Builds

status-im-auto commented Jul 25, 2023

77% of end-end tests have passed

Failed tests (9)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Passed tests (30)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePR:

J-Son89 left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

pavloburykh commented Aug 3, 2023 • edited Loading

ISSUE 1 New system messages are not displayed in chat preview

pavloburykh commented Aug 3, 2023

ISSUE 8 CR system messages do not not generate unread counters in 1-1 chat

status-im-auto commented Aug 4, 2023

85% of end-end tests have passed

Failed tests (6)

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Passed tests (35)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

pavloburykh commented Aug 4, 2023 • edited Loading

Francesca-G left a comment

Choose a reason for hiding this comment

flexsurfer commented Aug 7, 2023 • edited Loading

pavloburykh commented Aug 7, 2023

Francesca-G left a comment

Choose a reason for hiding this comment

flexsurfer commented Aug 7, 2023

churik commented Sep 18, 2023

flexsurfer commented Sep 18, 2023

status-im-auto commented Jul 25, 2023 •

edited

Loading

pavloburykh commented Aug 3, 2023 •

edited

Loading

pavloburykh commented Aug 4, 2023 •

edited

Loading

flexsurfer commented Aug 7, 2023 •

edited

Loading