Quo2: Token Input #16819
Merged
Quo2: Token Input #16819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarBasem
force-pushed
the
quo2/token-input
branch
from
9c3d338 to
ea7ba24
Compare
OmarBasem
requested review from
briansztamfater,
smohamedjavid,
J-Son89,
mmilad75 and
vkjr
Jenkins BuildsClick to see older builds (7)
|
OmarBasem
force-pushed
the
quo2/token-input
branch
from
ea7ba24 to
01a6467
Compare
OmarBasem
requested review from
briansztamfater,
vkjr,
smohamedjavid,
J-Son89 and
mmilad75
and removed request for
vkjr,
smohamedjavid,
J-Son89 and
mmilad75
There was a problem hiding this comment.
Nice work! @OmarBasem 🚀
I noticed that the state changes (token and currency) in preview screen is not reflected in the component.
A non-blocking UX comment:
To focus the input, the user needs to tap on the 0 placeholder precisely). IMO, this is painful and not a good UX. We need to check with the design team on this behaviour. We can capture the tap on the whole input container row and focus the input.
vkjr
reviewed
Aug 1, 2023
vkjr
requested changes
Aug 1, 2023
OmarBasem
force-pushed
the
quo2/token-input
branch
from
01a6467 to
768a1ef
Compare
|
Thanks for your review @smohamedjavid! Fixed the mentioned points. 👍 |
@vkjr Fixed it! |
smohamedjavid
approved these changes
Aug 2, 2023
vkjr
approved these changes
Aug 2, 2023
OmarBasem
force-pushed
the
quo2/token-input
branch
from
768a1ef to
e731d8e
Compare
OmarBasem
force-pushed
the
quo2/token-input
branch
from
e731d8e to
7a69a05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #16752
This PR implements Token Input component.
While implementing the component I realized that the Network Tag component is a component on its own and there is already a candidate working on it #16747 So I marked its place in the Token Input component with text
[WIP] Network Tagand will update the component in a follow up once it is merged.Designs.
Screenshot:
