Set initial block range for a newly created account #16835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
flexsurfer
approved these changes
Aug 2, 2023
rasom
force-pushed
the
fix/set-initial-range-for-a-new-account
branch
from
42d3ae7 to
ad17c37
Compare
rasom
commented
Aug 2, 2023
Comment on lines
+145
to
+146
| (if (or new-account? recovered-account?) | ||
| (profile.create/login-new-profile recovered-account?) |
There was a problem hiding this comment.
It was always false here before, likely this if clause is not needed
|
I think this pr should have went through some QA before merging. We have agreed to at least confirm with QA team if changes are simple enough that a pr doesn't need testing. cc @churik 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we try to fetch transfer history for a newly created account which costs us some unnecessary rpc requests
This can be fixed by setting initial blocks range as scanned, and worked like this with an old version of onboarding.
status: ready