Top bar stability & animation improvements #17170

alwx · 2023-09-04T07:54:44Z

Basically almost all the issues described in #16564 are caused by one problem: improper calculation of scroll-y when user hides and shows the keyboard.

Platforms

Android
iOS

Areas that maybe impacted

Functional

1-1 chats
public chats

status: ready

status-im-auto · 2023-09-04T07:58:19Z

Jenkins Builds

Click to see older builds (32)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`8e7ba2f`	#1	2023-09-04 07:58:18	~3 min	`tests`	📄`log`
✔️	`8e7ba2f`	#1	2023-09-04 08:00:49	~5 min	`android`	🤖`apk` 📲
✔️	`8e7ba2f`	#1	2023-09-04 08:01:29	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`8e7ba2f`	#1	2023-09-04 08:01:44	~6 min	`ios`	📱`ipa` 📲

✔️	`c66ebc4`	#3	2023-09-04 11:25:47	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`c66ebc4`	#3	2023-09-04 11:25:48	~6 min	`ios`	📱`ipa` 📲
✔️	`c66ebc4`	#3	2023-09-04 11:28:25	~8 min	`android`	🤖`apk` 📲
✔️	`c66ebc4`	#3	2023-09-04 11:28:43	~9 min	`tests`	📄`log`

❌	`27d4dc5`	#4	2023-09-05 17:10:56	~2 min	`tests`	📄`log`
✔️	`27d4dc5`	#4	2023-09-05 17:14:02	~5 min	`ios`	📱`ipa` 📲
✔️	`27d4dc5`	#4	2023-09-05 17:14:21	~6 min	`android`	🤖`apk` 📲
✔️	`27d4dc5`	#4	2023-09-05 17:14:25	~6 min	`android-e2e`	🤖`apk` 📲

✔️	`bd7fa9b`	#5	2023-09-06 13:00:40	~5 min	`android`	🤖`apk` 📲
✔️	`bd7fa9b`	#5	2023-09-06 13:01:19	~6 min	`ios`	📱`ipa` 📲
✔️	`bd7fa9b`	#5	2023-09-06 13:03:07	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`bd7fa9b`	#5	2023-09-06 13:04:37	~9 min	`tests`	📄`log`

❌	`718b7e4`	#10	2023-09-06 13:40:36	~2 min	`tests`	📄`log`
✔️	`718b7e4`	#10	2023-09-06 13:43:41	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`718b7e4`	#10	2023-09-06 13:43:47	~5 min	`android`	🤖`apk` 📲
✔️	`718b7e4`	#10	2023-09-06 13:47:09	~9 min	`ios`	📱`ipa` 📲

✔️	`e24378e`	#11	2023-09-06 14:21:00	~5 min	`android`	🤖`apk` 📲
✔️	`e24378e`	#11	2023-09-06 14:21:21	~6 min	`ios`	📱`ipa` 📲
✔️	`e24378e`	#11	2023-09-06 14:22:49	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`e24378e`	#11	2023-09-06 14:24:14	~9 min	`tests`	📄`log`

✔️	`a53d072`	#12	2023-09-06 16:20:26	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`a53d072`	#12	2023-09-06 16:20:34	~5 min	`android`	🤖`apk` 📲
✔️	`a53d072`	#12	2023-09-06 16:22:09	~7 min	`ios`	📱`ipa` 📲
✔️	`a53d072`	#12	2023-09-06 16:24:23	~9 min	`tests`	📄`log`

✔️	`908ac59`	#13	2023-09-07 09:42:27	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`908ac59`	#13	2023-09-07 09:45:15	~8 min	`android`	🤖`apk` 📲
✔️	`908ac59`	#13	2023-09-07 09:46:05	~9 min	`ios`	📱`ipa` 📲
✔️	`908ac59`	#13	2023-09-07 09:46:25	~9 min	`tests`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`d745796`	#14	2023-09-07 10:55:11	~5 min	`android`	🤖`apk` 📲
✔️	`d745796`	#14	2023-09-07 10:57:38	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`d745796`	#14	2023-09-07 10:59:09	~9 min	`tests`	📄`log`

✔️	`bcbef5d`	#15	2023-09-07 11:06:07	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`bcbef5d`	#15	2023-09-07 11:10:12	~9 min	`tests`	📄`log`
✔️	`bcbef5d`	#15	2023-09-07 11:10:48	~10 min	`ios`	📱`ipa` 📲
✔️	`bcbef5d`	#15	2023-09-07 11:12:19	~11 min	`android`	🤖`apk` 📲

ilmotta

Seems to work well in my poor tests @alwx. Nice fix.

Basically almost all the issues described [...]

Which bugs still remain to be fixed?

alwx · 2023-09-04T13:15:59Z

@ilmotta just the design improvements (super small ones) — it's ISSUE 2 See comments from @Francesca-G related to top bar in the description

ilmotta · 2023-09-04T13:24:48Z

@ilmotta just the design improvements (super small ones) — it's ISSUE 2 See comments from @Francesca-G related to top bar in the description

Awesome! Thanks

pavloburykh · 2023-09-04T13:43:26Z

@alwx please take a look at the issues

ISSUE 1 Top bar disappears after removing user from contacts and going back to 1-1 chat (Android)

It is originally reported here and is still reproducible

Reproduced on Android 12, Samsung Galaxy A52

Preconditions: User A (Android) and User B (any other platform) are mutual contacts. They have 1-1 chat with some amount of history in it and at least 1 message from User B.

Steps:

User A enters 1-1 chat with User B
User A opens User's B profile screen by tapping on his profile icon aside of his message in chat
User A removes User B from contacts
User A goes back to 1-1 chat
Pay attention at top bar

Actual result: top bar disappeared. It re-appears after chat re-opening.

telegram-cloud-document-2-5454040959006291474.mp4

pavloburykh · 2023-09-04T13:43:33Z

ISSUE 2 Wrong opacity of pinned bar after chat opening

Steps:

Generate some chat history
Pin a message
Re-open chat
Pay attention at pin bar opacity

Actual result: pin bar is transparent. Opacity is being fixed after chat scrolling.

telegram-cloud-document-2-5454040959006291482.mp4

status-im-auto · 2023-09-04T14:53:12Z

74% of end-end tests have passed

Total executed tests: 43
Failed tests: 11
Passed tests: 32

IDs of failed tests: 702733,702732,702813,703133,702745,703503,702786,702947,702807,702731,702808

Failed tests (11)

Click to expand

Rerun failed tests

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device 1: Find `Button` by `accessibility id`: `close-activity-center` Device 1: Tap on found: Button `None; RemoteDisconnected` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device 1: Find `Button` by `accessibility id`: `show-profiles` Device 1: Tap on found: Button critical/test_public_chat_browsing.py:533: in test_restore_multiaccount_with_waku_backup_remove_switch self.errors.verify_no_errors() base_test_case.py:187: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Incorrect contacts number restored: 0 instead of 2 E admin_open was not restored from waku-backup!! E member_open was not restored from waku-backup!! E admin_closed was not restored from waku-backup!! E member_closed was not restored from waku-backup!! Device sessions Device 1: Steps, video, logs Failure screenshot
2. test_community_discovery, id: 703503
Device 1: Tap on found: Button Device 1: Find `Button` by `xpath`: `//[@text="Contributors' test community"]` critical/test_public_chat_browsing.py:333: in test_community_discovery self.home.element_by_text(self.discovery_community_attributes[0]).click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by xpath: `//[@text="Contributors' test community"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]
2. test_group_chat_join_send_text_messages_push, id: 702807
Device 2: `Text` is `Delivered` Device 1: Looking for a message by text: Hey, admin! `critical/chats/test_group_chat.py:231: in test_group_chat_join_send_text_messages_push self.errors.verify_no_errors() base_test_case.py:187: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) No PN was received on new message for message in group chat` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
3. test_group_chat_offline_pn, id: 702808
Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member `critical/chats/test_group_chat.py:441: in test_group_chat_offline_pn self.errors.verify_no_errors() base_test_case.py:187: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Messages PN was not fetched from offline` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device 1: Could not reach home view by pressing system back button Device 2: Could not reach home view by pressing system back button `critical/chats/test_1_1_public_chats.py:1328: in test_1_1_chat_text_message_delete_push_disappear self.errors.verify_no_errors() base_test_case.py:187: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Push notification doesn't appear` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_push_emoji, id: 702813
Device 1: Find `Button` by `xpath`: `//*[contains(@content-desc,'Status')]` Device 1: Tap on found: Button `critical/chats/test_1_1_public_chats.py:1166: in test_1_1_chat_push_emoji self.device_1.driver.fail("Push notification with emoji was not received") base_test_case.py:175: in fail pytest.fail('Device %s: %s' % (self.number, text)) Device 1: Push notification with emoji was not received` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device 2: Find `MemberPhoto` by `xpath`: `//[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='user-avatar']` Device 2: Image differs from template to 7.131491268382353 percents `critical/chats/test_1_1_public_chats.py:1127: in test_1_1_chat_non_latin_messages_stack_update_profile_photo self.errors.verify_no_errors() base_test_case.py:187: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Image of user in 1-1 chat is too different from template!` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_mentions_push_notification, id: 702786

# STEP: Invited member gets push notification with the mention and tap it
Device 2: Getting PN by 'user_2'

critical/test_public_chat_browsing.py:1146: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:187: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin
E    Can not edit a message with a mention
E    Push notification with the mention was not received by the invited member

[[Issue with username in PN, issue #6 in 15500]]

Device sessions

Device 1:

Device 2:

Passed tests (32)

Click to expand

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
3. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
4. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Style updates Style updates, bugfixes

alwx · 2023-09-06T14:15:00Z

@pavloburykh fixed; ready to be checked again!

status-im-auto · 2023-09-06T16:27:59Z

67% of end-end tests have passed

Total executed tests: 43
Failed tests: 14
Passed tests: 29

IDs of failed tests: 702958,702786,702745,702731,702851,703202,702807,702808,702813,702948,702732,703503,703297,703495

Failed tests (14)

Click to expand

Rerun failed tests

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_admin_notification_accept_swipe, id: 702958

Device 2: Find `Button` by `xpath`: `//*[@content-desc='password-input']/../following-sibling::*//*[@text='Join Community']`
Device 2: Tap on found: Button

medium/test_activity_center.py:385: in test_activity_center_admin_notification_accept_swipe
    self.community_2.join_community()
../views/chat_view.py:424: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Device 2:

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_reactions, id: 703202
Test setup failed: critical/chats/test_group_chat.py:207: in prepare_devices self.chats[0].send_message(self.message_before_adding) ../views/chat_view.py:995: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:121: in wait_for_element raise TimeoutException( Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element
2. test_group_chat_join_send_text_messages_push, id: 702807
## Group chat uqcfqpt is created successfully! Device 1: Sending message 'message before adding new user' Test setup failed: critical/chats/test_group_chat.py:207: in prepare_devices self.chats[0].send_message(self.message_before_adding) ../views/chat_view.py:995: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:121: in wait_for_element raise TimeoutException( Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
3. test_group_chat_offline_pn, id: 702808
Test setup failed: critical/chats/test_group_chat.py:207: in prepare_devices self.chats[0].send_message(self.message_before_adding) ../views/chat_view.py:995: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:121: in wait_for_element raise TimeoutException( Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element
4. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]
5. test_group_chat_send_image_save_and_share, id: 703297
Test setup failed: critical/chats/test_group_chat.py:207: in prepare_devices self.chats[0].send_message(self.message_before_adding) ../views/chat_view.py:995: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:121: in wait_for_element raise TimeoutException( Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element
6. test_group_chat_mute_chat, id: 703495
Test setup failed: critical/chats/test_group_chat.py:207: in prepare_devices self.chats[0].send_message(self.message_before_adding) ../views/chat_view.py:995: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:121: in wait_for_element raise TimeoutException( Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] https://github.com//issues/17175]]

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

Device 1: Find ChatsTab by accessibility id: chats-stack-tab
Device 1: Tap on found: ChatsTab

medium/test_activity_center.py:102: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.home_1.notifications_unread_badge.wait_for_visibility_of_element(30)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: BaseElement by accessibility id:`activity-center-unread-count` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Device 2:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device 2: Find `MemberPhoto` by `xpath`: `//[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='user-avatar']` Device 2: Image differs from template to 8.549780752144608 percents `critical/chats/test_1_1_public_chats.py:1128: in test_1_1_chat_non_latin_messages_stack_update_profile_photo self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Image of user in 1-1 chat is too different from template!` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]
3. test_1_1_chat_push_emoji, id: 702813
Device 1: App to background Device 2: Sending message 'emoji' critical/chats/test_1_1_public_chats.py:1161: in test_1_1_chat_push_emoji chat_2.send_message(emoji.emojize(emoji_message)) ../views/chat_view.py:995: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:121: in wait_for_element raise TimeoutException( Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_mentions_push_notification, id: 702786
# STEP: Invited member gets push notification with the mention and tap it Device 2: Getting PN by 'user_2' `critical/test_public_chat_browsing.py:1149: in test_community_mentions_push_notification self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Push notification with the mention was not received by admin E Can not edit a message with a mention E Push notification with the mention was not received by the invited member` [[Issue with username in PN, issue #6 in 15500]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_hashtag_links_to_community_channels, id: 702948
# STEP: Device 1 sends a message with hashtag in the dogs channel Device 1: Sending message '#cats' critical/test_public_chat_browsing.py:1259: in test_community_hashtag_links_to_community_channels self.channel_1.send_message(message_with_hashtag) ../views/chat_view.py:995: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:121: in wait_for_element raise TimeoutException( Device `1`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element; RemoteDisconnected Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (29)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
4. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

churik · 2023-09-07T10:10:29Z

@alwx

confirmed that top-bar improved a lot, tested on IPhone 14 + Google Pixel 7

churik · 2023-09-07T10:11:39Z

@Francesca-G can you please look at this one if there are no clear blockers from your side?
Thank you!

pavloburykh · 2023-09-07T10:19:01Z

@ilmotta just the design improvements (super small ones) — it's ISSUE 2 See comments from @Francesca-G related to top bar in the description

@Francesca-G please, take into consideration that these comments #16564 (comment) were not addressed in this PR. So followup will be required cc @alwx

Francesca-G

It looks good from a design perspective.

The only thing I'd address is that the top bar doesn't load quickly when I open and close the composer:

RPReplay_Final1694082993.mp4

alwx · 2023-09-07T10:49:16Z

@pavloburykh @Francesca-G yes, this will be done in a separate PR today/tomorrow. Will not be closing the original issue.

flexsurfer assigned alwx Sep 4, 2023

alwx marked this pull request as ready for review September 4, 2023 11:19

alwx requested review from ilmotta and flexsurfer September 4, 2023 11:19

ilmotta approved these changes Sep 4, 2023

View reviewed changes

alwx added the request-manual-qa label Sep 4, 2023

pavloburykh self-assigned this Sep 4, 2023

pavloburykh added the Tested - Issues label Sep 4, 2023

flexsurfer approved these changes Sep 4, 2023

View reviewed changes

alwx force-pushed the top-bar-updates branch from ff9f71d to e28bb6d Compare September 6, 2023 13:31

alwx requested review from churik and jakubgs as code owners September 6, 2023 13:31

Top bar stability improvements

7ee59ca

Style updates Style updates, bugfixes

alwx force-pushed the top-bar-updates branch from e28bb6d to 7ee59ca Compare September 6, 2023 13:34

alwx removed request for jakubgs and churik September 6, 2023 13:34

alwx added 3 commits September 6, 2023 15:37

Display name update

20b215b

Merge branch 'develop' into top-bar-updates

718b7e4

Style fix

e24378e

Merge branch 'develop' into top-bar-updates

a53d072

Merge branch 'develop' into top-bar-updates

908ac59

churik added Tested - OK and removed Tested - Issues labels Sep 7, 2023

Francesca-G approved these changes Sep 7, 2023

View reviewed changes

Francesca-G added the followup-required label Sep 7, 2023

alwx added 2 commits September 7, 2023 12:49

Merge branch 'develop' into top-bar-updates

d745796

Merge branch 'develop' into top-bar-updates

bcbef5d

alwx merged commit c1c8c21 into develop Sep 7, 2023

alwx deleted the top-bar-updates branch September 7, 2023 11:13

Top bar stability & animation improvements #17170

Top bar stability & animation improvements #17170

Conversation

alwx commented Sep 4, 2023 • edited Loading

Platforms

Areas that maybe impacted

Functional

status-im-auto commented Sep 4, 2023 • edited Loading

Jenkins Builds

ilmotta left a comment

Choose a reason for hiding this comment

alwx commented Sep 4, 2023

ilmotta commented Sep 4, 2023

pavloburykh commented Sep 4, 2023

ISSUE 1 Top bar disappears after removing user from contacts and going back to 1-1 chat (Android)

pavloburykh commented Sep 4, 2023

ISSUE 2 Wrong opacity of pinned bar after chat opening

status-im-auto commented Sep 4, 2023

74% of end-end tests have passed

Failed tests (11)

Class TestActivityMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMergedTwo:

Passed tests (32)

Class TestActivityMultipleDevicePR:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePRTwo:

Class TestCommunityMultipleDeviceMergedTwo:

alwx commented Sep 6, 2023

status-im-auto commented Sep 6, 2023

67% of end-end tests have passed

Failed tests (14)

Class TestActivityMultipleDevicePRTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMergedTwo:

Passed tests (29)

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

churik commented Sep 7, 2023

churik commented Sep 7, 2023

pavloburykh commented Sep 7, 2023

Francesca-G left a comment

Choose a reason for hiding this comment

alwx commented Sep 7, 2023

alwx commented Sep 4, 2023 •

edited

Loading

status-im-auto commented Sep 4, 2023 •

edited

Loading