feat: implement address input #17191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (63)
|
briansztamfater
force-pushed
the
feat/address-input
branch
4 times, most recently
from
7a8de7d to
d67b1d9
Compare
✔️ status-mobile/prs/ios/PR-17191#13 🔹 ~8 min 31 sec 🔹 9cc1ccd 🔹 📦 ios package |
briansztamfater
changed the title
briansztamfater
requested review from
J-Son89,
smohamedjavid,
ajayesivan,
jo-mut,
OmarBasem and
mmilad75
J-Son89
reviewed
Sep 11, 2023
J-Son89
reviewed
Sep 11, 2023
J-Son89
reviewed
Sep 11, 2023
OmarBasem
approved these changes
Sep 11, 2023
ajayesivan
approved these changes
Sep 11, 2023
jo-mut
approved these changes
Sep 11, 2023
briansztamfater
force-pushed
the
feat/address-input
branch
from
ed74ce1 to
2266c4d
Compare
|
@Francesca-G can you please review this PR? 🙏 ❤️ |
J-Son89
reviewed
Sep 11, 2023
Francesca-G
reviewed
Sep 11, 2023
|
@Francesca-G Unfortunately, I couldn't reproduce the cursor issue, I can see it normally when I focus on the input. Can you try again with latest build and also provide more info about the device you are using (device model, OS version, etc) or if you did some special steps to reproduce it? Thanks! RPReplay_Final1694477945.movAlso re-checked Paste button font and matches the Figma design. Let me know if there's something I did not see.
Adjusted clear button alignment 👍 Let me know any additional info and thanks again for testing. |
|
@briansztamfater the issue with the missing cursor happened when opening the preview for the first time, without tapping anywhere, the component should've been in default style but it's already active.
Seems I'm not able to preview the "default" style without tapping on the component first. RPReplay_Final1694502935.mp4 |
briansztamfater
force-pushed
the
feat/address-input
branch
from
5f47655 to
6efa3f7
Compare
|
@Francesca-G now I see! Thanks for catching this issue 👁️ , should be fixed now! |
briansztamfater
force-pushed
the
feat/address-input
branch
from
6efa3f7 to
2cccd1a
Compare
Signed-off-by: Brian Sztamfater <[email protected]>
briansztamfater
force-pushed
the
feat/address-input
branch
from
2cccd1a to
b306218
Compare
J-Son89
reviewed
Sep 13, 2023
| :padding-bottom 16 | ||
| :height 48 | ||
| :flex-direction :row | ||
| :align-items :flex-start}) |
There was a problem hiding this comment.
nit: maybe it's good in advance to add a container-style prop here and merge it. i.e
(defn container [constainer-style]
(merge {:padding-horizontal 20
:padding-top 8
:padding-bottom 16
:height 48
:flex-direction :row
:align-items :flex-start}
container-style))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17189
Summary
Implement Address input
Screenshots
Platforms
Steps to test
status: ready