Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doc: How to catch crash on ios use xcode #17278

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Conversation

qfrank
Copy link
Contributor

@qfrank qfrank commented Sep 13, 2023

link to view the doc

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Sep 13, 2023

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4f1ea49 #1 2023-09-13 13:09:50 ~6 min android 🤖apk 📲
✔️ 4f1ea49 #1 2023-09-13 13:11:42 ~8 min ios 📱ipa 📲
✔️ 4f1ea49 #1 2023-09-13 13:12:43 ~9 min android-e2e 🤖apk 📲
✔️ 4f1ea49 #1 2023-09-13 13:13:31 ~10 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1b1e095 #3 2023-09-14 07:56:21 ~5 min android-e2e 🤖apk 📲
✔️ 1b1e095 #3 2023-09-14 07:57:34 ~6 min ios 📱ipa 📲
✔️ 1b1e095 #3 2023-09-14 07:59:55 ~9 min android 🤖apk 📲
✔️ 1b1e095 #3 2023-09-14 08:00:15 ~9 min tests 📄log
✔️ 16225b8 #4 2023-09-15 03:57:12 ~6 min ios 📱ipa 📲
✔️ 16225b8 #4 2023-09-15 04:00:20 ~9 min android-e2e 🤖apk 📲
✔️ 16225b8 #4 2023-09-15 04:00:30 ~9 min android 🤖apk 📲
✔️ 16225b8 #4 2023-09-15 04:00:47 ~10 min tests 📄log

Copy link
Member

@Samyoul Samyoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for detailing this @qfrank

Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @qfrank

Copy link
Contributor

@ilmotta ilmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test the instructions, but thank you anyway @qfrank.

As a suggestion, I did a pass on gpt only to fix the grammar and broke the first paragraph into a few different ones.

Sometimes, we can't reproduce a crash with a local dev build, probably because
your built version differs from the one the QA team used. The QA team mostly
used the PR build version. In this guide, we will try to make a build as close
as possible to the PR build for iOS.

You may notice various configuration files starting with .env (such as .env,
.env.e2e, .env.jenkins) in the project. The usage of these files and environment
variables injected at build time on CI will not be covered in this guide.

This guide covers how to configure Xcode to capture a crash stack trace with a
physical iOS device. This allows debugging crashes by inspecting the stack
trace.

We will use [issue
#17255](https://github.com/status-im/status-mobile/issues/17255) as an example
to reproduce and analyze a crash.

Copy link
Contributor

@siddarthkay siddarthkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a few tiny suggestions this document looks good!
Thanks for sharing this knowledge @qfrank !

doc/how-to-catch-crash-on-ios.md Outdated Show resolved Hide resolved
doc/how-to-catch-crash-on-ios.md Outdated Show resolved Hide resolved
doc/how-to-catch-crash-on-ios.md Outdated Show resolved Hide resolved
@qfrank qfrank force-pushed the doc/catch-crash-on-ios branch from 559c381 to 1b1e095 Compare September 14, 2023 07:50
@jo-mut
Copy link
Contributor

jo-mut commented Sep 14, 2023

its a good one

Copy link
Member

@smohamedjavid smohamedjavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Contributor

@ajayesivan ajayesivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qfrank Nice work 🎉 !

@qfrank qfrank force-pushed the doc/catch-crash-on-ios branch from 1b1e095 to 16225b8 Compare September 15, 2023 03:50
@qfrank qfrank merged commit 72b8979 into develop Sep 15, 2023
@qfrank qfrank deleted the doc/catch-crash-on-ios branch September 15, 2023 04:04
@qfrank
Copy link
Contributor Author

qfrank commented Sep 18, 2023

Sorry team, i've made a bad example that merged PR without e2e test although no code changes in this PR! I should also notice QA team in this case. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging this pull request may close these issues.