Wallet: ENS #18000

OmarBasem · 2023-11-27T08:26:38Z

This PR implements ENS name resolving for send screen.

Demo:

Screen_Recording_20231127_121959_Status.Debug.mp4

status-im-auto · 2023-11-27T08:30:55Z

Jenkins Builds

Click to see older builds (25)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`4a85e7b`	#1	2023-11-27 08:30:54	~3 min	`tests`	📄`log`
✔️	`4a85e7b`	#1	2023-11-27 08:33:53	~6 min	`ios`	📱`ipa` 📲
✔️	`4a85e7b`	#1	2023-11-27 08:34:14	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`4a85e7b`	#1	2023-11-27 08:34:15	~7 min	`android`	🤖`apk` 📲

❌	`ba32de9`	#2	2023-11-28 07:34:53	~2 min	`tests`	📄`log`
✔️	`ba32de9`	#2	2023-11-28 07:38:25	~6 min	`ios`	📱`ipa` 📲
✔️	`ba32de9`	#2	2023-11-28 07:39:14	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`ba32de9`	#2	2023-11-28 07:39:19	~7 min	`android`	🤖`apk` 📲

❌	`7097b33`	#3	2023-11-29 09:20:43	~3 min	`tests`	📄`log`
✔️	`7097b33`	#3	2023-11-29 09:24:16	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`7097b33`	#3	2023-11-29 09:24:23	~7 min	`android`	🤖`apk` 📲
✔️	`7097b33`	#3	2023-11-29 09:30:59	~13 min	`ios`	📱`ipa` 📲

❌	`1f88a34`	#4	2023-11-30 07:11:02	~2 min	`tests`	📄`log`
✔️	`1f88a34`	#4	2023-11-30 07:14:26	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`1f88a34`	#4	2023-11-30 07:14:29	~6 min	`android`	🤖`apk` 📲
✔️	`1f88a34`	#4	2023-11-30 07:15:05	~6 min	`ios`	📱`ipa` 📲

❌	`c8ab656`	#5	2023-12-01 13:17:09	~2 min	`tests`	📄`log`

❌	`ca9c86b`	#6	2023-12-01 13:20:40	~2 min	`tests`	📄`log`
✔️	`ca9c86b`	#6	2023-12-01 13:24:22	~6 min	`android`	🤖`apk` 📲
✔️	`ca9c86b`	#6	2023-12-01 13:24:44	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`ca9c86b`	#6	2023-12-01 13:30:41	~12 min	`ios`	📱`ipa` 📲

❌	`d313fe2`	#7	2023-12-06 07:41:23	~3 min	`tests`	📄`log`
✔️	`d313fe2`	#7	2023-12-06 07:44:45	~6 min	`ios`	📱`ipa` 📲
✔️	`d313fe2`	#7	2023-12-06 07:45:23	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`d313fe2`	#7	2023-12-06 07:45:29	~7 min	`android`	🤖`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`e2ae737`	#8	2023-12-07 03:38:13	~3 min	`tests`	📄`log`
✔️	`e2ae737`	#8	2023-12-07 03:41:28	~6 min	`ios`	📱`ipa` 📲
✔️	`e2ae737`	#8	2023-12-07 03:42:06	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`e2ae737`	#8	2023-12-07 03:42:11	~7 min	`android`	🤖`apk` 📲

✔️	`0db26b8`	#9	2023-12-07 03:54:39	~6 min	`ios`	📱`ipa` 📲
✔️	`0db26b8`	#9	2023-12-07 03:58:55	~10 min	`android`	🤖`apk` 📲
✔️	`0db26b8`	#9	2023-12-07 03:59:08	~10 min	`android-e2e`	🤖`apk` 📲
✔️	`0db26b8`	#9	2023-12-07 04:00:26	~12 min	`tests`	📄`log`

src/status_im2/contexts/wallet/events.cljs

mmilad75

LGTM

mmilad75 · 2023-11-29T09:18:03Z

@OmarBasem I apologize for updating the branch, I thought it was my PR :/

OmarBasem · 2023-11-29T09:47:25Z

@OmarBasem I apologize for updating the branch, I thought it was my PR :/

No problem :)

src/status_im2/contexts/wallet/send/select_address/view.cljs

src/status_im2/contexts/wallet/events.cljs

status-im-auto · 2023-11-29T10:31:50Z

82% of end-end tests have passed

Total executed tests: 45
Failed tests: 4
Expected to fail tests: 4
Passed tests: 37

IDs of failed tests: 703133,702948,702786,703629

IDs of expected to fail tests: 702732,703503,702731,702808

Failed tests (4)

Click to expand

Rerun failed tests

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device 1: Find `Button` by `accessibility id`: `show-profiles`
Device 1: Tap on found: Button

critical/chats/test_public_chat_browsing.py:273: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Incorrect contacts number restored: 0 instead of 2
E    admin_open was not restored from waku-backup!!
E    member_open was not restored from waku-backup!!
E    admin_closed was not restored from waku-backup!!
E    member_closed was not restored from waku-backup!!

Device sessions

Device 1:

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_hashtag_links_to_community_channels, id: 702948
Device 2: Joining community Device 2: Find `Button` by `accessibility id`: `show-request-to-join-screen-button` critical/chats/test_public_chat_browsing.py:985: in test_community_hashtag_links_to_community_channels self.community_2.join_community(open_community=False) ../views/chat_view.py:427: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_mentions_push_notification, id: 702786
Device 2: Getting PN by 'user_2' Device 2: Looking for a message by text: user_2 `critical/chats/test_public_chat_browsing.py:901: in test_community_mentions_push_notification self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Can not edit a message with a mention E Edited message is not shown correctly for the (receiver) admin` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_community_join_when_node_owner_offline, id: 703629
Device 2: Looking for a message by text: open community Device 2: Find `BaseElement` by `xpath`: `//[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@text='View']` critical/chats/test_public_chat_browsing.py:1068: in test_community_join_when_node_owner_offline self.chat_2.chat_element_by_text(community_name).view_community_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: BaseElement by xpath: `//[starts-with(@text,'open community')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@text='View']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Expected to fail tests (4)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]
2. test_group_chat_offline_pn, id: 702808
Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member `critical/chats/test_group_chat.py:323: in test_group_chat_offline_pn self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Messages PN was not fetched from offline` [[Data delivery issue]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Passed tests (37)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
3. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
4. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

OmarBasem · 2023-11-30T07:08:47Z

Thanks for review @smohamedjavid ! Fixed the issues 👍

src/status_im2/contexts/wallet/events.cljs

src/status_im2/contexts/wallet/send/select_address/view.cljs

churik · 2023-12-05T11:04:33Z

@OmarBasem
thank you, it works!
One question - in Metamask and in our Figama addresses are checksummed, and currently, it is implemented as non-checksummed.
Design:
|
Implementation:

Can we make it checksummed to align with design?

OmarBasem · 2023-12-06T07:40:22Z

@churik thanks for your testing! Fixed the issue

churik · 2023-12-06T11:21:01Z

@Francesca-G ready for design review from my POV, thank you @OmarBasem !

churik · 2023-12-06T11:28:34Z

if this needs design review from your POV, if it's postponed for making design review of full flow - it's ready to merge @OmarBasem

OmarBasem · 2023-12-06T13:39:08Z

@churik there is no UI implemented in this PR. The UI components was implemented and reviewed in previous PRs

* wallet: ens

OmarBasem added the wallet: Send all issues for the send page of the wallet label Nov 27, 2023

OmarBasem self-assigned this Nov 27, 2023

OmarBasem requested review from tumanov-alex, briansztamfater, J-Son89 and mmilad75 November 27, 2023 08:27

OmarBasem commented Nov 27, 2023

View reviewed changes

src/status_im2/contexts/wallet/events.cljs Show resolved Hide resolved

J-Son89 reviewed Nov 27, 2023

View reviewed changes

src/status_im2/contexts/wallet/events.cljs Outdated Show resolved Hide resolved

OmarBasem force-pushed the wallet/ens branch from 4a85e7b to ba32de9 Compare November 28, 2023 07:31

OmarBasem requested review from J-Son89, briansztamfater and smohamedjavid and removed request for briansztamfater November 28, 2023 07:32

mmilad75 approved these changes Nov 29, 2023

View reviewed changes

OmarBasem added the request-manual-qa label Nov 29, 2023

smohamedjavid reviewed Nov 29, 2023

View reviewed changes

OmarBasem force-pushed the wallet/ens branch from 7097b33 to 1f88a34 Compare November 30, 2023 07:07

smohamedjavid reviewed Nov 30, 2023

View reviewed changes

src/status_im2/contexts/wallet/events.cljs Show resolved Hide resolved

src/status_im2/contexts/wallet/events.cljs Show resolved Hide resolved

src/status_im2/contexts/wallet/send/select_address/view.cljs Show resolved Hide resolved

OmarBasem force-pushed the wallet/ens branch from 1f88a34 to c8ab656 Compare December 1, 2023 13:14

churik self-assigned this Dec 4, 2023

churik added the Tested - Issues label Dec 5, 2023

OmarBasem force-pushed the wallet/ens branch from ca9c86b to d313fe2 Compare December 6, 2023 07:37

OmarBasem removed the Tested - Issues label Dec 6, 2023

churik added the Tested - OK label Dec 6, 2023

OmarBasem added 15 commits December 7, 2023 07:23

u

7eb86a9

wallet: ens

50948ba

lint

fa35930

lint

7f4e5d9

lint

588bfc8

review

a0456bb

lint

f8245b3

review

978c962

review

cbd44ab

review

63db7db

lint

eceec4b

lint

f4c1518

lint

83bc977

review

9ccd33a

lint

e2ae737

OmarBasem force-pushed the wallet/ens branch from d313fe2 to e2ae737 Compare December 7, 2023 03:34

lint

0db26b8

OmarBasem merged commit f692ae2 into develop Dec 7, 2023
6 checks passed

OmarBasem deleted the wallet/ens branch December 7, 2023 04:00

yevh-berdnyk pushed a commit that referenced this pull request Dec 8, 2023

Wallet: ENS (#18000)

a141bff

* wallet: ens

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wallet: ENS #18000

Wallet: ENS #18000

OmarBasem commented Nov 27, 2023

status-im-auto commented Nov 27, 2023 •

edited

Loading

mmilad75 left a comment

mmilad75 commented Nov 29, 2023

OmarBasem commented Nov 29, 2023

status-im-auto commented Nov 29, 2023

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePRTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

OmarBasem commented Nov 30, 2023

churik commented Dec 5, 2023

OmarBasem commented Dec 6, 2023

churik commented Dec 6, 2023

churik commented Dec 6, 2023

OmarBasem commented Dec 6, 2023

Wallet: ENS #18000

Wallet: ENS #18000

Conversation

OmarBasem commented Nov 27, 2023

status-im-auto commented Nov 27, 2023 • edited Loading

Jenkins Builds

mmilad75 left a comment

Choose a reason for hiding this comment

mmilad75 commented Nov 29, 2023

OmarBasem commented Nov 29, 2023

status-im-auto commented Nov 29, 2023

82% of end-end tests have passed

Failed tests (4)

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Expected to fail tests (4)

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Passed tests (37)

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePRTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

OmarBasem commented Nov 30, 2023

churik commented Dec 5, 2023

OmarBasem commented Dec 6, 2023

churik commented Dec 6, 2023

churik commented Dec 6, 2023

OmarBasem commented Dec 6, 2023

status-im-auto commented Nov 27, 2023 •

edited

Loading