Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix app is not opened on the last viewed chat after reopening #18090

Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix app is not opened on the last viewed chat after reopening #18090

merged 1 commit into from
Dec 7, 2023

Conversation

Parveshdhull
Copy link
Member

fixes #18075

status: ready

@Parveshdhull Parveshdhull requested a review from ilmotta December 6, 2023 10:33
@Parveshdhull Parveshdhull self-assigned this Dec 6, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Dec 6, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1982382 #1 2023-12-06 10:41:03 ~6 min ios 📱ipa 📲
✔️ 1982382 #1 2023-12-06 10:42:10 ~7 min android-e2e 🤖apk 📲
✔️ 1982382 #1 2023-12-06 10:49:40 ~15 min android 🤖apk 📲
✔️ 1982382 #2 2023-12-06 15:37:31 ~11 min tests 📄log
✔️ 1982382 #2 2023-12-07 11:53:17 ~8 min ios 📱ipa 📲
✔️ c592b47 #2 2023-12-07 12:06:25 ~6 min android-e2e 🤖apk 📲
✔️ c592b47 #2 2023-12-07 12:06:50 ~6 min android 🤖apk 📲
✔️ c592b47 #3 2023-12-07 12:10:10 ~10 min tests 📄log
✔️ c592b47 #3 2023-12-07 12:13:14 ~13 min ios 📱ipa 📲

ilmotta
ilmotta approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@ilmotta ilmotta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry to see this bug was caused by my* recent refactors. Thank you for fixing it @Parveshdhull

@Parveshdhull
Copy link
Member Author

Parveshdhull commented Dec 6, 2023 •
edited
Loading

I'm sorry to see this bug was caused by my* recent refactors. Thank you for fixing it @Parveshdhull

nw, it's a small price for the greater good :)

@status-im-auto
Copy link
Member

77% of end-end tests have passed

Total executed tests: 48
Failed tests: 5
Expected to fail tests: 6
Passed tests: 37
Not executed tests: 1

IDs of not executed tests: 704615 

IDs of failed tests: 702809,703133,702948,702786,703629 

IDs of expected to fail tests: 702732,702894,703503,702846,702731,702808

Not executed tests (1)

Click to expand
  • Rerun not executed tests

    • Failed tests (5)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809

    # STEP: Checking that "bold text in asterics" is applied (**) in community channel
    Device 2: Sending message '**bold text in asterics**' 

    critical/chats/test_public_chat_browsing.py:925: in test_community_markdown_support
    self.channel_2.send_message(message_to_send)
../views/chat_view.py:1003: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'#cats')]
    Device 2: Looking for a message by text: it is just a message text 

    critical/chats/test_public_chat_browsing.py:1046: in test_community_hashtag_links_to_community_channels
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Receiver was not navigated to the cats channel
E    Sender was not navigated to the cats channel



    Device sessions

    3. test_community_mentions_push_notification, id: 702786

    # STEP: Invited member sends a message with a mention
    Device 2: Sending message 'hi' 

    critical/chats/test_public_chat_browsing.py:821: in test_community_mentions_push_notification
    self.channel_2.send_message("hi")
../views/chat_view.py:1003: in send_message
    self.chat_message_input.wait_for_element(wait_chat_input_sec)
../views/base_element.py:121: in wait_for_element
    raise TimeoutException(
 Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element



    Device sessions

    4. test_community_join_when_node_owner_offline, id: 703629

    Device 2: Tap on found: Button
    Device 2: Looking for community: 'open community' 

    critical/chats/test_public_chat_browsing.py:1113: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Joined status is not displayed
E    open community is not listed inside Joined communities tab



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find Button by accessibility id: show-profiles
    Device 1: Tap on found: Button 

    critical/chats/test_public_chat_browsing.py:274: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Incorrect contacts number restored: 3 instead of 2



    Device sessions

    Expected to fail tests (6)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    2. test_community_navigate_to_channel_when_relaunch, id: 702846 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Issue #18075]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:323: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Find ProfileSendMessageButton by accessibility id: Chat-item-button
    Device 1: Sending message 'piy' 

    critical/chats/test_public_chat_browsing.py:741: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat with unblocked user was not enabled after 1 minute

    [[Message can be missed after unblock: https://github.com//issues/16873]]

    Device sessions

    Passed tests (37)

    Click to expand

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_open_universal_links_from_other_apps, id: 704614
    Device sessions

    3. test_links_deep_links, id: 702775
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_message_delete, id: 702839
    Device sessions

    6. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    9. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_leave, id: 702845
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_undo_delete_message, id: 702869
    Device sessions

    3. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    @churik churik self-assigned this Dec 7, 2023
    @churik
    Copy link
    Member

    churik commented Dec 7, 2023

    Thanks for your amazing work!
    e2e failures are known not related to PR.
    Tested basic flows + resirect to PRs, LGTM!

    Devices:

    • IPhone 14 Pro (IOS 16.5.1)
    • Google Pixel 7A (Android 13)

    @Parveshdhull Parveshdhull merged commit 9cf4556 into develop Dec 7, 2023
    6 checks passed
    @Parveshdhull Parveshdhull deleted the fix/last-chat branch December 7, 2023 12:14
    yevh-berdnyk pushed a commit that referenced this pull request Dec 8, 2023
    @Parveshdhull @yevh-berdnyk
    fix app is not opened on the last viewed chat after reopening (#18090)
    0f0f8d6
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    @ilmotta ilmotta ilmotta approved these changes

    Assignees

    @churik churik

    @Parveshdhull Parveshdhull

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    App is not opened on the last viewed chat after reopening
    5 participants
    @Parveshdhull @status-im-auto @churik @ilmotta @flexsurfer