Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide eligibility when checking #18878

Merged
merged 1 commit into from
Feb 21, 2024
Merged

hide eligibility when checking #18878

merged 1 commit into from
Feb 21, 2024

Conversation

cammellos
Copy link
Contributor

@cammellos cammellos commented Feb 16, 2024 •
edited by pavloburykh
Loading

When checking permissions, we should not show previous results

depends on #18870 check only last commit

Fixes #18859

@cammellos cammellos self-assigned this Feb 16, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Feb 16, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ a2badbd #1 2024-02-16 17:19:32 ~5 min tests 📄log
✔️ a2badbd #1 2024-02-16 17:20:34 ~6 min android 🤖apk 📲
✔️ a2badbd #1 2024-02-16 17:20:39 ~6 min ios 📱ipa 📲
✔️ a2badbd #1 2024-02-16 17:22:14 ~8 min android-e2e 🤖apk 📲
✔️ 12f7018 #2 2024-02-19 12:42:14 ~8 min tests 📄log
✔️ 12f7018 #2 2024-02-19 12:42:45 ~8 min android-e2e 🤖apk 📲
✔️ 12f7018 #2 2024-02-19 12:43:18 ~9 min android 🤖apk 📲
✔️ 12f7018 #2 2024-02-19 12:46:47 ~12 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 51e4745 #3 2024-02-20 17:13:18 ~5 min tests 📄log
✔️ 51e4745 #3 2024-02-20 17:14:37 ~6 min android-e2e 🤖apk 📲
✔️ 51e4745 #3 2024-02-20 17:14:48 ~7 min ios 📱ipa 📲
✔️ 51e4745 #3 2024-02-20 17:15:47 ~8 min android 🤖apk 📲
✔️ cfaed80 #4 2024-02-21 11:24:28 ~6 min tests 📄log
✔️ cfaed80 #4 2024-02-21 11:25:51 ~7 min ios 📱ipa 📲
✔️ cfaed80 #4 2024-02-21 11:27:16 ~9 min android-e2e 🤖apk 📲
✔️ cfaed80 #4 2024-02-21 11:27:21 ~9 min android 🤖apk 📲

ajayesivan
ajayesivan approved these changes Feb 18, 2024
View reviewed changes
Copy link
Contributor

@ajayesivan ajayesivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I have updated the code to use the bottom-actions component in this PR, it will have conflicts with these changes.

@pavloburykh pavloburykh self-assigned this Feb 20, 2024
@status-im-auto
Copy link
Member

96% of end-end tests have passed

Total executed tests: 48
Failed tests: 1
Expected to fail tests: 1
Passed tests: 46

IDs of failed tests: 702869 

IDs of expected to fail tests: 703503

Failed tests (1)

Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_community_undo_delete_message, id: 702869

    Device 1: Tap on found: Button
    Device 1: Find `Button` by `xpath`: `//*[@text="Undo"]` 

    critical/chats/test_public_chat_browsing.py:112: in test_community_undo_delete_message
    self.channel.element_by_text("Undo").click()
../views/base_element.py:90: in click
    self.find_element().click()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by xpath: `//*[@text="Undo"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (46)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_edit_message, id: 702855
    Device sessions

    2. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    5. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    6. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    7. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    8. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    4. test_group_chat_pin_messages, id: 702732
    Device sessions

    5. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    6. test_group_chat_mute_chat, id: 703495
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_deep_links, id: 702775
    Device sessions

    2. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    2. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_leave, id: 702845
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_markdown_support, id: 702809
    Device sessions

    4. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    3. test_add_contact_field_validation, id: 702777
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    3. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    5. test_community_unread_messages_badge, id: 702841
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    9. test_community_one_image_send_reply, id: 702859
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_several_images_send_reply, id: 703194
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    @cammellos thanx for the PR. Let's merge it.

    @cammellos cammellos merged commit cfaed80 into develop Feb 21, 2024
    2 of 6 checks passed
    @cammellos cammellos deleted the bug/fix-eligibility branch February 21, 2024 11:18
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ajayesivan ajayesivan ajayesivan approved these changes

    @FFFra FFFra FFFra approved these changes

    @ilmotta ilmotta ilmotta approved these changes

    Assignees

    @cammellos cammellos

    @pavloburykh pavloburykh

    Labels
    None yet
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Slow updating of eligibility status in the bottom of 'Addresses for permissions' screen
    6 participants
    @cammellos @status-im-auto @pavloburykh @ilmotta @FFFra @ajayesivan