Wallet: finalize kp #18991
Merged
Wallet: finalize kp #18991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (54)
|
OmarBasem
force-pushed
the
wallet/finalize-kp
branch
from
3b40d67 to
014d665
Compare
OmarBasem
requested review from
briansztamfater,
smohamedjavid,
J-Son89,
shivekkhurana,
mmilad75 and
FFFra
OmarBasem
commented
Feb 26, 2024
Comment on lines
+43
to
+45
| :networks [{:network-name :ethereum :short-name "eth"} | ||
| {:network-name :optimism :short-name "opt"} | ||
| {:network-name :arbitrum :short-name "arb1"}] |
There was a problem hiding this comment.
This is temporary. The account networks are not included in the keypair data returned from status-go, so need to read the account networks in another way. Will be address in that issue: #18993
|
in the video attached there is "Schema Errors" - is it possible to fix these or create issues for them? |
J-Son89
reviewed
Feb 26, 2024
J-Son89
reviewed
Feb 26, 2024
src/status_im/contexts/wallet/create_account/select_keypair/view.cljs
Outdated
Show resolved
Hide resolved
J-Son89
reviewed
Feb 26, 2024
src/status_im/contexts/wallet/create_account/select_keypair/view.cljs
Outdated
Show resolved
Hide resolved
J-Son89
reviewed
Feb 26, 2024
src/status_im/contexts/wallet/create_account/select_keypair/view.cljs
Outdated
Show resolved
Hide resolved
J-Son89
reviewed
Feb 26, 2024
src/status_im/contexts/wallet/create_account/select_keypair/view.cljs
Outdated
Show resolved
Hide resolved
J-Son89
reviewed
Feb 26, 2024
J-Son89
reviewed
Feb 26, 2024
J-Son89
reviewed
Feb 26, 2024
J-Son89
reviewed
Feb 26, 2024
J-Son89
reviewed
Feb 26, 2024
src/status_im/contexts/wallet/create_account/select_keypair/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/wallet/create_account/select_keypair/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/wallet/create_account/select_keypair/view.cljs
Outdated
Show resolved
Hide resolved
J-Son89
reviewed
Feb 26, 2024
OmarBasem
force-pushed
the
wallet/finalize-kp
branch
from
a3160b0 to
41837f6
Compare
I will try to find the cause and open an issue Opened an issue: #19026 |
|
@J-Son89 @smohamedjavid I think all comments are addressed. Can you rereview please |
OmarBasem
force-pushed
the
wallet/finalize-kp
branch
from
1a4761d to
576d73b
Compare
96% of end-end tests have passedFailed tests (1)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (46)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
|
OmarBasem
force-pushed
the
wallet/finalize-kp
branch
from
2665786 to
8fc025b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #18813
This PR implements the following:
Designs
Selecting an already created keypair to create a new wallet account will be implemented in another issue #18993
Demo:
Screen_Recording_20240226_132554_Status.mp4