[#18964] Support custom message when sending contact request #18998

seanstrom · 2024-02-26T12:17:34Z

Summary

This PR attempts to resolve the need for a re-frame event handler that can send a contact request with a custom message. This PR builds on the requirements described in #18964 and #18965:

Creating a contact-request event and event handler
- The seems to already exists in status-im.contexts.chat.contacts.events
Augmenting the contact-request event to support custom messages
- This will allow for the new/upcoming contact request UI to send a personalised message.
Defaulting to the original contact request message when no custom message is provided.
- This may be useful to avoid breaking the contact request event handler.

Platforms

Android
iOS

Areas that maybe impacted

Functional

Contact requests from mobile

Steps to test

There are a few steps for setting up the environment, in this case,

Open Status mobile app and desktop app
Send a contact request between the Status mobile user and Status desktop user
Verify that the contact request is received with the default/original message (e.g. "Please add me to your contacts")

Before and after screenshots comparison

Before changes

Send.Contact.Request.Before.mov

After changes

Send.Contact.Request.After.mov

status: ready

status-im-auto · 2024-02-26T12:19:58Z

Jenkins Builds

Click to see older builds (23)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`606e479`	#1	2024-02-26 12:19:58	~2 min	`tests`	📄`log`
✔️	`606e479`	#1	2024-02-26 12:25:32	~7 min	`android`	🤖`apk` 📲
✔️	`606e479`	#1	2024-02-26 12:26:12	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`606e479`	#1	2024-02-26 12:27:36	~9 min	`ios`	📱`ipa` 📲

✔️	`ee72f73`	#2	2024-02-26 12:51:27	~5 min	`tests`	📄`log`
✔️	`ee72f73`	#2	2024-02-26 12:52:48	~6 min	`android`	🤖`apk` 📲
✔️	`ee72f73`	#2	2024-02-26 12:53:44	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`ee72f73`	#2	2024-02-26 12:54:53	~8 min	`ios`	📱`ipa` 📲

✔️	`a22eac3`	#3	2024-02-27 09:15:41	~5 min	`tests`	📄`log`
✔️	`a22eac3`	#3	2024-02-27 09:17:31	~7 min	`android`	🤖`apk` 📲
✔️	`a22eac3`	#3	2024-02-27 09:18:02	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`a22eac3`	#3	2024-02-27 09:19:14	~9 min	`ios`	📱`ipa` 📲

✔️	`ebad941`	#5	2024-02-28 10:58:34	~6 min	`tests`	📄`log`
✔️	`ebad941`	#5	2024-02-28 10:58:41	~7 min	`android`	🤖`apk` 📲
✔️	`ebad941`	#5	2024-02-28 11:00:02	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`ebad941`	#5	2024-02-28 11:04:12	~12 min	`ios`	📱`ipa` 📲

✔️	`68dcb36`	#6	2024-02-29 16:40:00	~6 min	`tests`	📄`log`
✔️	`68dcb36`	#6	2024-02-29 16:40:38	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`68dcb36`	#6	2024-02-29 16:41:18	~7 min	`android`	🤖`apk` 📲
✔️	`68dcb36`	#6	2024-02-29 16:44:55	~11 min	`ios`	📱`ipa` 📲

✔️	`fcd3c00`	#7	2024-03-01 09:55:12	~5 min	`tests`	📄`log`
✔️	`fcd3c00`	#7	2024-03-01 09:56:16	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`fcd3c00`	#7	2024-03-01 09:56:37	~7 min	`android`	🤖`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`6b3b21a`	#8	2024-03-01 10:06:31	~6 min	`tests`	📄`log`
✔️	`6b3b21a`	#8	2024-03-01 10:07:28	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`6b3b21a`	#8	2024-03-01 10:07:36	~7 min	`android`	🤖`apk` 📲
✔️	`6b3b21a`	#8	2024-03-01 10:10:23	~10 min	`ios`	📱`ipa` 📲

✔️	`bcfe34e`	#9	2024-03-05 10:16:17	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`bcfe34e`	#9	2024-03-05 10:16:25	~7 min	`android`	🤖`apk` 📲
✔️	`bcfe34e`	#9	2024-03-05 10:16:31	~7 min	`ios`	📱`ipa` 📲
✔️	`bcfe34e`	#10	2024-03-05 10:42:52	~4 min	`tests`	📄`log`

yqrashawn

LGTM

status-im-auto · 2024-02-27T07:53:20Z

12% of end-end tests have passed

Total executed tests: 48
Failed tests: 41
Expected to fail tests: 1
Passed tests: 6

IDs of failed tests: 702809,702782,702733,702784,703194,702859,702777,702732,702813,703133,702957,702851,702840,703495,703086,702948,702894,702745,702783,702850,703297,704615,703496,702936,702855,703202,703391,702786,702839,702947,702838,702844,702843,702807,702731,702808,702730,702845,702958,703629,702841

IDs of expected to fail tests: 703503

Failed tests (41)

Click to expand

Rerun failed tests

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages (TestRail link is not found)
Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user admin')]/ancestor::[@content-desc='activity']/[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
2. test_group_chat_mute_chat, id: 703495
Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user admin')]/ancestor::[@content-desc='activity']/[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
3. test_group_chat_send_image_save_and_share, id: 703297
Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user admin')]/ancestor::[@content-desc='activity']/[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
4. test_group_chat_reactions, id: 703202
Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user admin')]/ancestor::[@content-desc='activity']/[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
5. test_group_chat_join_send_text_messages_push (TestRail link is not found)
Device 2: Tap on found: Button Device 2: Attempt 0 is successful clicking close-activity-center Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user admin')]/ancestor::[@content-desc='activity']/[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
6. test_group_chat_offline_pn, id: 702808
Test setup failed: critical/chats/test_group_chat.py:55: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:44: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, self.kwargs) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user admin')]/ancestor::[@content-desc='activity']/[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device 2: Tap on found: Button Device 2: Attempt 0 is successful clicking close-activity-center activity_center/test_activity_center.py:190: in test_add_contact_field_validation self.home_2.handle_contact_request(new_username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'test user 123')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device 1: Find `ChatsTab` by `accessibility id`: `chats-stack-tab` Device 1: Tap on found: ChatsTab activity_center/test_activity_center.py:112: in test_activity_center_contact_request_accept_swipe_mark_all_as_read self.home_1.notifications_unread_badge.wait_for_visibility_of_element(30) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: BaseElement by accessibility id:`activity-center-unread-count` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_activity_center_contact_request_decline, id: 702850
Device 1: Tap on found: Button Device 1: Find `Text` by `xpath`: `//[@content-desc="pending-contact-requests-count"]/android.widget.TextView` activity_center/test_activity_center.py:69: in test_activity_center_contact_request_decline if self.home_1.pending_contact_request_text.text != '1': ../views/base_element.py:415: in text text = self.find_element().text ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Text by xpath: `//[@content-desc="pending-contact-requests-count"]/android.widget.TextView` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device 1: Find Button by accessibility id: show-profiles
Device 1: Tap on found: Button

critical/chats/test_public_chat_browsing.py:276: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 zQ3...dWXh5 was not restored as a contact from waku backup!
E    zQ3...Vacac was not restored as a contact from waku backup!
E    admin_open was not restored from waku-backup!!
E    member_open was not restored from waku-backup!!
E    admin_closed was not restored from waku-backup!!
E    member_closed was not restored from waku-backup!!

Device sessions

Device 1:

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Test setup failed: critical/chats/test_public_chat_browsing.py:818: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
2. test_community_hashtag_links_to_community_channels, id: 702948
Test setup failed: critical/chats/test_public_chat_browsing.py:818: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
3. test_community_mentions_push_notification, id: 702786
Device 2: Tap on found: Button Device 2: Attempt 0 is successful clicking close-activity-center Test setup failed: critical/chats/test_public_chat_browsing.py:818: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_community_leave, id: 702845
Test setup failed: critical/chats/test_public_chat_browsing.py:818: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
5. test_community_join_when_node_owner_offline, id: 703629
Test setup failed: critical/chats/test_public_chat_browsing.py:818: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device 2: Tap on found: Button Device 2: Attempt 0 is successful clicking close-activity-center Test setup failed: activity_center/test_activity_center.py:393: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Test setup failed: activity_center/test_activity_center.py:393: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to (TestRail link is not found)
Device 2: Tap on found: Button Device 2: Attempt 0 is successful clicking close-activity-center Test setup failed: activity_center/test_activity_center.py:246: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_reply_read_unread_delete_filter_swipe (TestRail link is not found)
Test setup failed: activity_center/test_activity_center.py:246: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Test setup failed: critical/chats/test_1_1_public_chats.py:546: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device 2: Tap on found: Button Device 2: Attempt 0 is successful clicking close-activity-center Test setup failed: critical/chats/test_1_1_public_chats.py:546: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_1_1_chat_mute_chat, id: 703496
Test setup failed: critical/chats/test_1_1_public_chats.py:546: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
3. test_1_1_chat_push_emoji, id: 702813
Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo (TestRail link is not found)
Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
5. test_1_1_chat_edit_message (TestRail link is not found)
Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
6. test_1_1_chat_send_image_save_and_share (TestRail link is not found)
Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
7. test_1_1_chat_pin_messages (TestRail link is not found)
Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
8. test_1_1_chat_message_reaction, id: 702730
Device 2: Tap on found: Button Device 2: Attempt 0 is successful clicking close-activity-center Test setup failed: critical/chats/test_1_1_public_chats.py:40: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'sender')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply (TestRail link is not found)
Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
2. test_community_one_image_send_reply (TestRail link is not found)
Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
3. test_community_emoji_send_copy_paste_reply (TestRail link is not found)
Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
4. test_community_mark_all_messages_as_read, id: 703086
Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
5. test_community_contact_block_unblock_offline, id: 702894
Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
6. test_community_edit_delete_message_when_offline, id: 704615
Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
7. test_community_message_delete, id: 702839
Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
8. test_community_message_send_check_timestamps_sender_username (TestRail link is not found)
Device 2: Tap on found: Button Device 2: Attempt 0 is successful clicking close-activity-center Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable (TestRail link is not found)
Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
10. test_community_message_edit (TestRail link is not found)
Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
11. test_community_unread_messages_badge (TestRail link is not found)
Test setup failed: critical/chats/test_public_chat_browsing.py:296: in prepare_devices self.home_2.handle_contact_request(self.username_1) ../views/home_view.py:382: in handle_contact_request chat_element.accept_contact_request() ../views/home_view.py:150: in accept_contact_request self.handle_cr("accept-contact-request") ../views/home_view.py:147: in handle_cr ).wait_for_rendering_ended_and_click() ../views/base_element.py:163: in wait_for_rendering_ended_and_click self.wait_for_visibility_of_element(20) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 2: Button by xpath:`//[contains(@text, 'user_1')]/ancestor::[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery (TestRail link is not found)
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (6)

Click to expand

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat (TestRail link is not found)
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links (TestRail link is not found)
Device sessions Device 1: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input (TestRail link is not found)
Device sessions Device 1: Steps, video, logs
2. test_community_undo_delete_message (TestRail link is not found)
Device sessions Device 1: Steps, video, logs
3. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
4. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

mohsen-ghafouri

🚀

src/status_im/contexts/chat/contacts/events.cljs

status-im-auto · 2024-02-29T21:15:42Z

96% of end-end tests have passed

Total executed tests: 48
Failed tests: 1
Expected to fail tests: 1
Passed tests: 46

IDs of failed tests: 703629

IDs of expected to fail tests: 703503

Failed tests (1)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_join_when_node_owner_offline, id: 703629

Device 2: Looking for community: 'open community'
Device 2: Click until `Text` by `accessibility id`: `community-description-text` will be presented

critical/chats/test_public_chat_browsing.py:1178: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Text "You joined “closed community”" in shown toast element doesn't match expected "You joined “open community”"

Device sessions

Device 1:

Device 2:

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (46)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
6. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

seanstrom · 2024-03-01T12:16:03Z

Hey @status-im/mobile-qa I have a question about this PR.
This PR adds support for sending a personalised message when sending a contact request, but it doesn't change the existing UI or behaviour. Should this be manual-qa because it could affect the original behaviour?

qoqobolo · 2024-03-04T14:06:19Z

This PR adds support for sending a personalised message when sending a contact request, but it doesn't change the existing UI or behaviour. Should this be manual-qa because it could affect the original behaviour?

Hi @seanstrom, sorry for the late reply!
In such cases, regression testing is a good idea. Sometimes devs may skip the manual testing step though, if they are 100% sure that their changes have not affected the current behavior and a manual smoke check + e2e tests are enough, so this is up to you.

seanstrom · 2024-03-04T14:12:42Z

Hey @qoqobolo 👋
no worries about the reply 🏄, and thanks for explanation 🙏, it's nice to know these guidelines. I think we should do the regression testing since I'm not 100% sure 👍

VolodLytvynenko · 2024-03-05T09:54:13Z

Hi @seanstrom thank you for PR. No issues from my side. PR is ready to be merged

…quest

…g-event-fx`

… sending a contact request

seanstrom added the anothers-profile https://www.notion.so/Silhouettes-08d57f036b43473b904bfd3f1b2a76aa label Feb 26, 2024

seanstrom self-assigned this Feb 26, 2024

seanstrom requested review from yqrashawn and mohsen-ghafouri February 26, 2024 12:18

seanstrom force-pushed the seanstrom/add-contact-request-user-message branch from 606e479 to ee72f73 Compare February 26, 2024 12:45

yqrashawn added the request-manual-qa label Feb 27, 2024

yqrashawn approved these changes Feb 27, 2024

View reviewed changes

seanstrom requested a review from ilmotta February 27, 2024 08:31

seanstrom removed the anothers-profile https://www.notion.so/Silhouettes-08d57f036b43473b904bfd3f1b2a76aa label Feb 27, 2024

seanstrom force-pushed the seanstrom/add-contact-request-user-message branch from ee72f73 to a22eac3 Compare February 27, 2024 09:09

mohsen-ghafouri approved these changes Feb 27, 2024

View reviewed changes

seanstrom force-pushed the seanstrom/add-contact-request-user-message branch from a22eac3 to b652104 Compare February 28, 2024 10:47

seanstrom force-pushed the seanstrom/add-contact-request-user-message branch from b652104 to ebad941 Compare February 28, 2024 10:51

seanstrom mentioned this pull request Feb 29, 2024

Implement Contact Request flow in Contact Profile #19039

Merged

seanstrom force-pushed the seanstrom/add-contact-request-user-message branch from ebad941 to 68dcb36 Compare February 29, 2024 16:33

ilmotta approved these changes Feb 29, 2024

View reviewed changes

src/status_im/contexts/chat/contacts/events.cljs Outdated Show resolved Hide resolved

src/status_im/contexts/chat/contacts/events.cljs Outdated Show resolved Hide resolved

seanstrom force-pushed the seanstrom/add-contact-request-user-message branch from fcd3c00 to 6b3b21a Compare March 1, 2024 09:59

VolodLytvynenko self-assigned this Mar 4, 2024

VolodLytvynenko added the Tested - OK label Mar 5, 2024

seanstrom added 6 commits March 5, 2024 10:08

tweak: allow for optional message to be sent when making a contact re…

7a5f1c1

…quest

chore: migrate contact-request event handler from rf/defn to `rf/re…

e4c4bea

…g-event-fx`

test: add tests for sending a contact request

84b90ef

chore: make it easier to test on-success and on-error behaviour after…

88b2550

… sending a contact request

tidy: use reframe fx for declaring json-rpc/call

73ab91a

tidy: remove unused success event handler for send a contact request

bcfe34e

seanstrom force-pushed the seanstrom/add-contact-request-user-message branch from 6b3b21a to bcfe34e Compare March 5, 2024 10:08

seanstrom changed the title ~~Support custom message when sending contact request~~ [#18964] Support custom message when sending contact request Mar 5, 2024

seanstrom merged commit e783deb into develop Mar 5, 2024
6 checks passed

seanstrom deleted the seanstrom/add-contact-request-user-message branch March 5, 2024 10:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#18964] Support custom message when sending contact request #18998

[#18964] Support custom message when sending contact request #18998

seanstrom commented Feb 26, 2024

status-im-auto commented Feb 26, 2024 •

edited

Loading

yqrashawn left a comment

status-im-auto commented Feb 27, 2024

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

Class TestDeepLinksOneDevice:

Class TestCommunityOneDeviceMerged:

mohsen-ghafouri left a comment

status-im-auto commented Feb 29, 2024

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestDeepLinksOneDevice:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePR:

seanstrom commented Mar 1, 2024

qoqobolo commented Mar 4, 2024

seanstrom commented Mar 4, 2024

VolodLytvynenko commented Mar 5, 2024

[#18964] Support custom message when sending contact request #18998

[#18964] Support custom message when sending contact request #18998

Conversation

seanstrom commented Feb 26, 2024

Summary

Platforms

Areas that maybe impacted

Functional

Steps to test

Before and after screenshots comparison

Before changes

After changes

status-im-auto commented Feb 26, 2024 • edited Loading

Jenkins Builds

yqrashawn left a comment

Choose a reason for hiding this comment

status-im-auto commented Feb 27, 2024

12% of end-end tests have passed

Failed tests (41)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (6)

Class TestDeepLinksOneDevice:

Class TestCommunityOneDeviceMerged:

mohsen-ghafouri left a comment

Choose a reason for hiding this comment

status-im-auto commented Feb 29, 2024

96% of end-end tests have passed

Failed tests (1)

Class TestCommunityMultipleDeviceMergedTwo:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (46)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestDeepLinksOneDevice:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePR:

seanstrom commented Mar 1, 2024

qoqobolo commented Mar 4, 2024

seanstrom commented Mar 4, 2024

VolodLytvynenko commented Mar 5, 2024

status-im-auto commented Feb 26, 2024 •

edited

Loading