-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix chat navigation buttons when scrolling to top #19097
Conversation
Jenkins BuildsClick to see older builds (16)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you for fixing this.
4838dff
to
49ef522
Compare
49ef522
to
788cd77
Compare
Hi @clauxx ! Thanks for your fix! I have found such behaviour and wonder if it is related or/and could be mentioned here in this PR. ISSUE 1: navigation button change it's blur background when reopening chat and scroll Steps:
Actual result: navigation button change it's blur background when reopening chat and scroll. It firstly has much transparent background as it changes after. video_2024-03-11_15-20-42.mp4video_2024-03-11_15-35-16.mp4 |
@mariia-skrypnyk i'm not sure if understand the issue from the videos |
Yes @clauxx , sorry. It it's not so obvious as I thought. it is the same chat and the same navigation icon on the background (x) but after starting to scroll and after you move to the start of conversation at the top of the chat |
@clauxx were my details useful? |
@mariia-skrypnyk sorry yes, got caught up with a different issue. It's much clearer from the screenshots 👍 |
90b7321
to
5fbb2eb
Compare
@mariia-skrypnyk have a look again please |
Thanks @clauxx ! I observe such issue appeared in new build (Android). ISSUE 2: Group details block reloads when user scrolls from the bottom to the top Steps:
video_2024-03-13_15-19-31.mp4Actual result: Group details block reloads and user see it's blinking |
@mariia-skrypnyk this isn't caused by this PR |
@clauxx thanks for investigating it, will move PR to the design review by @Francesca-G after e2e test. |
92% of end-end tests have passed
Failed tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (44)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me ✨
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
Signed-off-by: Cristian Lungu <[email protected]>
332c9c5
to
cf2dbdb
Compare
fixes #19095
Summary
The navigation buttons (back/more) in the chat have the :photo background while the navbar is transparent (i.e scrolled to the top) and :blur when opaque (i.e. while scrolling through messages)
Platforms
Areas that maybe impacted
Functional
Steps to test
:blur
to:photo
as header becomes transparentBefore and after screenshots comparison
screen-20240304-190222.mp4
status: ready