Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet: Derivation Path screen #19268

Merged
merged 6 commits into from
Mar 18, 2024
Merged

Wallet: Derivation Path screen #19268

merged 6 commits into from
Mar 18, 2024

Conversation

OmarBasem
Copy link
Contributor

@OmarBasem OmarBasem commented Mar 15, 2024 •
edited
Loading

fixes: #19219

This PR adds missing UI components on the derivation path screen:

  • Dropdown input
  • Path bottom sheet
  • Numbered keyboard

Note: the screen is currently non-functional. I will create an epic and add new issues for the derivation path feature.

Designs

Demo:

Screen_Recording_20240315_140642_Status.mp4

@OmarBasem OmarBasem self-assigned this Mar 15, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Mar 15, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 85f9010 #1 2024-03-15 10:16:19 ~1 min tests 📄log
✔️ df67dca #2 2024-03-15 10:26:21 ~7 min android-e2e 🤖apk 📲
✔️ df67dca #2 2024-03-15 10:26:27 ~7 min android 🤖apk 📲
✔️ df67dca #2 2024-03-15 10:27:57 ~8 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 9ecec30 #3 2024-03-18 08:57:15 ~5 min tests 📄log
✔️ 9ecec30 #3 2024-03-18 08:59:14 ~7 min android 🤖apk 📲
✔️ 9ecec30 #3 2024-03-18 08:59:14 ~7 min android-e2e 🤖apk 📲
✔️ 9ecec30 #3 2024-03-18 08:59:55 ~8 min ios 📱ipa 📲
✔️ d2caf9c #4 2024-03-18 16:40:04 ~5 min tests 📄log
✔️ d2caf9c #4 2024-03-18 16:42:26 ~8 min ios 📱ipa 📲
✔️ d2caf9c #4 2024-03-18 16:42:47 ~8 min android-e2e 🤖apk 📲
✔️ d2caf9c #4 2024-03-18 16:42:47 ~8 min android 🤖apk 📲

@OmarBasem OmarBasem requested a review from ulisesmac March 15, 2024 10:24
@OmarBasem OmarBasem force-pushed the wallet/derivation-path branch from df67dca to 9ecec30 Compare March 18, 2024 08:51
@OmarBasem OmarBasem requested a review from J-Son89 March 18, 2024 08:57
@OmarBasem
Copy link
Contributor Author

@J-Son89 re-review please 🙏

@OmarBasem OmarBasem requested a review from a team March 18, 2024 13:24
J-Son89
J-Son89 reviewed Mar 18, 2024
View reviewed changes
src/status_im/contexts/wallet/create_account/view.cljs
@@ -32,7 +32,7 @@
:customization-color account-color})
:action (when-not keypair-name :button)
:action-props {:on-press (fn []
(rf/dispatch [:navigate-to :scrren/wallet.select-keypair]))
(rf/dispatch [:navigate-to :screen/wallet.select-keypair]))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 !

J-Son89
J-Son89 reviewed Mar 18, 2024
View reviewed changes
src/status_im/contexts/wallet/create_account/view.cljs Outdated
@@ -41,7 +41,8 @@
:image :icon
:image-props :i/derivated-path
:action :button
:action-props {:on-press #(js/alert "Coming soon!")
:action-props {:on-press #(rf/dispatch [:navigate-to :screen/wallet.edit-derivation-path
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we keep this feature flagged while it's in progress? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I will update before merging

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🙏

smohamedjavid
smohamedjavid approved these changes Mar 18, 2024
View reviewed changes
src/status_im/contexts/wallet/create_account/edit_derivation_path/path_format_sheet/view.cljs Outdated
(defn view
[]
(let [{:keys [customization-color]} (rf/sub [:get-screen-params])]
[rn/view
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are no styles, can we use a fragment instead of a view?

@status-im-auto
Copy link
Member

92% of end-end tests have passed

Total executed tests: 48
Failed tests: 3
Expected to fail tests: 1
Passed tests: 44

IDs of failed tests: 702839,702948,702869 

IDs of expected to fail tests: 703503

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_delete, id: 702839

    Device 2: Tap on found: SendMessageButton
    Device 1: Looking for a message by text: delete for me 

    critical/chats/test_public_chat_browsing.py:376: in test_community_message_delete
    self.channel_1.chat_element_by_text(message_to_delete_for_me).wait_for_element(120)
../views/base_element.py:129: in wait_for_element
    raise TimeoutException(
 Device `1`: `ChatElementByText` by` xpath`: `//*[starts-with(@text,'delete for me')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_element



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_hashtag_links_to_community_channels, id: 702948

    Device 2: Tap on found: SendMessageButton
    Device 2: Looking for a message by text: https://status.app/c/ 

    critical/chats/test_public_chat_browsing.py:1014: in test_community_hashtag_links_to_community_channels
    self.chat_2.chat_element_by_text("https://status.app/c/").click_on_link_inside_message_body()
../views/chat_view.py:193: in click_on_link_inside_message_body
    self.message_body.wait_for_visibility_of_element(30)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_undo_delete_message, id: 702869

    Device 1: Tap on found: Button
    Device 1: Find Button by xpath: //*[@text="Undo"] 

    critical/chats/test_public_chat_browsing.py:112: in test_community_undo_delete_message
    self.channel.element_by_text("Undo").click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by xpath: `//*[@text="Undo"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (44)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    3. test_add_contact_field_validation, id: 702777
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    4. test_group_chat_pin_messages, id: 702732
    Device sessions

    5. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    6. test_group_chat_mute_chat, id: 703495
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    2. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_leave, id: 702845
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_markdown_support, id: 702809
    Device sessions

    4. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    3. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    5. test_community_unread_messages_badge, id: 702841
    Device sessions

    6. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    7. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    8. test_community_one_image_send_reply, id: 702859
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_several_images_send_reply, id: 703194
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_deep_links, id: 702775
    Device sessions

    2. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_edit_message, id: 702855
    Device sessions

    2. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    5. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    6. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    7. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    8. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    @OmarBasem OmarBasem force-pushed the wallet/derivation-path branch from 9ecec30 to d2caf9c Compare March 18, 2024 16:33
    @OmarBasem OmarBasem merged commit e5cee4b into develop Mar 18, 2024
    6 checks passed
    @OmarBasem OmarBasem deleted the wallet/derivation-path branch March 18, 2024 16:44
    @OmarBasem OmarBasem mentioned this pull request Apr 3, 2024
    Open
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @smohamedjavid smohamedjavid smohamedjavid approved these changes

    @vkjr vkjr Awaiting requested review from vkjr

    @briansztamfater briansztamfater Awaiting requested review from briansztamfater

    @shivekkhurana shivekkhurana Awaiting requested review from shivekkhurana

    @mmilad75 mmilad75 Awaiting requested review from mmilad75

    @ulisesmac ulisesmac Awaiting requested review from ulisesmac

    Assignees

    @OmarBasem OmarBasem

    Labels
    None yet
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Wallet: Edit derivation path screen
    4 participants
    @OmarBasem @status-im-auto @smohamedjavid @J-Son89