Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19159] Implement drawer action component #19159 #19289

Merged
merged 2 commits into from
Mar 28, 2024
Merged

[19159] Implement drawer action component #19159 #19289

merged 2 commits into from
Mar 28, 2024

Conversation

Rende11
Copy link
Collaborator

@Rende11 Rende11 commented Mar 15, 2024 •
edited
Loading

Fixes #19159

Summary

Drawer action component implementation

Review notes

Current action-drawer component actually implements Context Drawer component and should be renamed

Before and after screenshots comparison

Figma

iOS light iOS dark iOS blur
Simulator Screen Shot - iPhone 13 - 2024-03-15 at 20 45 20 Simulator Screen Shot - iPhone 13 - 2024-03-15 at 20 46 08 Simulator Screen Shot - iPhone 13 - 2024-03-15 at 20 46 39
Simulator.Screen.Recording.-.iPhone.13.-.2024-03-15.at.20.13.39.mp4

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Mar 15, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (28)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ ecfad26 #1 2024-03-15 17:56:06 ~1 min tests 📄log
✔️ ecfad26 #1 2024-03-15 18:00:41 ~6 min android 🤖apk 📲
✔️ ecfad26 #1 2024-03-15 18:00:46 ~6 min android-e2e 🤖apk 📲
✔️ ecfad26 #1 2024-03-15 18:02:53 ~8 min ios 📱ipa 📲
✔️ fc94757 #3 2024-03-17 13:14:16 ~5 min tests 📄log
✔️ fc94757 #3 2024-03-17 13:15:07 ~6 min android-e2e 🤖apk 📲
✔️ fc94757 #3 2024-03-17 13:15:14 ~6 min android 🤖apk 📲
✔️ fc94757 #3 2024-03-17 13:16:57 ~8 min ios 📱ipa 📲
✔️ 8e1bd69 #5 2024-03-19 11:59:28 ~6 min android-e2e 🤖apk 📲
✔️ 8e1bd69 #5 2024-03-19 12:00:36 ~7 min android 🤖apk 📲
✔️ 8e1bd69 #5 2024-03-19 12:02:12 ~9 min ios 📱ipa 📲
✔️ 8e1bd69 #7 2024-03-20 07:56:08 ~5 min tests 📄log
✔️ 3aed888 #9 2024-03-21 21:55:26 ~5 min tests 📄log
✔️ 3aed888 #7 2024-03-21 21:55:42 ~6 min android 🤖apk 📲
✔️ 3aed888 #7 2024-03-21 21:55:59 ~6 min android-e2e 🤖apk 📲
✔️ 3aed888 #7 2024-03-21 21:59:31 ~10 min ios 📱ipa 📲
❌ 22423eb #12 2024-03-26 20:17:05 ~1 min tests 📄log
✔️ 22423eb #10 2024-03-26 20:21:38 ~6 min android-e2e 🤖apk 📲
✔️ 22423eb #10 2024-03-26 20:22:12 ~6 min android 🤖apk 📲
✔️ 22423eb #10 2024-03-26 20:27:20 ~11 min ios 📱ipa 📲
❌ 3ef39c6 #13 2024-03-28 10:50:22 ~2 min tests 📄log
✔️ 3ef39c6 #11 2024-03-28 10:53:28 ~5 min android-e2e 🤖apk 📲
✔️ 3ef39c6 #11 2024-03-28 10:54:51 ~7 min android 🤖apk 📲
✔️ 3ef39c6 #11 2024-03-28 10:57:54 ~10 min ios 📱ipa 📲
❌ 6092cd1 #14 2024-03-28 11:22:07 ~2 min tests 📄log
✔️ 6092cd1 #12 2024-03-28 11:25:29 ~6 min android 🤖apk 📲
✔️ 6092cd1 #12 2024-03-28 11:26:31 ~7 min android-e2e 🤖apk 📲
✔️ 6092cd1 #12 2024-03-28 11:29:16 ~9 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5f1cbaa #15 2024-03-28 11:37:27 ~4 min tests 📄log
✔️ 5f1cbaa #13 2024-03-28 11:40:48 ~8 min android-e2e 🤖apk 📲
✔️ 5f1cbaa #13 2024-03-28 11:40:55 ~8 min android 🤖apk 📲
✔️ 5f1cbaa #13 2024-03-28 11:44:11 ~11 min ios 📱ipa 📲
✔️ 16871fa #14 2024-03-28 11:56:23 ~6 min android-e2e 🤖apk 📲
✔️ 16871fa #14 2024-03-28 11:57:25 ~7 min android 🤖apk 📲
✔️ 16871fa #14 2024-03-28 11:59:49 ~9 min ios 📱ipa 📲
✔️ 16871fa #17 2024-03-28 13:56:06 ~4 min tests 📄log

@Rende11 Rende11 force-pushed the 19159-drawer-action-component branch from 39a18f3 to fc94757 Compare March 17, 2024 13:08
flexsurfer
flexsurfer approved these changes Mar 18, 2024
View reviewed changes
src/quo/components/drawers/drawer_action/view.cljs Outdated Show resolved Hide resolved
src/quo/components/drawers/drawer_action/view.cljs Outdated Show resolved Hide resolved
src/quo/components/drawers/drawer_action/view.cljs Outdated Show resolved Hide resolved
@Rende11 Rende11 force-pushed the 19159-drawer-action-component branch from fcb5d8f to 8e1bd69 Compare March 19, 2024 11:52
@Rende11 Rende11 requested a review from flexsurfer March 19, 2024 11:55
@J-Son89
Copy link
Contributor

J-Son89 commented Mar 19, 2024

@Francesca-G can you give this quo component a design review when you get a chance? 🙏

@status-im-auto
Copy link
Member

83% of end-end tests have passed

Total executed tests: 48
Failed tests: 7
Expected to fail tests: 1
Passed tests: 40

IDs of failed tests: 702809,702948,702786,702947,702843,702845,703629 

IDs of expected to fail tests: 703503

Failed tests (7)

Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 2: Looking for a message by text: Message AFTER edit 2 (Edited)
    Device 2: Find `ChatElementByText` by `xpath`: `//*[starts-with(@text,'Message AFTER edit 2 (Edited)')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` 

    critical/chats/test_public_chat_browsing.py:353: in test_community_message_edit
    self.channel_2.set_reaction(message_text_after_edit)
../views/chat_view.py:1084: in set_reaction
    self.chat_element_by_text(message).long_press_until_element_is_shown(element)
../views/base_element.py:326: in long_press_until_element_is_shown
    element = self.find_element()
../views/chat_view.py:134: in find_element
    self.wait_for_visibility_of_element(20)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'Message AFTER edit 2 (Edited)')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809 

    Test setup failed: critical/chats/test_public_chat_browsing.py:838: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:444: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    2. test_community_hashtag_links_to_community_channels, id: 702948 

    Test setup failed: critical/chats/test_public_chat_browsing.py:838: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:444: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    3. test_community_mentions_push_notification, id: 702786

    Device 2: Find Button by xpath: //*[@content-desc='password-input']/../following-sibling::*//*[@text='Join Community']
    Device 2: Tap on found: Button 

    Test setup failed: critical/chats/test_public_chat_browsing.py:838: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:444: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    4. test_community_leave, id: 702845 

    Test setup failed: critical/chats/test_public_chat_browsing.py:838: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:444: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    5. test_community_join_when_node_owner_offline, id: 703629 

    Test setup failed: critical/chats/test_public_chat_browsing.py:838: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:444: in join_community
    self.community_status_joined.wait_for_visibility_of_element(60)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element



    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947

    Device 2: Tap on found: SendMessageButton
    # STEP: Checking unread indicators

    activity_center/test_activity_center.py:308: in test_activity_center_reply_read_unread_delete_filter_swipe
    self.home_1.notifications_unread_badge.wait_for_visibility_of_element(120)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: BaseElement by accessibility id:`activity-center-unread-count` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (40)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    6. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    @Rende11 thanks for the PR. Failed E2E are not PR related. cc @J-Son89

    clauxx
    clauxx approved these changes Mar 20, 2024
    View reviewed changes
    src/quo/components/drawers/drawer_action/schema.cljs Outdated Show resolved Hide resolved
    src/quo/components/drawers/drawer_action/schema.cljs Outdated Show resolved Hide resolved
    @Rende11 Rende11 force-pushed the 19159-drawer-action-component branch from fcf520f to 3aed888 Compare March 21, 2024 21:49
    @J-Son89
    Copy link
    Contributor

    J-Son89 commented Mar 22, 2024

    Hi @Francesca-G, I know you're busy but thought I'd ping here again incase this pr went unnoticed or slipped through. Could you please take a look when you get a chance 🙏

    Francesca-G
    Francesca-G reviewed Mar 22, 2024
    View reviewed changes
    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @J-Son89 so sorry I missed it, thanks for pinging me again 🙏

    here's the review ✨

    @flexsurfer
    Copy link
    Member

    • image
    • image
    • image

    @Rende11 Rende11 force-pushed the 19159-drawer-action-component branch 3 times, most recently from d0fb5e6 to 22423eb Compare March 26, 2024 20:15
    @Rende11
    Copy link
    Collaborator Author

    Rende11 commented Mar 26, 2024

    @Francesca-G
    I've fixed customization color in dark+blur, icon alignment, and added restriction in preview fro light themed blur

    @Rende11 Rende11 requested a review from Francesca-G March 26, 2024 20:17
    Francesca-G
    Francesca-G approved these changes Mar 28, 2024
    View reviewed changes
    Copy link

    @Francesca-G Francesca-G left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @Rende11 looks good now ✨

    @Rende11 Rende11 force-pushed the 19159-drawer-action-component branch from 22423eb to 3ef39c6 Compare March 28, 2024 10:47
    @Rende11
    [19159] Implement drawer action component
    5f1cbaa 
    Base component with styles

Add schema

Add component-spec

Clean up

Fix issues

Fix issues

Fix schema

Fix styles

Fix styles
    @Rende11 Rende11 force-pushed the 19159-drawer-action-component branch from 6092cd1 to 5f1cbaa Compare March 28, 2024 11:32
    @J-Son89 J-Son89 merged commit 3ee004a into status-im:develop Mar 28, 2024
    5 checks passed
    mmilad75 pushed a commit that referenced this pull request Apr 2, 2024
    @Rende11 @J-Son89 @mmilad75
    chore(quo): implement drawer action component (#19289)
    9099267 
    Co-authored-by: Jamie Caprani <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @J-Son89 J-Son89 J-Son89 approved these changes

    @Francesca-G Francesca-G Francesca-G approved these changes

    @clauxx clauxx clauxx approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    Assignees
    No one assigned
    Labels
    design-review-required external skip-manual-qa
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Implement Quo - Drawer/Drawer Action component
    7 participants
    @Rende11 @status-im-auto @J-Son89 @pavloburykh @flexsurfer @clauxx @Francesca-G