Fraschetti - Add wallet-search-ens-test #19338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (73)
|
FFFra
force-pushed
the
fraschetti/18348-wallet-add-contract-test-for-rpc-endpoint-ens_addressof
branch
from
8de9e76 to
5c6b66b
Compare
smohamedjavid
approved these changes
Mar 20, 2024
ulisesmac
reviewed
Mar 20, 2024
Comment on lines
68
to
79
|
|
||
| (defn assert-search-ens | ||
| [response] | ||
| (is (= "0xeefb13c7d42efcc655e528da6d6f7bbcf9a2251d" response))) | ||
|
|
||
| (deftest wallet-search-ens-test | ||
| (h/test-async :wallet/search-ens | ||
| (fn [] | ||
| (p/let [input "test.eth" | ||
| chain-id constants/ethereum-mainnet-chain-id | ||
| ens-address (contract-utils/call-rpc "ens_addressOf" chain-id input)] | ||
| (assert-search-ens ens-address))))) |
There was a problem hiding this comment.
Hey @FFFra , thanks for this PR
I think there are more cases to tests, for example giving a *.stateofus.eth address. atm I only know about the existance of qoqobolo.stateofus.eth on goerli.
We can also test the resolution on Sepolia and also the response for an invalid ENS.
wdyt?
FFFra
force-pushed
the
fraschetti/18348-wallet-add-contract-test-for-rpc-endpoint-ens_addressof
branch
from
5c6b66b to
0f88809
Compare
FFFra
force-pushed
the
fraschetti/18348-wallet-add-contract-test-for-rpc-endpoint-ens_addressof
branch
12 times, most recently
from
7296580 to
aa57eed
Compare
FFFra
force-pushed
the
fraschetti/18348-wallet-add-contract-test-for-rpc-endpoint-ens_addressof
branch
2 times, most recently
from
cc0890d to
b33d848
Compare
|
Status: 🚫 due 401 CI error |
briansztamfater
approved these changes
Mar 22, 2024
FFFra
force-pushed
the
fraschetti/18348-wallet-add-contract-test-for-rpc-endpoint-ens_addressof
branch
2 times, most recently
from
1f9087c to
f2ab6c1
Compare
FFFra
force-pushed
the
fraschetti/18348-wallet-add-contract-test-for-rpc-endpoint-ens_addressof
branch
4 times, most recently
from
ec30ad4 to
e56f28b
Compare
FFFra
force-pushed
the
fraschetti/18348-wallet-add-contract-test-for-rpc-endpoint-ens_addressof
branch
from
e56f28b to
a2ae87a
Compare
FFFra
force-pushed
the
fraschetti/18348-wallet-add-contract-test-for-rpc-endpoint-ens_addressof
branch
from
a2ae87a to
b61ee58
Compare
FFFra
deleted the
fraschetti/18348-wallet-add-contract-test-for-rpc-endpoint-ens_addressof
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18348
Epic #18587
Summary
This pull request introduces comprehensive tests for the
ens_addressOfendpoint, ensuring its robustness and reliability in our wallet functionality.Steps to test
run make test-contracts
status: ready!