Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide community channels when hide channels option is enabled #19378

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Hide community channels when hide channels option is enabled #19378

merged 1 commit into from
Mar 26, 2024

Conversation

ibrkhalil
Copy link
Contributor

fixes #19377

Summary

Hide channels when "hideIfPermissionsNotMet" flag is enabled and token-gating permissions are not fullfiled.

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Mar 23, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (15)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e92a246 #1 2024-03-23 11:40:40 ~7 min android-e2e 🤖apk 📲
✔️ e92a246 #1 2024-03-23 11:40:55 ~7 min android 🤖apk 📲
✔️ e92a246 #1 2024-03-23 11:44:19 ~10 min ios 📱ipa 📲
✔️ e92a246 #3 2024-03-23 12:16:53 ~6 min tests 📄log
✔️ 091d223 #2 2024-03-25 10:00:38 ~7 min android-e2e 🤖apk 📲
✔️ 091d223 #2 2024-03-25 10:00:42 ~7 min android 🤖apk 📲
✔️ 091d223 #2 2024-03-25 10:13:07 ~19 min ios 📱ipa 📲
✔️ 998b8c2 #5 2024-03-25 11:42:45 ~6 min android-e2e 🤖apk 📲
✔️ 998b8c2 #7 2024-03-25 11:42:59 ~6 min tests 📄log
✔️ 998b8c2 #5 2024-03-25 11:44:00 ~7 min android 🤖apk 📲
✔️ 998b8c2 #5 2024-03-25 11:46:16 ~9 min ios 📱ipa 📲
✔️ 69c1423 #8 2024-03-25 19:43:11 ~6 min tests 📄log
✔️ 69c1423 #6 2024-03-25 19:45:24 ~8 min android-e2e 🤖apk 📲
✔️ 69c1423 #6 2024-03-25 19:45:28 ~8 min android 🤖apk 📲
✔️ 69c1423 #6 2024-03-25 19:46:03 ~9 min ios 📱ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 79a4c3f #7 2024-03-26 09:32:00 ~6 min android-e2e 🤖apk 📲
✔️ 79a4c3f #9 2024-03-26 09:32:34 ~6 min tests 📄log
✔️ 79a4c3f #7 2024-03-26 09:33:13 ~7 min android 🤖apk 📲
✔️ 79a4c3f #7 2024-03-26 09:35:18 ~9 min ios 📱ipa 📲
✔️ bd831ee #8 2024-03-26 11:11:53 ~6 min android-e2e 🤖apk 📲
✔️ bd831ee #10 2024-03-26 11:12:33 ~6 min tests 📄log
✔️ bd831ee #8 2024-03-26 11:13:19 ~7 min android 🤖apk 📲
✔️ bd831ee #8 2024-03-26 11:14:22 ~8 min ios 📱ipa 📲

@ibrkhalil ibrkhalil self-assigned this Mar 23, 2024
seanstrom
seanstrom approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@seanstrom seanstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🙌

flexsurfer
flexsurfer requested changes Mar 25, 2024
View reviewed changes
src/status_im/subs/communities.cljs Outdated Show resolved Hide resolved
src/status_im/subs/communities.cljs Outdated Show resolved Hide resolved
@pavloburykh pavloburykh self-assigned this Mar 25, 2024
@status-im-auto
Copy link
Member

92% of end-end tests have passed

Total executed tests: 48
Failed tests: 3
Expected to fail tests: 1
Passed tests: 44

IDs of failed tests: 702731,702869,703391 

IDs of expected to fail tests: 703503

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731

    Device 1: Find `Button` by `xpath`: `//*[@content-desc='pins-count']//android.widget.TextView`
    Device 2: Find `Button` by `xpath`: `//*[@content-desc='pins-count']//android.widget.TextView` 

    critical/chats/test_1_1_public_chats.py:267: in test_1_1_chat_pin_messages
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Pinned messages count is 2 but should be 3 for user 2



    Device sessions

    2. test_1_1_chat_send_image_save_and_share, id: 703391

    Device 2: Find Button by accessibility id: image-0
    Device 2: Click system back button 

    critical/chats/test_1_1_public_chats.py:457: in test_1_1_chat_send_image_save_and_share
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message about saving a photo is not shown for receiver.



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_undo_delete_message, id: 702869

    Device 1: Tap on found: Button
    Device 1: Find Button by xpath: //*[@text="Undo"] 

    critical/chats/test_public_chat_browsing.py:112: in test_community_undo_delete_message
    self.channel.element_by_text("Undo").click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by xpath: `//*[@text="Undo"]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (44)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    3. test_group_chat_offline_pn, id: 702808
    Device sessions

    4. test_group_chat_pin_messages, id: 702732
    Device sessions

    5. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    6. test_group_chat_mute_chat, id: 703495
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_leave, id: 702845
    Device sessions

    2. test_community_mentions_push_notification, id: 702786
    Device sessions

    3. test_community_markdown_support, id: 702809
    Device sessions

    4. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    2. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    3. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    5. test_community_unread_messages_badge, id: 702841
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    8. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    9. test_community_one_image_send_reply, id: 702859
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_several_images_send_reply, id: 703194
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_deep_links, id: 702775
    Device sessions

    2. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    4. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    2. test_navigation_jump_to, id: 702936
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_edit_message, id: 702855
    Device sessions

    2. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    5. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    6. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    3. test_add_contact_field_validation, id: 702777
    Device sessions

    @qoqobolo qoqobolo mentioned this pull request Mar 25, 2024
    Merged
    @pavloburykh
    Copy link
    Contributor

    @ibrkhalil thank you for the fix! Ready for merge

    @cammellos cammellos merged commit c86cdf9 into develop Mar 26, 2024
    2 checks passed
    @cammellos cammellos deleted the 19377 branch March 26, 2024 12:08
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    @seanstrom seanstrom seanstrom approved these changes

    @cammellos cammellos Awaiting requested review from cammellos

    @ajayesivan ajayesivan Awaiting requested review from ajayesivan

    Assignees

    @ibrkhalil ibrkhalil

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Hidden channel is displayed for users who do not have permission to access it
    6 participants
    @ibrkhalil @status-im-auto @pavloburykh @seanstrom @flexsurfer @cammellos