Use scrollable multiline text-input in contact request form #19383

seanstrom · 2024-03-25T11:09:17Z

fixes #19324

Summary

This PR attempts to resolve an issue with the contact request form growing too large and overflowing the app screen.
- This PR modifies the bottom-sheet component to adjust its max-height based on the presence of a keyboard.
- This PR modifies what props are allowed to be passed the quo input component:
  - input-container-style can now be passed to override the styles of the input component.
    - These override styles are used to customise the layout of a multiline input to grow in height until its parent container reaches their max-height, afterwards the quo input component will overflow its content inside text-input scrollable area.

Testing notes

It should be noted that scrolling the text-input on Android does not seem to show the scrollbar.

Platforms

Android
iOS

Areas that maybe impacted

Functional

Contact request form
potentially other inputs or forms with inputs

Steps to test

Open Status mobile
View a profile of a user that is not a contact
Press the "send contact request" button
Type inside the contact request form input and add newline characters
Grow the text-input until it reaches the max height and attempt to scroll the text-input content.

Before and after screenshots comparison

Before

Here's a recording of the behaviour before this PR: #19324

After iOS

Screen.Recording.2024-03-25.at.10.30.15.mov

After Android

Screen.Recording.2024-03-25.at.10.49.23.mov

status: ready

status-im-auto · 2024-03-25T11:16:36Z

Jenkins Builds

Click to see older builds (36)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`213ecbc`	#1	2024-03-25 11:16:36	~6 min	`tests`	📄`log`
✔️	`213ecbc`	#1	2024-03-25 11:17:26	~7 min	`android`	🤖`apk` 📲
✔️	`213ecbc`	#1	2024-03-25 11:17:30	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`213ecbc`	#1	2024-03-25 11:20:51	~11 min	`ios`	📱`ipa` 📲

❌	`be9fca2`	#2	2024-03-25 12:22:48	~1 min	`tests`	📄`log`
✔️	`be9fca2`	#2	2024-03-25 12:27:24	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`be9fca2`	#2	2024-03-25 12:29:52	~8 min	`android`	🤖`apk` 📲
✔️	`be9fca2`	#2	2024-03-25 12:38:10	~16 min	`ios`	📱`ipa` 📲

❌	`b40e7a3`	#3	2024-03-25 15:26:52	~57 sec	`tests`	📄`log`
✔️	`b40e7a3`	#3	2024-03-25 15:32:54	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`b40e7a3`	#3	2024-03-25 15:32:55	~7 min	`android`	🤖`apk` 📲
✔️	`b40e7a3`	#3	2024-03-25 15:35:29	~9 min	`ios`	📱`ipa` 📲

❌	`403085d`	#4	2024-03-25 18:04:27	~1 min	`tests`	📄`log`
✔️	`403085d`	#4	2024-03-25 18:09:58	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`403085d`	#4	2024-03-25 18:10:07	~7 min	`android`	🤖`apk` 📲
✔️	`403085d`	#4	2024-03-25 18:12:19	~9 min	`ios`	📱`ipa` 📲

❌	`d9169ac`	#5	2024-03-26 06:55:02	~1 min	`tests`	📄`log`

❌	`912de96`	#6	2024-03-26 06:57:11	~1 min	`tests`	📄`log`
✔️	`912de96`	#6	2024-03-26 07:02:33	~6 min	`android`	🤖`apk` 📲
✔️	`912de96`	#6	2024-03-26 07:02:40	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`912de96`	#6	2024-03-26 07:04:08	~8 min	`ios`	📱`ipa` 📲

✔️	`fee0d7e`	#7	2024-03-26 08:39:05	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`fee0d7e`	#7	2024-03-26 08:39:16	~6 min	`android`	🤖`apk` 📲
✔️	`fee0d7e`	#7	2024-03-26 08:40:01	~7 min	`tests`	📄`log`
✔️	`fee0d7e`	#7	2024-03-26 08:43:53	~11 min	`ios`	📱`ipa` 📲

✔️	`a91a676`	#8	2024-03-26 15:44:17	~5 min	`android`	🤖`apk` 📲
✔️	`a91a676`	#8	2024-03-26 15:45:09	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`a91a676`	#8	2024-03-26 15:47:37	~9 min	`ios`	📱`ipa` 📲

✔️	`b670872`	#9	2024-04-03 08:06:56	~3 min	`tests`	📄`log`
✔️	`b670872`	#9	2024-04-03 08:11:03	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`b670872`	#9	2024-04-03 08:11:09	~8 min	`android`	🤖`apk` 📲
✔️	`b670872`	#9	2024-04-03 08:13:10	~10 min	`ios`	📱`ipa` 📲

✔️	`251f63a`	#10	2024-04-03 15:26:36	~4 min	`tests`	📄`log`
✔️	`251f63a`	#10	2024-04-03 15:29:45	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`251f63a`	#10	2024-04-03 15:29:46	~7 min	`android`	🤖`apk` 📲
✔️	`251f63a`	#10	2024-04-03 15:32:35	~10 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`76f224f`	#11	2024-04-04 14:08:48	~4 min	`tests`	📄`log`

✔️	`68409f5`	#12	2024-04-04 14:14:59	~5 min	`tests`	📄`log`
✔️	`68409f5`	#12	2024-04-04 14:17:36	~7 min	`android`	🤖`apk` 📲
✔️	`68409f5`	#12	2024-04-04 14:17:56	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`68409f5`	#12	2024-04-04 14:23:39	~13 min	`ios`	📱`ipa` 📲

src/status_im/common/bottom_sheet/view.cljs

ulisesmac

Thanks for fixing it @seanstrom !

src/status_im/contexts/profile/contact/contact_request/style.cljs

src/status_im/contexts/profile/contact/contact_request/view.cljs

status-im-auto · 2024-03-25T17:56:59Z

94% of end-end tests have passed

Total executed tests: 48
Failed tests: 2
Expected to fail tests: 1
Passed tests: 45

IDs of failed tests: 702777,703495

IDs of expected to fail tests: 703503

Failed tests (2)

Click to expand

Rerun failed tests

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777

Device 1: Find `Button` by `xpath`: `//*[@text="Paste"]`
Device 1: Tap on found: Button

activity_center/test_activity_center.py:237: in test_add_contact_field_validation
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Error message is not shown for value "zQ3shpbYzrp2f12hsJeb5bRk3M3V8dN7Vz1XEGPgu55FK1i1"

Device sessions

Device 1:

Device 2:

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495

# STEP: Change device time so chat will be unmuted by timer
Device 2: Long press on ChatElement

critical/chats/test_group_chat.py:459: in test_group_chat_mute_chat
    chat.long_press_element()
../views/base_element.py:323: in long_press_element
    action.long_press(element).release().perform()
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/common/touch_action.py:174: in perform
    self._driver.execute(Command.TOUCH_ACTION, params)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute
    self.error_handler.check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:122: in check_response
    raise exception_class(msg=message, stacktrace=format_stacktrace(stacktrace))
 The element 'By.xpath: //*[@content-desc='author-primary-name'][starts-with(@text,'jicifwt')]/..' is not linked to the same object in DOM anymore; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#stale-element-reference-exception
E   Stacktrace:
E   io.appium.uiautomator2.common.exceptions.StaleElementReferenceException: The element 'By.xpath: //*[@content-desc='author-primary-name'][starts-with(@text,'jicifwt')]/..' is not linked to the same object in DOM anymore
E   	at io.appium.uiautomator2.model.ElementsCache.restore(ElementsCache.java:122)
E   	at io.appium.uiautomator2.model.ElementsCache.get(ElementsCache.java:153)
E   	at io.appium.uiautomator2.handler.Location.safeHandle(Location.java:23)
E   	at io.appium.uiautomator2.handler.request.SafeRequestHandler.handle(SafeRequestHandler.java:59)
E   	at io.appium.uiautomator2.server.AppiumServlet.handleRequest(AppiumServlet.java:277)
E   	at io.appium.uiautomator2.server.AppiumServlet.handleHttpRequest(AppiumServlet.java:271)
E   	at io.appium.uiautomator2.http.ServerHandler.channelRead(ServerHandler.java:68)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:435)
E   	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:293)
E   	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:267)
E   	at io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:250)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:266)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1294)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:911)
E   	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131)
E   	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:611)
E   	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:552)
E   	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:466)
E   	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:438)
E   	at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:140)
E   	at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
E   	at java.lang.Thread.run(Thread.java:1012)

Device sessions

Device 1:

Device 2:

Device 3:

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (45)

Click to expand

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_join_when_node_owner_offline, id: 703629
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

src/status_im/contexts/profile/contact/contact_request/view.cljs

seanstrom · 2024-03-26T06:55:59Z

@status-im/mobile-qa can you please review these E2E results? 🙏

pavloburykh · 2024-03-26T07:55:15Z

@seanstrom thanks for the PR. Failed e2e are not PR related.

BalogunofAfrica

LGTM

status-im-auto · 2024-04-03T14:09:47Z

56% of end-end tests have passed

Total executed tests: 48
Failed tests: 20
Expected to fail tests: 1
Passed tests: 27

IDs of failed tests: 702809,703194,702859,702957,702840,703086,702948,702894,704615,702936,702786,702839,702947,702838,702844,702843,702845,702958,703629,702841

IDs of expected to fail tests: 703503

Failed tests (20)

Click to expand

Rerun failed tests

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device 2: Type `qwerty1234` to `EditBox` Device 2: Find `LogInButton` by `accessibility id`: `login-button` Test setup failed: activity_center/test_activity_center.py:421: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Test setup failed: activity_center/test_activity_center.py:421: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device 2: Type `qwerty1234` to `EditBox` Device 2: Find `LogInButton` by `accessibility id`: `login-button` Test setup failed: activity_center/test_activity_center.py:282: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Test setup failed: activity_center/test_activity_center.py:282: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Test setup failed: critical/chats/test_public_chat_browsing.py:840: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_community_hashtag_links_to_community_channels, id: 702948
Test setup failed: critical/chats/test_public_chat_browsing.py:840: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
3. test_community_mentions_push_notification, id: 702786
Device 2: Type `qwerty1234` to `EditBox` Device 2: Find `LogInButton` by `accessibility id`: `login-button` Test setup failed: critical/chats/test_public_chat_browsing.py:840: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_community_leave, id: 702845
Test setup failed: critical/chats/test_public_chat_browsing.py:840: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
5. test_community_join_when_node_owner_offline, id: 703629
Test setup failed: critical/chats/test_public_chat_browsing.py:840: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_community_one_image_send_reply, id: 702859
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
3. test_community_emoji_send_copy_paste_reply, id: 702840
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
4. test_community_mark_all_messages_as_read, id: 703086
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
5. test_community_contact_block_unblock_offline, id: 702894
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
6. test_community_edit_delete_message_when_offline, id: 704615
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
7. test_community_message_delete, id: 702839
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device 2: Type `qwerty1234` to `EditBox` Device 2: Find `LogInButton` by `accessibility id`: `login-button` Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
10. test_community_message_edit, id: 702843
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
11. test_community_unread_messages_badge, id: 702841
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (27)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
6. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

qoqobolo · 2024-04-03T14:23:41Z

Hey @seanstrom , thanks for the fix!
Found some issues related to the message preview, could you take a look, please?
They actually seem to be the same issue, but I'll split them into two:

ISSUE 1: Long message preview overflows the app screen

Steps to reproduce:

Open chat
Send a long message
Long tap the message

Expected result (nightly):

video_2024-04-03_16-09-40.mp4

Actual result (PR):

video_2024-04-03_16-10-01.mp4

ISSUE 2: Image/link preview is not visible at all or partially hidden behind the bottom sheet

Comparison of image preview behavior in release (it's equal to nightly in this case) and PR on iOS (iPhone SE):

IMG_2013.MP4

Another example of the image preview: on this Android device it's partially hidden (Huawei P40 lite)

Link preview behavior in PR (Android and iOS):

IMG_2014.MP4

seanstrom · 2024-04-03T14:42:48Z

@qoqobolo Great finds! 🙌
I’ll take a look at fixing these asap, thank you 🙏

status-im-auto · 2024-04-03T14:45:41Z

0% of end-end tests have passed

Total executed tests: 20
Failed tests: 20
Expected to fail tests: 0
Passed tests: 0

IDs of failed tests: 702845,702840,702894,703086,702947,702958,702786,702844,702841,702839,702809,702838,704615,702948,702859,703629,702957,702843,702936,703194

Failed tests (20)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_leave, id: 702845
Test setup failed: critical/chats/test_public_chat_browsing.py:840: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_community_mentions_push_notification, id: 702786
Device 2: Type `qwerty1234` to `EditBox` Device 2: Find `LogInButton` by `accessibility id`: `login-button` Test setup failed: critical/chats/test_public_chat_browsing.py:840: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_community_markdown_support, id: 702809
Test setup failed: critical/chats/test_public_chat_browsing.py:840: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
4. test_community_hashtag_links_to_community_channels, id: 702948
Test setup failed: critical/chats/test_public_chat_browsing.py:840: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
5. test_community_join_when_node_owner_offline, id: 703629
Test setup failed: critical/chats/test_public_chat_browsing.py:840: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Test setup failed: activity_center/test_activity_center.py:282: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_navigation_jump_to, id: 702936
Device 2: Type `qwerty1234` to `EditBox` Device 2: Find `LogInButton` by `accessibility id`: `login-button` Test setup failed: activity_center/test_activity_center.py:282: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_admin_notification_accept_swipe, id: 702958
Test setup failed: activity_center/test_activity_center.py:421: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_activity_center_mentions, id: 702957
Device 2: Type `qwerty1234` to `EditBox` Device 2: Find `LogInButton` by `accessibility id`: `login-button` Test setup failed: activity_center/test_activity_center.py:421: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_community_contact_block_unblock_offline, id: 702894
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
3. test_community_mark_all_messages_as_read, id: 703086
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
5. test_community_unread_messages_badge, id: 702841
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
6. test_community_message_delete, id: 702839
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device 2: Type `qwerty1234` to `EditBox` Device 2: Find `LogInButton` by `accessibility id`: `login-button` Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
8. test_community_edit_delete_message_when_offline, id: 704615
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
9. test_community_one_image_send_reply, id: 702859
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
10. test_community_message_edit, id: 702843
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
11. test_community_several_images_send_reply, id: 703194
Test setup failed: critical/chats/test_public_chat_browsing.py:322: in prepare_devices self.community_2.join_community() ../views/chat_view.py:423: in join_community self.login_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: LogInButton by accessibility id: `login-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

seanstrom · 2024-04-03T15:26:22Z

@qoqobolo I think I may have found a fix for those issues, can you test this again please? 🙏

status-im-auto · 2024-04-03T21:46:22Z

88% of end-end tests have passed

Total executed tests: 48
Failed tests: 5
Expected to fail tests: 1
Passed tests: 42

IDs of failed tests: 702838,703629,702783,703391,702732

IDs of expected to fail tests: 703503

Failed tests (5)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_send_check_timestamps_sender_username, id: 702838

Device 2: Verifying that 'new message' is under today
Device 2: Looking for a message by text: new message

critical/chats/test_public_chat_browsing.py:339: in test_community_message_send_check_timestamps_sender_username
    self.channel_2.verify_message_is_under_today_text(new_message, self.errors, 60)
../views/chat_view.py:989: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element(timeout)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'new message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Device 2:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device 2: Find `Text` by `xpath`: `//[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-status']/android.widget.TextView` Device 2: `Text` is `Sent` `critical/chats/test_1_1_public_chats.py:614: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message status was not changed to Delivered, it's Sent after back up online!` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device 2: Find `Text` by `xpath`: `//[@content-desc='pinned-messages-menu']//[starts-with(@text,'Message 4')]/../../*[@content-desc='pinned-by']/android.widget.TextView` Device 2: `Text` is `user admin` `critical/chats/test_group_chat.py:404: in test_group_chat_pin_messages self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message 1 is not pinned in group chat! E Pinned messages count 2 doesn't match expected 3 for user 2 E Message 'Message 1' is missed on Pinned messages list for user 2` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_send_image_save_and_share, id: 703391

Device 2: Find Button by accessibility id: image-0
Device 2: Click system back button

critical/chats/test_1_1_public_chats.py:458: in test_1_1_chat_send_image_save_and_share
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Not expected image is shown to the receiver.

Device sessions

Device 1:

Device 2:

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_join_when_node_owner_offline, id: 703629

Device 2: Looking for community: 'open community'
Device 2: Click until Text by accessibility id: community-description-text will be presented

critical/chats/test_public_chat_browsing.py:1181: in test_community_join_when_node_owner_offline
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Text "You joined “closed community”" in shown toast element doesn't match expected "You joined “open community”"

Device sessions

Device 1:

Device 2:

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (42)

Click to expand

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs
2. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
4. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

qoqobolo · 2024-04-04T10:30:12Z

Sorry for the delay @seanstrom!
And thanks for the fixes 🙏 no other issues found, PR can be merged.

… the input container, and container

… reached for the bottom-sheet

…missed on android

seanstrom self-assigned this Mar 25, 2024

ibrkhalil reviewed Mar 25, 2024

View reviewed changes

src/status_im/common/bottom_sheet/view.cljs Outdated Show resolved Hide resolved

ibrkhalil requested a review from flexsurfer March 25, 2024 11:44

flexsurfer requested review from ulisesmac and BalogunofAfrica March 25, 2024 12:34

ulisesmac approved these changes Mar 25, 2024

View reviewed changes

src/status_im/contexts/profile/contact/contact_request/style.cljs Outdated Show resolved Hide resolved

src/status_im/contexts/profile/contact/contact_request/view.cljs Show resolved Hide resolved

src/status_im/contexts/profile/contact/contact_request/view.cljs Outdated Show resolved Hide resolved

flexsurfer approved these changes Mar 25, 2024

View reviewed changes

src/status_im/contexts/profile/contact/contact_request/view.cljs Show resolved Hide resolved

J-Son89 reviewed Mar 25, 2024

View reviewed changes

src/status_im/contexts/profile/contact/contact_request/view.cljs Outdated Show resolved Hide resolved

seanstrom force-pushed the seanstrom/scrollable-multiline-textinput branch from d9169ac to 912de96 Compare March 26, 2024 06:55

seanstrom added the request-manual-qa label Mar 26, 2024

BalogunofAfrica approved these changes Mar 26, 2024

View reviewed changes

seanstrom force-pushed the seanstrom/scrollable-multiline-textinput branch from fee0d7e to a91a676 Compare March 26, 2024 15:38

seanstrom force-pushed the seanstrom/scrollable-multiline-textinput branch from a91a676 to b670872 Compare April 3, 2024 08:02

qoqobolo self-assigned this Apr 3, 2024

seanstrom force-pushed the seanstrom/scrollable-multiline-textinput branch from b670872 to 251f63a Compare April 3, 2024 15:21

qoqobolo added the Tested - OK label Apr 4, 2024

seanstrom force-pushed the seanstrom/scrollable-multiline-textinput branch from 251f63a to 76f224f Compare April 4, 2024 14:03

seanstrom added 11 commits April 4, 2024 15:09

tweak: augment bottom-sheet component to be aware of keyboard height

01e90a5

tweak: augment quo input component to allow for styling of the input,…

4efd37f

… the input container, and container

tweak: augment contact request input to grow until max screen size is…

4d58cb3

… reached for the bottom-sheet

tweak: handle blurring the contact request input when keyboard is dis…

6e0f3ab

…missed on android

tidy: refactor with the use-keyboard hook

339404c

tweak: use on-layout for measuring sheet max-height

72b1762

tweak: remove use of input-style and flex-direction column

0635301

tidy: remove unused requires

46d1788

tidy: use container-style prop

ec900c7

tidy: fix formatting

536127c

fix: default layout-height to window-height

68409f5

seanstrom force-pushed the seanstrom/scrollable-multiline-textinput branch from 76f224f to 68409f5 Compare April 4, 2024 14:09

seanstrom merged commit d24eb96 into develop Apr 4, 2024
6 checks passed

seanstrom deleted the seanstrom/scrollable-multiline-textinput branch April 4, 2024 14:54

Use scrollable multiline text-input in contact request form #19383

Use scrollable multiline text-input in contact request form #19383

Conversation

seanstrom commented Mar 25, 2024 • edited Loading

Summary

Testing notes

Platforms

Areas that maybe impacted

Functional

Steps to test

Before and after screenshots comparison

Before

After iOS

After Android

status-im-auto commented Mar 25, 2024 • edited Loading

Jenkins Builds

ulisesmac left a comment

Choose a reason for hiding this comment

status-im-auto commented Mar 25, 2024

94% of end-end tests have passed

Failed tests (2)

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (45)

Class TestActivityMultipleDevicePRTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestDeepLinksOneDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMergedTwo:

seanstrom commented Mar 26, 2024

pavloburykh commented Mar 26, 2024 • edited Loading

BalogunofAfrica left a comment

Choose a reason for hiding this comment

status-im-auto commented Apr 3, 2024

56% of end-end tests have passed

Failed tests (20)

Class TestActivityMultipleDevicePRTwo:

Class TestActivityMultipleDevicePR:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityMultipleDeviceMerged:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (27)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestDeepLinksOneDevice:

qoqobolo commented Apr 3, 2024

ISSUE 1: Long message preview overflows the app screen

ISSUE 2: Image/link preview is not visible at all or partially hidden behind the bottom sheet

seanstrom commented Apr 3, 2024

status-im-auto commented Apr 3, 2024

0% of end-end tests have passed

Failed tests (20)

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityMultipleDevicePR:

Class TestActivityMultipleDevicePRTwo:

Class TestCommunityMultipleDeviceMerged:

seanstrom commented Apr 3, 2024

status-im-auto commented Apr 3, 2024

88% of end-end tests have passed

Failed tests (5)

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMergedTwo:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (42)

Class TestActivityMultipleDevicePRTwo:

seanstrom commented Mar 25, 2024 •

edited

Loading

status-im-auto commented Mar 25, 2024 •

edited

Loading

pavloburykh commented Mar 26, 2024 •

edited

Loading