Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legacy settings seed backup #19487

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Fix legacy settings seed backup #19487

merged 1 commit into from
Apr 4, 2024

Conversation

clauxx
Copy link
Member

@clauxx clauxx commented Apr 3, 2024

fixes #19485

Summary

Fix legacy settings seed backup

Steps to test

  • Open Status
  • open settings
  • open legacy settings
  • open privacy settings
  • open seed backup settings

status: ready

@clauxx clauxx self-assigned this Apr 3, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Apr 3, 2024

Jenkins Builds

Click to see older builds (31)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ fbf5289 #1 2024-04-03 09:16:41 ~4 min tests 📄log
✔️ fbf5289 #1 2024-04-03 09:20:13 ~8 min android-e2e 🤖apk 📲
✔️ fbf5289 #1 2024-04-03 09:20:36 ~8 min android 🤖apk 📲
✔️ 50f0312 #2 2024-04-03 09:24:59 ~4 min tests 📄log
✔️ 50f0312 #2 2024-04-03 09:28:46 ~7 min android-e2e 🤖apk 📲
✔️ 50f0312 #2 2024-04-03 09:28:52 ~7 min android 🤖apk 📲
✔️ 50f0312 #2 2024-04-03 09:37:26 ~16 min ios 📱ipa 📲
✔️ e1bea30 #3 2024-04-03 12:10:44 ~3 min tests 📄log
✔️ e1bea30 #3 2024-04-03 12:13:12 ~6 min android-e2e 🤖apk 📲
✔️ ad69edf #4 2024-04-03 12:17:11 ~3 min tests 📄log
✔️ ad69edf #4 2024-04-03 12:19:40 ~6 min android 🤖apk 📲
✔️ ad69edf #4 2024-04-03 12:19:45 ~6 min android-e2e 🤖apk 📲
✔️ ad69edf #4 2024-04-03 12:24:54 ~11 min ios 📱ipa 📲
✔️ a4f39bc #5 2024-04-03 14:11:48 ~4 min tests 📄log
✔️ a4f39bc #5 2024-04-03 14:15:22 ~7 min android-e2e 🤖apk 📲
✔️ a4f39bc #5 2024-04-03 14:16:14 ~8 min ios 📱ipa 📲
✔️ a4f39bc #5 2024-04-03 14:16:19 ~8 min android 🤖apk 📲
✔️ 0cad32a #6 2024-04-04 07:25:09 ~4 min tests 📄log
✔️ 0cad32a #6 2024-04-04 07:28:45 ~8 min android-e2e 🤖apk 📲
✔️ 0cad32a #6 2024-04-04 07:28:51 ~8 min android 🤖apk 📲
✔️ 0cad32a #6 2024-04-04 07:30:49 ~10 min ios 📱ipa 📲
✔️ ab97952 #7 2024-04-04 09:48:51 ~7 min android-e2e 🤖apk 📲
✔️ ab97952 #7 2024-04-04 09:49:04 ~7 min android 🤖apk 📲
✔️ ab97952 #7 2024-04-04 09:50:47 ~8 min ios 📱ipa 📲
✔️ ad532d6 #8 2024-04-04 11:28:56 ~4 min tests 📄log
✔️ ad532d6 #8 2024-04-04 11:32:46 ~8 min ios 📱ipa 📲
✔️ ad532d6 #8 2024-04-04 11:32:59 ~8 min android 🤖apk 📲
✔️ ad532d6 #8 2024-04-04 11:32:59 ~8 min android-e2e 🤖apk 📲
✔️ 240cf09 #9 2024-04-04 14:17:50 ~6 min android-e2e 🤖apk 📲
✔️ 240cf09 #9 2024-04-04 14:18:23 ~7 min android 🤖apk 📲
✔️ 240cf09 #9 2024-04-04 14:25:10 ~14 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9096721 #11 2024-04-04 15:06:09 ~3 min tests 📄log
✔️ 9096721 #10 2024-04-04 15:09:31 ~7 min android-e2e 🤖apk 📲
✔️ 9096721 #10 2024-04-04 15:09:39 ~7 min android 🤖apk 📲
✔️ 9096721 #10 2024-04-04 15:11:17 ~9 min ios 📱ipa 📲
✔️ 7dc2d5c #12 2024-04-04 15:30:00 ~4 min tests 📄log
✔️ 7dc2d5c #11 2024-04-04 15:32:59 ~7 min android-e2e 🤖apk 📲
✔️ 7dc2d5c #11 2024-04-04 15:33:05 ~7 min android 🤖apk 📲
✔️ 7dc2d5c #11 2024-04-04 15:35:18 ~10 min ios 📱ipa 📲

@J-Son89
Copy link
Contributor

J-Son89 commented Apr 3, 2024

thanks! 🙏

@status-im-auto
Copy link
Member

96% of end-end tests have passed

Total executed tests: 48
Failed tests: 1
Expected to fail tests: 1
Passed tests: 46
IDs of failed tests: 702957 
IDs of expected to fail tests: 703503 

Failed tests (1)

Click to expand
  • Rerun failed tests

  • Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957

    Device 2: Tap on found: SendMessageButton
    # STEP: Checking unread indicators

    activity_center/test_activity_center.py:435: in test_activity_center_mentions
        self.home_1.notifications_unread_badge.wait_for_visibility_of_element(120)
    ../views/base_element.py:147: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 1: BaseElement by accessibility id:`activity-center-unread-count` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503

    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (46)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    6. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    @VolodLytvynenko VolodLytvynenko self-assigned this Apr 3, 2024
    @VolodLytvynenko
    Copy link
    Contributor

    hi @clauxx thank you for PR. No issues from my side. Ready to be merged

    @status-im-auto
    Copy link
    Member

    ✔️ status-mobile/prs/android-e2e/PR-19487#3 🔹 ~6 min 21 sec 🔹 e1bea30 🔹 📦 android-e2e package

    @clauxx clauxx force-pushed the cl-19485-fix-seed-backup branch from 240cf09 to 9096721 Compare April 4, 2024 15:01
    @clauxx clauxx force-pushed the cl-19485-fix-seed-backup branch from 9096721 to 7dc2d5c Compare April 4, 2024 15:25
    @clauxx clauxx merged commit 0a6eaf1 into develop Apr 4, 2024
    6 checks passed
    @clauxx clauxx deleted the cl-19485-fix-seed-backup branch April 4, 2024 15:35
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Archived in project
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    "No matching clause: screen/onboardin info" error is shown when backing up seed phrase
    6 participants